Re: OpenSMTPD docs: smtpctl.8

2021-02-12 Thread Jason McIntyre
On Fri, Feb 12, 2021 at 03:23:38PM +, Larry Hynes wrote: > > Index: smtpctl.8 > === > RCS file: /cvs/src/usr.sbin/smtpd/smtpctl.8,v > retrieving revision 1.65 > diff -u -p -r1.65 smtpctl.8 > --- smtpctl.8 14 Sep 2020 09:48:08

Re: OpenSMTPD docs: newaliases.8

2021-02-12 Thread Jason McIntyre
On Fri, Feb 12, 2021 at 03:21:16PM +, Larry Hynes wrote: > > Index: newaliases.8 > === > RCS file: /cvs/src/usr.sbin/smtpd/newaliases.8,v > retrieving revision 1.12 > diff -u -p -r1.12 newaliases.8 > --- newaliases.8 20 Jul

Re: OpenSMTPD docs: makemap.8

2021-02-12 Thread Jason McIntyre
On Fri, Feb 12, 2021 at 03:19:53PM +, Larry Hynes wrote: > Note: DNS is mentioned in this file as a way of accessing maps. Aside > from this mention it appears to be undocumented. > > Index: makemap.8 > === > RCS file:

Re: video(4) multiple opens

2021-02-12 Thread Claudio Jeker
On Fri, Feb 12, 2021 at 10:59:05PM +0100, Jeremie Courreges-Anglas wrote: > On Wed, Feb 10 2021, Martin Pieuchot wrote: > > [...] > > > Which fields is the new lock protecting? Why isn't the KERNEL_LOCK() > > enough? > > When I mentioned this potential lack of locking to Marcus, I was >

Re: OpenSMTPD docs: mail.maildir.8

2021-02-12 Thread Jason McIntyre
On Fri, Feb 12, 2021 at 03:16:57PM +, Larry Hynes wrote: > > Index: mail.maildir.8 > === > RCS file: /cvs/src/usr.sbin/smtpd/mail.maildir.8,v > retrieving revision 1.5 > diff -u -p -r1.5 mail.maildir.8 > --- mail.maildir.830

Re: OpenSMTPD docs: forward.5

2021-02-12 Thread Jason McIntyre
On Fri, Feb 12, 2021 at 03:15:47PM +, Larry Hynes wrote: > > Index: forward.5 > === > RCS file: /cvs/src/usr.sbin/smtpd/forward.5,v > retrieving revision 1.9 > diff -u -p -r1.9 forward.5 > --- forward.5 13 Mar 2015 22:41:54 -

Re: OpenSMTPD docs: aliases.5

2021-02-12 Thread Jason McIntyre
On Fri, Feb 12, 2021 at 03:14:26PM +, Larry Hynes wrote: > hi. i've taken the changes in the first sentence - i agree that the comma placement reads better in your version. i'm working my way through your diffs just now, but to be honest most of these changes (like the rest in this diff)

Re: video(4) multiple opens

2021-02-12 Thread Jeremie Courreges-Anglas
On Wed, Feb 10 2021, Martin Pieuchot wrote: [...] > Which fields is the new lock protecting? Why isn't the KERNEL_LOCK() > enough? When I mentioned this potential lack of locking to Marcus, I was mistaken. Some of the functions in video.c are called from syscalls that are marked NOLOCK. But

OpenSMTPD docs: smtpd.conf.5

2021-02-12 Thread Larry Hynes
Index: smtpd.conf.5 === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v retrieving revision 1.256 diff -u -p -r1.256 smtpd.conf.5 --- smtpd.conf.527 Jan 2021 14:59:10 - 1.256 +++ smtpd.conf.512 Feb 2021

OpenSMTPD docs: table.5

2021-02-12 Thread Larry Hynes
Index: table.5 === RCS file: /cvs/src/usr.sbin/smtpd/table.5,v retrieving revision 1.11 diff -u -p -r1.11 table.5 --- table.5 11 Aug 2019 13:00:57 - 1.11 +++ table.5 12 Feb 2021 15:29:25 - @@ -52,7 +52,7 @@

OpenSMTPD docs: smtp.1

2021-02-12 Thread Larry Hynes
Note: the command 'smtp -h' only returns usage. Usage exits with '1' (I assume this is to satisfy the default case in switch (ch) in main()), even when called from the correct use of the '-h' flag, which I don't think is correct. Index: smtp.1

OpenSMTPD docs: smtpctl.8

2021-02-12 Thread Larry Hynes
Index: smtpctl.8 === RCS file: /cvs/src/usr.sbin/smtpd/smtpctl.8,v retrieving revision 1.65 diff -u -p -r1.65 smtpctl.8 --- smtpctl.8 14 Sep 2020 09:48:08 - 1.65 +++ smtpctl.8 12 Feb 2021 15:22:58 - @@ -172,8 +172,8

OpenSMTPD docs: makemap.8

2021-02-12 Thread Larry Hynes
Note: DNS is mentioned in this file as a way of accessing maps. Aside from this mention it appears to be undocumented. Index: makemap.8 === RCS file: /cvs/src/usr.sbin/smtpd/makemap.8,v retrieving revision 1.30 diff -u -p -r1.30

OpenSMTPD docs: newaliases.8

2021-02-12 Thread Larry Hynes
Index: newaliases.8 === RCS file: /cvs/src/usr.sbin/smtpd/newaliases.8,v retrieving revision 1.12 diff -u -p -r1.12 newaliases.8 --- newaliases.820 Jul 2018 15:35:33 - 1.12 +++ newaliases.812 Feb 2021

OpenSMTPD docs: mail.maildir.8

2021-02-12 Thread Larry Hynes
Index: mail.maildir.8 === RCS file: /cvs/src/usr.sbin/smtpd/mail.maildir.8,v retrieving revision 1.5 diff -u -p -r1.5 mail.maildir.8 --- mail.maildir.8 30 May 2018 12:37:57 - 1.5 +++ mail.maildir.8 12 Feb 2021

OpenSMTPD docs: forward.5

2021-02-12 Thread Larry Hynes
Index: forward.5 === RCS file: /cvs/src/usr.sbin/smtpd/forward.5,v retrieving revision 1.9 diff -u -p -r1.9 forward.5 --- forward.5 13 Mar 2015 22:41:54 - 1.9 +++ forward.5 12 Feb 2021 15:14:44 - @@ -49,10 +49,10 @@

OpenSMTPD docs: aliases.5

2021-02-12 Thread Larry Hynes
Index: aliases.5 === RCS file: /cvs/src/usr.sbin/smtpd/aliases.5,v retrieving revision 1.16 diff -u -p -r1.16 aliases.5 --- aliases.5 23 Apr 2020 21:28:10 - 1.16 +++ aliases.5 12 Feb 2021 15:12:41 - @@ -25,19 +25,18

Re: random manual pages

2021-02-12 Thread Theo de Raadt
Nelson H. F. Beebe wrote: > Thanks for the comments, Theo. > > I wasn't clear in my posting about distinguishing deterministic from > nondeterministic generators. The former are required for reproducible > simulations Perhaps. Even then they often criminally abused, ie. Neil Ferguson --

Re: random manual pages

2021-02-12 Thread Nelson H. F. Beebe
Thanks for the comments, Theo. I wasn't clear in my posting about distinguishing deterministic from nondeterministic generators. The former are required for reproducible simulations; the latter are needed for things like cryptographic key generation. Both have their place, and both are

Re: random manual pages

2021-02-12 Thread Theo de Raadt
Hi Nelson - Nelson H. F. Beebe wrote: > Thanks, Theo, for this good advice about random-number generators: In this discussion, I made no comments about "random-number generators". Instead I commented on "deterministic generators", which have been incorrectly placed inside subsystems claiming

Re: random manual pages

2021-02-12 Thread Nelson H. F. Beebe
Thanks, Theo, for this good advice about random-number generators: >> - if you need determinism, write your own. >> - do not rely upon an external function which will make your seed >> produce a different result approximately every 8 years. I would add more points: * You MUST

Re: malloc junking tweaks

2021-02-12 Thread Otto Moerbeek
On Fri, Feb 12, 2021 at 02:18:08PM +0100, Otto Moerbeek wrote: > Hi, > > Curently, junking is done like this: > > - for small chunk, the whole chunk junked on free > > - for pages sized and larger, the first half a page is filled > > - after a delayed free, the first 32 bytes of small chunks

malloc junking tweaks

2021-02-12 Thread Otto Moerbeek
Hi, Curently, junking is done like this: - for small chunk, the whole chunk junked on free - for pages sized and larger, the first half a page is filled - after a delayed free, the first 32 bytes of small chunks are validated to not be overwritten - page sized and larger allocations are not

Re: Possible null deref on pf.c

2021-02-12 Thread Claudio Jeker
On Fri, Feb 12, 2021 at 01:20:01PM +0100, Alexander Bluhm wrote: > On Fri, Feb 12, 2021 at 01:11:24PM +0100, Claudio Jeker wrote: > > On Fri, Feb 12, 2021 at 12:03:49PM +, Ricardo Mestre wrote: > > > This was reported on CID 1501718, ifp starts as NULL and then might be > > > deref'ed. > >

Re: Possible null deref on pf.c

2021-02-12 Thread Alexander Bluhm
On Fri, Feb 12, 2021 at 01:11:24PM +0100, Claudio Jeker wrote: > On Fri, Feb 12, 2021 at 12:03:49PM +, Ricardo Mestre wrote: > > This was reported on CID 1501718, ifp starts as NULL and then might be > > deref'ed. > This code is strange, the scope for the IPv6 address needs to be pulled >

Re: Possible null deref on pf.c

2021-02-12 Thread Claudio Jeker
On Fri, Feb 12, 2021 at 12:03:49PM +, Ricardo Mestre wrote: > Hi, > > This was reported on CID 1501718, ifp starts as NULL and then might be > deref'ed. > > The question is does the below make any sense to solve it since I don't know > what I'm doing? :) > > What do you net gurus say? >

Possible null deref on pf.c

2021-02-12 Thread Ricardo Mestre
Hi, This was reported on CID 1501718, ifp starts as NULL and then might be deref'ed. The question is does the below make any sense to solve it since I don't know what I'm doing? :) What do you net gurus say? Index: pf.c === RCS

Re: uhidpp(4): logitech hid++ device driver

2021-02-12 Thread Anindya Mukherjee
Hi, Sorry for the delay. I am running the latest snapshot: kern.version=OpenBSD 6.9-beta (GENERIC.MP) #331: Thu Feb 11 20:28:45 MST 2021 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP which seems to have the latest updates. However I still do not see battery levels for

Re: snmpd: Add end of sequence tests

2021-02-12 Thread Martijn van Duren
On Fri, 2021-02-12 at 11:02 +0100, Claudio Jeker wrote: > On Fri, Feb 12, 2021 at 10:03:21AM +0100, Martijn van Duren wrote: > > ping > > > > On Sun, 2021-01-31 at 11:57 +0100, Martijn van Duren wrote: > > > Now that ober_scanf_elements supports '$' lets use it. > > > > > > Here's a first stab

Re: snmpd: Add end of sequence tests

2021-02-12 Thread Claudio Jeker
On Fri, Feb 12, 2021 at 10:03:21AM +0100, Martijn van Duren wrote: > ping > > On Sun, 2021-01-31 at 11:57 +0100, Martijn van Duren wrote: > > Now that ober_scanf_elements supports '$' lets use it. > > > > Here's a first stab by adding it to snmpd. > > Passing regress and a few manual checks. > >

Re: snmpd: Add end of sequence tests

2021-02-12 Thread Martijn van Duren
ping On Sun, 2021-01-31 at 11:57 +0100, Martijn van Duren wrote: > Now that ober_scanf_elements supports '$' lets use it. > > Here's a first stab by adding it to snmpd. > Passing regress and a few manual checks. > > 'e' still doesn't consume the element, but I've talked it over with > rob@, who

Re: change rpki-client repository code

2021-02-12 Thread Claudio Jeker
On Mon, Feb 08, 2021 at 05:15:40PM +0100, Claudio Jeker wrote: > Split the repository code into two parts: > > - fetch of the trust anchors (the certs referenced by TAL files) > - fetch of the MFT files of a repository > > While the two things kind of look similar there are some differences. >