Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Janne Johansson
Den tis 23 feb. 2021 kl 08:48 skrev Theo de Raadt : > > > > > > No problem, real-life often takes precedence. > > > > > > > > > > No way! operator(7) would need an update! > > > > > > > > What do we do when we see a bug? We fix it! What if it is not fixable? > > > > We document it! > > > > > >

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Theo de Raadt
Bryan Steele wrote: > On Tue, Feb 23, 2021 at 06:23:22PM +1100, Jonathan Gray wrote: > > On Tue, Feb 23, 2021 at 08:10:54AM +0100, Otto Moerbeek wrote: > > > On Mon, Feb 22, 2021 at 08:58:07PM -, Miod Vallat wrote: > > > > > > > > > > > > No problem, real-life often takes precedence. > > >

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Otto Moerbeek
On Tue, Feb 23, 2021 at 06:23:22PM +1100, Jonathan Gray wrote: > On Tue, Feb 23, 2021 at 08:10:54AM +0100, Otto Moerbeek wrote: > > On Mon, Feb 22, 2021 at 08:58:07PM -, Miod Vallat wrote: > > > > > > > > > No problem, real-life often takes precedence. > > > > > > No way! operator(7) would

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Bryan Steele
On Tue, Feb 23, 2021 at 06:23:22PM +1100, Jonathan Gray wrote: > On Tue, Feb 23, 2021 at 08:10:54AM +0100, Otto Moerbeek wrote: > > On Mon, Feb 22, 2021 at 08:58:07PM -, Miod Vallat wrote: > > > > > > > > > No problem, real-life often takes precedence. > > > > > > No way! operator(7) would

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Jonathan Gray
On Tue, Feb 23, 2021 at 08:10:54AM +0100, Otto Moerbeek wrote: > On Mon, Feb 22, 2021 at 08:58:07PM -, Miod Vallat wrote: > > > > > > No problem, real-life often takes precedence. > > > > No way! operator(7) would need an update! > > > > What do we do when we see a bug? We fix it! What if

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Otto Moerbeek
On Mon, Feb 22, 2021 at 08:58:07PM -, Miod Vallat wrote: > > > No problem, real-life often takes precedence. > > No way! operator(7) would need an update! > What do we do when we see a bug? We fix it! What if it is not fixable? We document it! -Otto Index: operator.7

Re: /bin/cp: overwrite symlink with file pointed to by symlink

2021-02-22 Thread Quentin Rameau
> Hi Quentin, Hi Cristopher, > Thank you for having a look. You're welcome! > I know I'm very late, but I still like your patch. So ok chrisz@ if you > want to commit it. It didn't raise much passion at the time, we can just hope it gets a bit more attention now!

Re: uvm_fault_lower refactoring

2021-02-22 Thread Mark Kettenis
> Date: Mon, 22 Feb 2021 10:10:21 +0100 > From: Martin Pieuchot > > On 16/02/21(Tue) 11:20, Martin Pieuchot wrote: > > Start by moving `pgo_fault' handler outside of uvm_fault_lower(). > > > > If a page has a backing object that prefer to handler to fault itself > > the locking will be

Re: hppa: terminate backtrace of secondary processors

2021-02-22 Thread Mark Kettenis
> Date: Sun, 7 Feb 2021 15:42:27 + > From: Miod Vallat > > When asking for the backtrace of a secondary processor in ddb, if that > backtrace reaches the secondary cpu startup code before the > switch_trampoline call, it will trust uninitialized stack data and is > likely to panic with an

Re: ober_get_string.3: s/byte/character

2021-02-22 Thread Jason McIntyre
On Mon, Feb 22, 2021 at 11:12:32PM +0100, Martijn van Duren wrote: > As pointed out by claudio@, it makes more sense to talk about characters > for fmt instead of bytes. > > The .Bl line already was >80 columns, but I don't know how to remedy > this situation, so this diff makes that a little

quiz: Fix multi-line questions (trailing newline)

2021-02-22 Thread Alex Karle
Hi all, I was thrilled to find that the quiz for ed(1) commands, `function ed-command` (as referenced in The UNIX Programming Enviroment), existed in OpenBSD, but found that there was a bug where ~half of my correct answers were not accepted. Looking deeper, there is a bug in quiz(6) for

ober_get_string.3: s/byte/character

2021-02-22 Thread Martijn van Duren
As pointed out by claudio@, it makes more sense to talk about characters for fmt instead of bytes. The .Bl line already was >80 columns, but I don't know how to remedy this situation, so this diff makes that a little worse. martijn@ Index: ober_get_string.3

Re: mbuf leak ip_insertoptions

2021-02-22 Thread Vitaliy Makkoveev
ok mvs@ > On 22 Feb 2021, at 18:51, Alexander Bluhm wrote: > > Hi, > > ip_insertoptions() may prepend a mbuf. In this case "goto bad" has > to free the new chain. Currently we leak the new mbuf in front of > the old chain. NetBSD has fixed this bug here: > > >

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Miod Vallat
> No problem, real-life often takes precedence. No way! operator(7) would need an update!

Re: XBox One gamecontroller support

2021-02-22 Thread Thomas Frohwein
On Fri, Jan 15, 2021 at 06:32:04AM -0700, Thomas Frohwein wrote: > On Sat, Jan 09, 2021 at 10:50:35AM -0700, Thomas Frohwein wrote: > > Hi, > > > > This diff adds support for the XBox One gamecontroller in a similar way > > to what we have for the (older) XBox 360 controller [1][2]. This diff > >

sdmmc(4): check and retry bus width change

2021-02-22 Thread Patrick Wildt
Hi, it seems like some eMMCs are not capable of doing 8-bit operation, even if the controller supports it. I was questioning our drivers first, but it looks like it's the same on Linux. In the case that 8-bit doesn't work, they seem to fall back to lower values to make that HW work. This diff

Re: uvm_fault_lower refactoring

2021-02-22 Thread Chris Cappuccio
Martin Pieuchot [m...@openbsd.org] wrote: > On 16/02/21(Tue) 11:20, Martin Pieuchot wrote: > > Start by moving `pgo_fault' handler outside of uvm_fault_lower(). > > > > If a page has a backing object that prefer to handler to fault itself > > the locking will be different, so keep it under

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Paul Irofti
On 22.02.2021 15:56, Otto Moerbeek wrote: On Mon, Feb 22, 2021 at 11:09:41AM +0200, Paul Irofti wrote: - investigate the commit you mention above. Sadly I cannot remember the original case that prompted for the caching code to be added. Sorry I could not reply

Re: mbuf leak ip_insertoptions

2021-02-22 Thread Klemens Nanni
On Mon, Feb 22, 2021 at 04:51:09PM +0100, Alexander Bluhm wrote: > Free m instead of m0 in the bad case. This allows to simplify a > bunch of goto done. OK kn

mbuf leak ip_insertoptions

2021-02-22 Thread Alexander Bluhm
Hi, ip_insertoptions() may prepend a mbuf. In this case "goto bad" has to free the new chain. Currently we leak the new mbuf in front of the old chain. NetBSD has fixed this bug here: revision 1.33 date: 1996-10-11 18:19:08 +; author: is; state: Exp; lines:

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Otto Moerbeek
On Mon, Feb 22, 2021 at 11:09:41AM +0200, Paul Irofti wrote: > > - investigate the commit you mention above. Sadly I cannot > >remember the original case that prompted for the caching code to > > be > >added. > > Sorry I could not reply earlier. No problem,

Re: veb(4), a virtual ethernet bridge (that could replace bridge(4)?)

2021-02-22 Thread David Gwynne
> On 22 Feb 2021, at 12:46 am, Vitaliy Makkoveev wrote: > > Hello. > > >> +ifp->if_ioctl = veb_ioctl; >> +ifp->if_input = veb_input; >> +//ifp->if_rtrequest = veb_rtrequest; >> +ifp->if_output = veb_output; >> +ifp->if_enqueue = veb_enqueue; > > Could you replace c++

uvm_fault: uvm_fault_lower_lookup() refactoring

2021-02-22 Thread Martin Pieuchot
Similar refactoring to what has been done for the upper part of the fault handler, ok? Index: uvm/uvm_fault.c === RCS file: /cvs/src/sys/uvm/uvm_fault.c,v retrieving revision 1.115 diff -u -p -r1.115 uvm_fault.c --- uvm/uvm_fault.c

Re: uvm_fault_lower refactoring

2021-02-22 Thread Martin Pieuchot
On 16/02/21(Tue) 11:20, Martin Pieuchot wrote: > Start by moving `pgo_fault' handler outside of uvm_fault_lower(). > > If a page has a backing object that prefer to handler to fault itself > the locking will be different, so keep it under KERNEL_LOCK() for the > moment and make it separate from

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Paul Irofti
- investigate the commit you mention above. Sadly I cannot remember the original case that prompted for the caching code to be added. Sorry I could not reply earlier. The caching code was added by me to make libreoffice work with non-toy spreadsheets. Apparently