Re: diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread YASUOKA Masahiko
On Wed, 10 Mar 2021 13:15:58 +0100 (CET) Mark Kettenis wrote: >> On Wed, 10 Mar 2021 20:35:41 +0900 (JST) >> YASUOKA Masahiko wrote: >> > efiboot cannot load the kernel properly on some machines if booted >> > from CD-ROM. In that case boot fails with a message like follow: >> > >> >

Re: net80211: new Tx rate adaptation module (iwn + iwm)

2021-03-10 Thread Aaron Miller
On Tue, 2021-03-09 at 14:48 +0100, Stefan Sperling wrote: > This implements a new rate adaptation module for net80211, called > "RA", > which resulted from a long discussion and exchanges of various > diffs > between Christian Ehrhardt and myself, targeting problems with > MiRA. > > Tests with

Re: quiz: Fix multi-line questions (trailing newline)

2021-03-10 Thread Todd C . Miller
On Wed, 10 Mar 2021 22:49:13 -0500, Alex Karle wrote: > > This would now be clearer as: > > > > if (qlen > 0 && qp->q_text[qlen - 1] == '\\') { > > I agree this is clearer, but I think we'll need a `qlen = 0` > initialization up above the while loop if we go with this

Re: quiz: Fix multi-line questions (trailing newline)

2021-03-10 Thread Alex Karle
On Wed, Mar 10, 2021 at 02:03:33PM -0700, Todd C. Miller wrote: > On Wed, 10 Mar 2021 21:15:13 +0100, Christian Weisgerber wrote: > > > Right. Next iteration: > > Looks better, one minor nit inline. > > - todd My ok doesn't weigh much, but I wanted to chime in to say thanks for picking this

Re: ifconfig.8: document veb(4)

2021-03-10 Thread David Gwynne
> On 10 Mar 2021, at 23:07, Klemens Nanni wrote: > > On Tue, Mar 09, 2021 at 08:48:14PM +0100, Klemens Nanni wrote: >> Simple addition of VEB right before BRIDGE. > New diff sorting the section alphabetically between UMB and VLAN, > thanks jmc. > >> All text is copied from other already

Re: Remove extra pointer to gzFile in grep(1)

2021-03-10 Thread Todd C . Miller
On Wed, 10 Mar 2021 16:46:32 -0500, Josh Rickmar wrote: > The compress(3) family of utility functions return and operate on > gzFile, a typedef for void*. The extra pointer to this gzFile in > grep(1) can be removed. Other uses of these compress(3) functions in > tree (spamd, mandoc, smtpd) do

Remove extra pointer to gzFile in grep(1)

2021-03-10 Thread Josh Rickmar
The compress(3) family of utility functions return and operate on gzFile, a typedef for void*. The extra pointer to this gzFile in grep(1) can be removed. Other uses of these compress(3) functions in tree (spamd, mandoc, smtpd) do not use the extra pointer. diff

unlock sys_sendsyslog

2021-03-10 Thread Vitaliy Makkoveev
Since UNIX domain sockets are unlocked it makes sense to unlock sys_sendsyslog too. Console output still requires kernel lock to be held but this path is only followed while `syslogf' socket is not set. New `syslogf_rwlock' used to protect `syslogf' access. ok? Index: sys/kern/subr_log.c

Re: quiz: Fix multi-line questions (trailing newline)

2021-03-10 Thread Todd C . Miller
On Wed, 10 Mar 2021 21:15:13 +0100, Christian Weisgerber wrote: > Right. Next iteration: Looks better, one minor nit inline. - todd > Index: quiz.c > === > RCS file: /cvs/src/games/quiz/quiz.c,v > retrieving revision 1.30 > diff

Re: quiz: Fix multi-line questions (trailing newline)

2021-03-10 Thread Christian Weisgerber
Todd C. Miller: > I don't think your use of qlen is safe since it is initialized > to zero. Specifically, it looks like "qp->q_text[qlen - 1]" > would be an out of bounds read. Should qlen be initialized > to strlen(qp->q_text) if qp->q_text != NULL? Right. Next iteration: Index: quiz.c

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-10 Thread Theo Buehler
On Wed, Mar 10, 2021 at 01:10:55PM -0700, Todd C. Miller wrote: > Now the the clear screen change has been committed, here's the > insert mode ^R (redraw) diff again with a man page update. Note > that ^R is already supported in command mode. > ok

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-10 Thread Todd C . Miller
Now the the clear screen change has been committed, here's the insert mode ^R (redraw) diff again with a man page update. Note that ^R is already supported in command mode. OK? - todd Index: bin/ksh/ksh.1 === RCS file:

Re: libcurses: don't return ERR if resize didn't change size

2021-03-10 Thread Theo Buehler
On Thu, Jan 21, 2021 at 11:06:05AM -0700, Todd C. Miller wrote: > This is a backport of the ncurses 5.9 20120707 patch. > https://github.com/mirror/ncurses/commit/471bc007361fd4bc8d2fae060c7d5b09828ed541 ok tb

Re: vmm crash on 6.9-beta

2021-03-10 Thread Mischa
On 10 Mar at 18:59, Mike Larkin wrote: > On Wed, Mar 10, 2021 at 03:08:21PM +0100, Mischa wrote: > > Hi All, > > > > Currently I am running 6.9-beta on one of my hosts to test veb(4)/vport(4). > > > > root@server14:~ # sysctl kern.version > > kern.version=OpenBSD 6.9-beta (GENERIC.MP) #385: Mon

Re: net80211: new Tx rate adaptation module (iwn + iwm)

2021-03-10 Thread Matthias Schmidt
Hi Stefan, * Stefan Sperling wrote: > This implements a new rate adaptation module for net80211, called "RA", > which resulted from a long discussion and exchanges of various diffs > between Christian Ehrhardt and myself, targeting problems with MiRA. > > Tests with any of the various iwn(4) and

Re: vmm crash on 6.9-beta

2021-03-10 Thread Mike Larkin
On Wed, Mar 10, 2021 at 03:08:21PM +0100, Mischa wrote: > Hi All, > > Currently I am running 6.9-beta on one of my hosts to test veb(4)/vport(4). > > root@server14:~ # sysctl kern.version > kern.version=OpenBSD 6.9-beta (GENERIC.MP) #385: Mon Mar 8 12:57:12 MST 2021 >

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-10 Thread Theo Buehler
On Tue, Mar 09, 2021 at 10:03:56AM -0700, Todd C. Miller wrote: > I think that in do_clear_screen() full should not be set unless > neednl is 0. That is, we should only print the entire prompt if > the screen was actually cleared. Otherwise looks good to me. ok tb

Re: rpki-client per repo entity queue

2021-03-10 Thread Theo Buehler
On Wed, Mar 10, 2021 at 10:12:51AM +0100, Claudio Jeker wrote: > The entity queue is per repository. It is a queue of files that depend on > this repository and need to wait until the repository finished its sync. > There is no benefit of a global queue. > > In my opinion this is more

vmm crash on 6.9-beta

2021-03-10 Thread Mischa
Hi All, Currently I am running 6.9-beta on one of my hosts to test veb(4)/vport(4). root@server14:~ # sysctl kern.version kern.version=OpenBSD 6.9-beta (GENERIC.MP) #385: Mon Mar 8 12:57:12 MST 2021 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP On order to add some

Re: ifconfig.8: document veb(4)

2021-03-10 Thread Klemens Nanni
On Tue, Mar 09, 2021 at 08:48:14PM +0100, Klemens Nanni wrote: > Simple addition of VEB right before BRIDGE. New diff sorting the section alphabetically between UMB and VLAN, thanks jmc. > All text is copied from other already existing sections, i.e. link flag > handling from TPMR and the rest

Re: diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread Mark Kettenis
> Date: Wed, 10 Mar 2021 20:42:42 +0900 (JST) > From: YASUOKA Masahiko > > Sorry for making noise, let me update the diff. > > > + if (ed->blkio->Media->IoAlign > 1 && > > + ((UINTN)buf + i_lblks * DEV_BSIZE) > > + %

Re: diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread YASUOKA Masahiko
Sorry for making noise, let me update the diff. > + if (ed->blkio->Media->IoAlign > 1 && > + ((UINTN)buf + i_lblks * DEV_BSIZE) > + % ed->blkio->Media->IoAlign == 0) first condition was reversed.. On Wed, 10 Mar 2021 20:35:41

diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread YASUOKA Masahiko
Hi, efiboot cannot load the kernel properly on some machines if booted from CD-ROM. In that case boot fails with a message like follow: booting cd0a:. [359648read symbols: Unknown error: code 255 As far as Asou and my test, this happens on hosts on VMware ESXi 6.7, 7.0 and asou's

rpki-client per repo entity queue

2021-03-10 Thread Claudio Jeker
The entity queue is per repository. It is a queue of files that depend on this repository and need to wait until the repository finished its sync. There is no benefit of a global queue. In my opinion this is more understandable. -- :wq Claudio Index: main.c