Re: wsmouse(4): release wstpad resources

2021-03-20 Thread Greg Steuck
Ulf Brosziewski writes: > wsmouse(4) doesn't free the memory allocated for the wstpad state > when an external touchpad is being unplugged. This patch fixes > the leak. > > OK? OK gnezdo

Re: vmm crash on 6.9-beta

2021-03-20 Thread Theo de Raadt
Otto Moerbeek wrote: > On Fri, Mar 19, 2021 at 04:15:31PM +, Stuart Henderson wrote: > > > On 2021/03/19 17:05, Jan Klemkow wrote: > > > Hi, > > > > > > I had the same issue a few days ago a server hardware of mine. I just > > > ran 'cvs up'. So, it looks like a generic bug in FFS and

Re: apm, apmd: ship manual pages on powerpc64

2021-03-20 Thread Theo de Raadt
There is a pattern we've followed in the past, that when a manpage applies to more than 2 (or 3?) architectures, then we simply make it MI. So MANSUBDIR would get deleted, and then the sets would be updated. People with old systems will retain the old files, but I think man(1) selects the MI

arm64: make cwfg(4) report battery information to apm(4)

2021-03-20 Thread Klemens Nanni
apm(4/arm64) merely provides an all zero/unknown stub for those values, e.g. apm(8) output is useless. Hardware sensors however provide the information: $ sysctl hw.sensors hw.sensors.rktemp0.temp0=32.22 degC (CPU) hw.sensors.rktemp0.temp1=33.89 degC (GPU)

wsmouse(4): release wstpad resources

2021-03-20 Thread Ulf Brosziewski
wsmouse(4) doesn't free the memory allocated for the wstpad state when an external touchpad is being unplugged. This patch fixes the leak. OK? Index: wsmouse.c === RCS file: /cvs/src/sys/dev/wscons/wsmouse.c,v retrieving revision

Re: patch: ifq_enqueue.9 ifq_deq_begin.9 typo

2021-03-20 Thread Stuart Henderson
On 2021/03/20 16:07, James Hastings wrote: > Spotted this one while reading ifq_enqueue(9). s/struft/struct. > > I grepped the tree for "struft" and found one more in ifq_deq_begin(9). thanks, committed.

apm, apmd: ship manual pages on powerpc64

2021-03-20 Thread Klemens Nanni
It looks like an oversight when those were hooked up, but I don't have access to that platform to test myself. Feedback? OK? Index: usr.sbin/apm/Makefile === RCS file: /cvs/src/usr.sbin/apm/Makefile,v retrieving revision 1.19 diff

Re: iscsid/iscsictl: Introduce poll-and-wait delay during reload

2021-03-20 Thread Ashton Fagg
Hello. Pinging on this one hoping to get some feedback. I've reattached the diff below. Thanks. Ashton Fagg writes: > Hello tech, > > Recently I encountered a problem with automounting iscsi volumes at boot > time. This came down to a timing issue, where iscsictl reload was > returning

patch: ifq_enqueue.9 ifq_deq_begin.9 typo

2021-03-20 Thread James Hastings
Spotted this one while reading ifq_enqueue(9). s/struft/struct. I grepped the tree for "struft" and found one more in ifq_deq_begin(9). Index: share/man/man9/ifq_deq_begin.9 === RCS file: /cvs/src/share/man/man9/ifq_deq_begin.9,v

ftp -6 -> Reading from socket: Connection reset by peer

2021-03-20 Thread Greg Steuck
This goes part way through (as can be seen with -m) and then fails: % ftp -6 -M http://cdn.openbsd.org/pub/OpenBSD//snapshots/amd64/base69.tgz Trying 2a04:4e42:2d::729... Requesting http://cdn.openbsd.org/pub/OpenBSD//snapshots/amd64/base69.tgz ftp: Reading from socket: Connection reset by peer

apm/macppc: Mark unsupported ioctl as such, merge cases

2021-03-20 Thread Klemens Nanni
APM_IOC_DEV_CTL is unsupport just like apm(4/macppc) says but `errno' is not set appropiately. Merge identical cases while here; this syncs with loongson and arm64 and aids comparing the platforms. Tested on a PowerBook G4 (along with the "apmd: log ioctl failure" diff). OK? Index: apm.c

apm/arm64: fix errno, merge ioctl cases

2021-03-20 Thread Klemens Nanni
The EBADF error is always overwritten for the standby, suspend and hibernate ioctls, only the mode ioctl has it right. Merge the now identical casese while here. Tested on a Pinebook Pro. OK? Index: apm.c === RCS file:

apmd: log ioctl failures

2021-03-20 Thread Klemens Nanni
Otherwise there is no way other than reading driver code to determine why running zzz(8) for example does not do anything on certain machines. apm(4/arm64) for one currently does not implement suspend and resume, i.e. it yields ENOSUPP which gets lost in userland. This still does not make `zzz'

Re: slaacd: SMALL fixes

2021-03-20 Thread Florian Obser
OK florian On Sat, Mar 20, 2021 at 05:38:40PM +0100, Klemens Nanni wrote: > distrib/special/slaacd is the actual user of SMALL but being able to > build it from sbin/slaacd does not harm; in fact, this revealed two > unused (with SMALL) buffers. > > OK? > > Index: control.c >

slaacd: SMALL fixes

2021-03-20 Thread Klemens Nanni
distrib/special/slaacd is the actual user of SMALL but being able to build it from sbin/slaacd does not harm; in fact, this revealed two unused (with SMALL) buffers. OK? Index: control.c === RCS file:

Re: IPv6: allow only temporary global addresses

2021-03-20 Thread Klemens Nanni
On Sat, Mar 20, 2021 at 04:32:31PM +0100, Florian Obser wrote: > anyone? > > On Wed, Mar 17, 2021 at 06:24:58PM +0100, Florian Obser wrote: > > RFC 8981 allows this and it reduces the amount of v6 addresses I have > > on my laptop. > > > > OK? Reads fine and works as advertised with `inet6

Re: IPv6: allow only temporary global addresses

2021-03-20 Thread Florian Obser
anyone? On Wed, Mar 17, 2021 at 06:24:58PM +0100, Florian Obser wrote: > RFC 8981 allows this and it reduces the amount of v6 addresses I have > on my laptop. > > OK? > diff --git sbin/ifconfig/ifconfig.c sbin/ifconfig/ifconfig.c index 2c60e652675..527e6e02d1f 100644 ---

Re: veb(4) support for vmd(8)?

2021-03-20 Thread srfsh
David Gwynne wrote: > i think this is enough to let vmd wire guests up to veb interfaces. > > please remember that veb is not the same as bridge, so some care > has to be taken when replacing bridge with veb. the biggest difference > to note is that if you want the host to talk layer 3 (ie, ip,

OPENBSD-PF-MIB, use DisplayString not OCTET STRING

2021-03-20 Thread Stuart Henderson
DisplayString seems a better type for pfIfDescr and some of the other objects; this improves the display format in Prometheus snmp_exporter which uses hex values for OCTET STRING. OK? Index: OPENBSD-PF-MIB.txt === RCS file:

Stop/unstop process & xsig

2021-03-20 Thread Martin Pieuchot
Diff below refactors routines to stop/unstop processes and save the signal number which will/can be transmitted it in wait4(2). It does the following: - Move the "hack" involving P_SINTR to avoid grabbing the SCHED_LOCK() recursively inside proc_stop(). - Introduce proc_unstop(), the

kern_sig.c: use uppercase for defines

2021-03-20 Thread Martin Pieuchot
ok? Index: kern/kern_sig.c === RCS file: /cvs/src/sys/kern/kern_sig.c,v retrieving revision 1.278 diff -u -p -r1.278 kern_sig.c --- kern/kern_sig.c 12 Mar 2021 10:13:28 - 1.278 +++ kern/kern_sig.c 20 Mar 2021

fork(2), PT_ATTACH & SIGTRAP

2021-03-20 Thread Martin Pieuchot
On SP systems, like bluhm@'s armv7 regression machine, the kern/ptrace2 test is failing due to a subtle behavior. Diff below makes it pass. http://bluhm.genua.de/regress/results/2021-03-19T15%3A17%3A02Z/logs/sys/kern/ptrace2/make.log The failing test does a fork(2) and the parent issues a

Re: ifconfig.8: document veb(4)

2021-03-20 Thread Klemens Nanni
On Fri, Mar 19, 2021 at 09:04:39PM -0700, Nick Owens wrote: > ping. i set up veb recently with much success, but was disappointed by > the lack of documentation in ifconfig. This has been committed. Diffs for more (precise) documentation are always welcome.

Re: vmm crash on 6.9-beta

2021-03-20 Thread Otto Moerbeek
On Fri, Mar 19, 2021 at 04:15:31PM +, Stuart Henderson wrote: > On 2021/03/19 17:05, Jan Klemkow wrote: > > Hi, > > > > I had the same issue a few days ago a server hardware of mine. I just > > ran 'cvs up'. So, it looks like a generic bug in FFS and not related to > > vmm. > > This panic

Re: btrace: add dry run mode

2021-03-20 Thread Klemens Nanni
On Sat, Mar 20, 2021 at 02:44:50PM +1000, Jonathan Matthew wrote: > Fair enough. I started with -d because that's what bpftrace has, but > changing to -n for consistency makes sense to me. Thank you. OK kn

Re: Mention vmd FFS boot support removal in current.html

2021-03-20 Thread Raf Czlonka
Hi Josh, Just a quick note regarding - it is used only once in there - being the dominant tag. BTW is only about consistency, not about one vs the other. Cheers, Raf On Fri, Mar 19, 2021 at 08:08:26PM GMT, Josh Rickmar wrote: > On Fri, Mar 19, 2021 at 03:26:46PM -0400, Josh Rickmar wrote: >

patch: constify and use C99-style initialization for struct execsw

2021-03-20 Thread Sebastien Marie
Hi, The following diff makes `struct execsw' to: - use C99-style initialization (grep works better with that) - use const as execsw is not modified during runtime Comments or OK ? -- Sebastien Marie diff 2533c50dc3c36fe283749b7fcaef52891806c13c /home/semarie/repos/openbsd/src blob -