Re: iwm(4) A-MSDU support

2021-03-29 Thread Brian Callahan
Hi Stefan -- > Stefan Sperling writes: > > > This patch attempts to add support for receiving A-MSDUs to iwm(4). > > > > If you are using iwm(4) then please run with this patch and let me > > > > know if it causes regressions. Thanks! > All is good on my machine as well. iwm0 at pci4 dev 0

Mention -N to shutdown(2) network socket after EOF in man nc(1)

2021-03-29 Thread Robert Scheck
Jakub Jelen reported at Fedora that "nc -l 8080" (terminal #1) and "echo XXX | nc localhost 8080" (terminal #2) keeps hanging both client and server after reading the EOF, even the last sentence of "CLIENT/SERVER MODEL" in the man page of nc(1) says "The connection may be terminated using an EOF

Re: iwm(4) A-MSDU support

2021-03-29 Thread Tracey Emery
On Mon, Mar 29, 2021 at 09:27:31PM +, Brian Callahan wrote: > Hi Stefan -- > > > Stefan Sperling writes: > > > > > This patch attempts to add support for receiving A-MSDUs to iwm(4). > > > > > > If you are using iwm(4) then please run with this patch and let me > > > > > > know if it causes

Re: disable PPP_BSDCOMP by default

2021-03-29 Thread Balder Oddson
On Thu, Mar 25, 2021 at 12:46:24PM -0600, Theo de Raadt wrote: > No way for this diff. This is the wrong way. Surely there are ways > to disable compression negotion on specific sessions, but removing > the code from the kernel is the wrong knob. So whom do I explain for feedbeef OK? You can

Re: vmd(8): fix packet handling for dhcpleased(8)

2021-03-29 Thread Dave Voutila
Dave Voutila writes: > Dave Voutila writes: > >> tech@, >> >> While migrating an existing -current vm to use dhcpleased(8), one of the >> issues discovered was the dhcp/bootp handling built into vmd(8) for >> local interfaces was improperly missing packets sent to the ethernet >> address of the

no ptys on ramdisk filesystems

2021-03-29 Thread Miod Vallat
A few platforms create pty nodes in /dev in the installation media filesystem. That wastes 2x62 inodes on an tight filesystem. The following diff removes these useless (since installation media kernels lack the pty pseudo-device) /dev entries. Miod PS: while there, one might want to unify the

Re: iwm(4) A-MSDU support

2021-03-29 Thread Dave Voutila
Stefan Sperling writes: > This patch attempts to add support for receiving A-MSDUs to iwm(4). > If you are using iwm(4) then please run with this patch and let me > know if it causes regressions. Thanks! Been running your diff on a workstation the past 2 hours with no noticeable regressions.

Re: iwm(4) A-MSDU support

2021-03-29 Thread Marcus MERIGHI
Hello! s...@stsp.name (Stefan Sperling), 2021.03.29 (Mon) 19:27 (CEST): > This patch attempts to add support for receiving A-MSDUs to iwm(4). > If you are using iwm(4) then please run with this patch and let me > know if it causes regressions. Thanks! no regressions with: iwm0 at pci2 dev 0

Re: vmctl: off-by-one error handling mixing -a with a VM id

2021-03-29 Thread Mike Larkin
On Fri, Mar 26, 2021 at 07:24:32AM -0400, Dave Voutila wrote: > > Theo Buehler writes: > > > On Thu, Mar 25, 2021 at 08:07:53PM +0100, Preben Guldberg wrote: > >> Dave Voutila wrote: > >> > Preben Guldberg writes: > >> > > The patch below addresses an off-by-one error reading argv when > >> > >

iwm(4) A-MSDU support

2021-03-29 Thread Stefan Sperling
This patch attempts to add support for receiving A-MSDUs to iwm(4). If you are using iwm(4) then please run with this patch and let me know if it causes regressions. Thanks! ACHTUNG: This patch breaks iwx(4)! Don't use it there! For this reason, the patch can neither be committed nor be put into

Re: Huawei ME906s-158 LTE, cdce(4) vs umb(4)

2021-03-29 Thread Gerhard Roth
On 3/28/21 3:16 PM, Stuart Henderson wrote: On 2021/03/28 13:40, Patrick Wildt wrote: Am Sun, Mar 28, 2021 at 10:53:53AM +0100 schrieb Stuart Henderson: On 2021/03/25 00:14, Stuart Henderson wrote: On 2021/03/25 00:30, Patrick Wildt wrote: Without having looked at anything, it might be worth

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Alexandr Nedvedicky
Hello, On Mon, Mar 29, 2021 at 11:56:40AM +, Schreilechner, Dominik wrote: > > > > > I think the changes in ip_insertoptions() can be dropped completely, > > > because the if-statement uses ip-ip_hl, which might not be initialized. > > > > yes, you are right, I think we should rather go

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Schreilechner, Dominik
> > I think the changes in ip_insertoptions() can be dropped completely, > > because the if-statement uses ip-ip_hl, which might not be initialized. > > yes, you are right, I think we should rather go for this tweak: > >

Re: rpki-client replace funky bin to hex loop in x509

2021-03-29 Thread Theo Buehler
On Mon, Mar 29, 2021 at 01:22:20PM +0200, Claudio Jeker wrote: > On Mon, Mar 29, 2021 at 01:19:21PM +0200, Claudio Jeker wrote: > > On Mon, Mar 29, 2021 at 12:42:02PM +0200, Theo Buehler wrote: > > > On Mon, Mar 29, 2021 at 10:38:54AM +0200, Claudio Jeker wrote: > > > > Replace a super strange way

Re: rpki-client replace funky bin to hex loop in x509

2021-03-29 Thread Claudio Jeker
On Mon, Mar 29, 2021 at 01:19:21PM +0200, Claudio Jeker wrote: > On Mon, Mar 29, 2021 at 12:42:02PM +0200, Theo Buehler wrote: > > On Mon, Mar 29, 2021 at 10:38:54AM +0200, Claudio Jeker wrote: > > > Replace a super strange way to translate some binary blob into a hex > > > string. > > > The code

Re: rpki-client replace funky bin to hex loop in x509

2021-03-29 Thread Claudio Jeker
On Mon, Mar 29, 2021 at 12:42:02PM +0200, Theo Buehler wrote: > On Mon, Mar 29, 2021 at 10:38:54AM +0200, Claudio Jeker wrote: > > Replace a super strange way to translate some binary blob into a hex string. > > The code drops the : from the string but this is fine, the : is just > > visual fluff.

Re: rpki-client replace funky bin to hex loop in x509

2021-03-29 Thread Theo Buehler
On Mon, Mar 29, 2021 at 10:38:54AM +0200, Claudio Jeker wrote: > Replace a super strange way to translate some binary blob into a hex string. > The code drops the : from the string but this is fine, the : is just > visual fluff. I used the same function in the not yet finished RRDP > codebase and

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Alexandr Nedvedicky
Hello, On Mon, Mar 29, 2021 at 08:44:26AM +, Schreilechner, Dominik wrote: > Hi, > > > > > yes, you are right. below is updated diff I would like to commit. > > > > > > Appart from that, adding a special task seems the way to go. > > > > I think so too. Alternative way would be to

Re: rge(4): move tx/rx descriptors into their own structs

2021-03-29 Thread Jonathan Matthew
On Thu, Mar 25, 2021 at 05:21:38PM +0800, Kevin Lo wrote: > Hi, > > The diff below moves tx/rx descriptors into their own structs. > This is a first step toward making rge work with multiple queues and > interrupts. > Only one queue is currently used. > > While here, update the RTL8125B

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Alexandr Nedvedicky
Hello, > > @@ -790,6 +795,7 @@ ip_insertoptions(struct mbuf *m, struct mbuf *opt, int > > *phlen) > > memcpy(ip + 1, p->ipopt_list, optlen); > > *phlen = sizeof(struct ip) + optlen; > > ip->ip_len = htons(ntohs(ip->ip_len) + optlen); > > + ip->ip_hl += (optlen >>

UAO_USES_SWHASH()

2021-03-29 Thread Martin Pieuchot
Introduce a new macro, UAO_USES_SWHASH() and use it to reduce the diff with NetBSD. Also change some space into tabs for the same reason. ok? Index: uvm/uvm_aobj.c === RCS file: /cvs/src/sys/uvm/uvm_aobj.c,v retrieving revision

Re: rpki-client replace funky bin to hex loop in x509

2021-03-29 Thread Claudio Jeker
On Mon, Mar 29, 2021 at 10:38:54AM +0200, Claudio Jeker wrote: > Replace a super strange way to translate some binary blob into a hex string. > The code drops the : from the string but this is fine, the : is just > visual fluff. I used the same function in the not yet finished RRDP > codebase and

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Schreilechner, Dominik
Hi, > yes, you are right. below is updated diff I would like to commit. > > > > Appart from that, adding a special task seems the way to go. > > I think so too. Alternative way would be to pass send flags via m_pkthdr > in mbuf, however there is no space. We would have to add a new

rpki-client replace funky bin to hex loop in x509

2021-03-29 Thread Claudio Jeker
Replace a super strange way to translate some binary blob into a hex string. The code drops the : from the string but this is fine, the : is just visual fluff. I used the same function in the not yet finished RRDP codebase and there I don't want the extra ':'. Works for me. -- :wq Claudio

Re: patch: vamm(4) IA32_EPT_VPID_CAP_XO_TRANSLATIONS specified incorrectly.

2021-03-29 Thread Mike Larkin
On Sat, Mar 27, 2021 at 10:15:27AM -0400, Dave Voutila wrote: > > Adam Steen writes: > > > Hi > > > > IA32_EPT_VPID_CAP_XO_TRANSLATIONS is specified incorrectly, see the > > patch below. > > Adam's diff looks correct to me based on reading Intel SDM Vol 3D, > Appendix A.10 (VPID and EPT

Re: vmm(4): fix boot issue for 9front guests

2021-03-29 Thread Mike Larkin
On Sun, Mar 28, 2021 at 09:28:11AM -0400, Bryan Steele wrote: > On Sun, Mar 28, 2021 at 08:38:13AM -0400, Dave Voutila wrote: > > abieber@ found the latest 9front release ends up in a boot loop if > > hosted on an AMD system. I tracked it down to 9front (oddly) trying to > > read the PAT msr prior