Re: POSIX_C_SOURCE 200809L, XOPEN_SOURCE 700 and bsd_locale_fallbacks errors

2021-04-13 Thread Mark Kettenis
> Date: Tue, 13 Apr 2021 19:36:26 +0200 > From: Rafael Sadowski > > Based on my cmake pull-request(1) to fix the cmake build on OpenBSD, the > following question has arisen which is worth analysing? > > "It seems OpenBSD has a strange behavior because macro _POSIX_C_SOURCE is a > standard!

Re: POSIX_C_SOURCE 200809L, XOPEN_SOURCE 700 and bsd_locale_fallbacks errors

2021-04-13 Thread Stuart Henderson
On 2021/04/13 19:36, Rafael Sadowski wrote: > Based on my cmake pull-request(1) to fix the cmake build on OpenBSD, the > following question has arisen which is worth analysing? > > "It seems OpenBSD has a strange behavior because macro _POSIX_C_SOURCE is a > standard! @sizeofvoid What are the

POSIX_C_SOURCE 200809L, XOPEN_SOURCE 700 and bsd_locale_fallbacks errors

2021-04-13 Thread Rafael Sadowski
Based on my cmake pull-request(1) to fix the cmake build on OpenBSD, the following question has arisen which is worth analysing? "It seems OpenBSD has a strange behavior because macro _POSIX_C_SOURCE is a standard! @sizeofvoid What are the errors raised if _POSIX_C_SOURCE or _XOPEN_SOURCE are

vi: apply expandtab to the output of a ! command

2021-04-13 Thread Todd C . Miller
This is consistent with vim's expandtab behavior. >From nvi2 (Craig Leres): https://github.com/lichray/nvi2/commit/7d3f43559026e0927032a105b217850feaefec66 I know most of us don't use expandtab but it is helpful when dealing with a codebase that is space-indented. Since the option originated

Re: vi: don't expandtab when we're in command mode.

2021-04-13 Thread Martijn van Duren
On Tue, 2021-04-13 at 09:02 -0600, Todd C. Miller wrote: > On Tue, 13 Apr 2021 16:56:52 +0200, Martijn van Duren wrote: > > > When adding a TRACE() I see that that case is only called incidentally > > and / works for me as is. However, it still doesn't work when > > in command-mode (e.g. ":%s//

Re: vi: don't expandtab when we're in command mode.

2021-04-13 Thread Todd C . Miller
On Tue, 13 Apr 2021 16:56:52 +0200, Martijn van Duren wrote: > When adding a TRACE() I see that that case is only called incidentally > and / works for me as is. However, it still doesn't work when > in command-mode (e.g. ":%s// /g" still requires ^V escape). > > So either I'm not clear on which

Re: vi: don't expandtab when we're in command mode.

2021-04-13 Thread Martijn van Duren
When adding a TRACE() I see that that case is only called incidentally and / works for me as is. However, it still doesn't work when in command-mode (e.g. ":%s// /g" still requires ^V escape). So either I'm not clear on which case this is trying to solve or it doesn't work as advertised.

vi: don't expandtab when we're in command mode.

2021-04-13 Thread Todd C . Miller
Otherwise you can't search for a tab unless you ^V escape it. >From nvi2: https://github.com/lichray/nvi2/commit/0ef1c824648bcfe9f831a9607cb465b18e313d1d Index: vi/v_txt.c === RCS file: /cvs/src/usr.bin/vi/vi/v_txt.c,v retrieving

Re: rpki-client more http.c cleanup

2021-04-13 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.13 14:14:38 +0200: > This is another minor cleanup. It makes http_done() similar to http_fail() > and by taking all the arguments (which would allow it to be called after > the http connection was removed) and it also no longer alters the http >

Re: missing case in rpki-client rrdp repo merge

2021-04-13 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.13 11:29:57 +0200: > rpki-client applies all delta files to a temporary location. At the same > time files or uri are tracked in a added and deleted set to know which > files to remove from the repo or move into place. > > Now when adding a file

rpki-client more http.c cleanup

2021-04-13 Thread Claudio Jeker
This is another minor cleanup. It makes http_done() similar to http_fail() and by taking all the arguments (which would allow it to be called after the http connection was removed) and it also no longer alters the http state. At the same time move some common code between http_connect() and

missing case in rpki-client rrdp repo merge

2021-04-13 Thread Claudio Jeker
rpki-client applies all delta files to a temporary location. At the same time files or uri are tracked in a added and deleted set to know which files to remove from the repo or move into place. Now when adding a file to the temp dir one step is missing. If the file was previously removed and then

Re: fix diff3/merge for files lacking \n at EOF

2021-04-13 Thread Stefan Sperling
On Mon, Apr 12, 2021 at 04:29:36PM -0600, Todd C. Miller wrote: > On Mon, 12 Apr 2021 21:18:41 +0200, Stefan Sperling wrote: > > > The problem is that the code scanning a common chunk of lines doesn't > > account for the possibility that EOF may occur before a final newline. > > > > This patch