Re: bgpd strict community negotiation

2021-05-14 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.12 19:49:08 +0200: > RFC5492 is fairly explicit when a capability should be enabled on a > session: > >A BGP speaker that supports a particular capability may use this >capability with its peer after the speaker determines (as described >

Re: rsync fix file handling in uploader

2021-05-14 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.07 17:12:16 +0200: > So yesterday I committed a change to simplify file handling. This removed > the O_NONBLOCK flag from openat() but today I realized that this was a bit > premature. The code at that point does not know if the file is actually a

Re: rsync exit code and error cleanup

2021-05-14 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.07 12:16:26 +0200: > Currently our rsync does not follow the exit codes from rsync. Also the > error handling is complex because ERR() and ERRX() are not terminating the > process. > > This diff tries to start cleaning up the mess a bit.

Re: limit concurrent RTR connects in bgpd

2021-05-14 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.14 11:21:11 +0200: > I think it is a good idea to limit the number of concurrent connects in > bgpd. I used 32 as the limit since that is way enough for the number of > RTR sessions people will configure. > > If the limit is hit the request will

Re: httpd(8): don't try to chunk-encode an empty body

2021-05-14 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2021.05.14 19:13:49 +0200: > As found out by Chris Narkiewicz the hard way, trying to chunk encode an > empty body makes the nextclown app stop working. (see "Nextcloud stopped > working after upgrade to 6.9" on ports@). > > I don't think there is a valid way

Re: iked(8): support for intermediate CAs and multiple CERT payloads

2021-05-14 Thread Stuart Henderson
On 2021/05/14 21:14, Tobias Heider wrote: > On Thu, May 13, 2021 at 02:39:37PM +0900, Katsuhiro Ueno wrote: > > Hi, > > > > I would be happy if iked(8) supports intermediate CAs and sends the > > entire certificate chain to the clients. The diff attached adds > > supports for intermediate CAs and

Re: iked(8): support for intermediate CAs and multiple CERT payloads

2021-05-14 Thread Tobias Heider
On Thu, May 13, 2021 at 02:39:37PM +0900, Katsuhiro Ueno wrote: > Hi, > > I would be happy if iked(8) supports intermediate CAs and sends the > entire certificate chain to the clients. The diff attached adds > supports for intermediate CAs and multiple CERT payloads to iked(8). > > What I would

httpd(8): don't try to chunk-encode an empty body

2021-05-14 Thread Florian Obser
As found out by Chris Narkiewicz the hard way, trying to chunk encode an empty body makes the nextclown app stop working. (see "Nextcloud stopped working after upgrade to 6.9" on ports@). I don't think there is a valid way to do this, so don't try to. This is kinda maybe a hack since there might

smtp(1): protocols and ciphers

2021-05-14 Thread Eric Faurot
Hello. This diff allows to specify protcols and ciphers in smtp(1). I thought it was cleaner to added a generic -O option flag for this. Eric. Index: smtp.1 === RCS file: /cvs/src/usr.sbin/smtpd/smtp.1,v retrieving revision 1.9

Re: mpe.4: properly refer to ioctl(2)

2021-05-14 Thread Klemens Nanni
My bad; fixed, thanks. On Fri, May 14, 2021 at 12:07:14PM +0200, Caspar Schutijser wrote: > Index: mpe.4 > === > RCS file: /cvs/src/share/man/man4/mpe.4,v > retrieving revision 1.11 > diff -u -p -r1.11 mpe.4 > --- mpe.4 18 Mar

Re: running network stack forwarding in parallel

2021-05-14 Thread Martin Pieuchot
On 13/05/21(Thu) 14:50, Vitaliy Makkoveev wrote: > On Thu, May 13, 2021 at 01:15:05PM +0200, Hrvoje Popovski wrote: > > On 13.5.2021. 1:25, Vitaliy Makkoveev wrote: > > > It seems this lock order issue is not parallel diff specific. > > > > > > > > Yes, you are right ... it seemed familiar but

mpe.4: properly refer to ioctl(2)

2021-05-14 Thread Caspar Schutijser
Index: mpe.4 === RCS file: /cvs/src/share/man/man4/mpe.4,v retrieving revision 1.11 diff -u -p -r1.11 mpe.4 --- mpe.4 18 Mar 2021 14:22:04 - 1.11 +++ mpe.4 14 May 2021 10:01:58 - @@ -41,7 +41,7 @@ The

limit concurrent RTR connects in bgpd

2021-05-14 Thread Claudio Jeker
I think it is a good idea to limit the number of concurrent connects in bgpd. I used 32 as the limit since that is way enough for the number of RTR sessions people will configure. If the limit is hit the request will be dropped and the rtr process will retry the connect after the retry timeout.

Re: Fix mbuf leaks in re_rxeof()

2021-05-14 Thread Claudio Jeker
On Thu, May 13, 2021 at 02:40:31PM +, Visa Hankala wrote: > It looks that re_rxeof() might leak mbufs in two cases. The first case > happens if the controller returns an incomplete frame when frames are > expected to be non-fragmented. Note that in this instance the fragment > list sc->rl_head

Re: ftpd(8): add pledge(2)

2021-05-14 Thread Sebastien Marie
On Fri, May 14, 2021 at 07:29:48AM +0200, Matthias Pressfreund wrote: > Interesting. How do I figure the correct order of keywords? So far I thought > it > didn't matter. for the kernel, the order doesn't matter. for people reviewing code, it matters. > On 2021-05-13 18:40, Theo de Raadt