Re: [External] : tcp path mtu discovery max segement size

2021-06-29 Thread Alexandr Nedvedicky
Hello, > > But the functions in_rtchange() and in_pcbrtentry() do not touch > t_maxseg. So orig_maxseg is always equal to tp->t_maxseg and > tcp_output() is not called after changes in t_maxseg. this also matches my observation. > > ok? > tcp_mtudisc() looks good to me now. OK

Re: ifnewlladdr spl

2021-06-29 Thread Hrvoje Popovski
On 29.6.2021. 23:05, Alexander Bluhm wrote: > On Tue, Jun 29, 2021 at 10:39:14PM +0200, Hrvoje Popovski wrote: >> with this diff without any traffic through aggr if i destroy aggr >> interface i'm getting log below ... log can't be reproduced after first >> destroy.. you need to reboot box and

Re: ifnewlladdr spl

2021-06-29 Thread Alexander Bluhm
On Tue, Jun 29, 2021 at 10:39:14PM +0200, Hrvoje Popovski wrote: > with this diff without any traffic through aggr if i destroy aggr > interface i'm getting log below ... log can't be reproduced after first > destroy.. you need to reboot box and then destroy aggr ... > i can't reproduce it with

Re: ifnewlladdr spl

2021-06-29 Thread Hrvoje Popovski
On 29.6.2021. 19:19, Alexander Bluhm wrote: > So what to do with this diff? > > - OK to commit? > - Test it in snaps? > - Call for testers? > > I it would be interesting if the kernel is stable when trunk or > aggr interfaces are created or destroyed while the machine is under > network load.

tcp path mtu discovery max segement size

2021-06-29 Thread Alexander Bluhm
Hi, In tcp_mtudisc() we resend a TCP packet by calling tcp_output() if the TCP maximum segment size changes. At least that is what the code and commit message pretend. revision 1.78 date: 2004/04/26 18:12:25; author: frantzen; state: Exp; lines: +10 -8; - allow

Re: ifnewlladdr spl

2021-06-29 Thread Alexander Bluhm
On Fri, Jun 18, 2021 at 11:32:59PM +0300, Vitaliy Makkoveev wrote: > > I would give the diff below a try. Perhaps in snaps? > > Yes please. splx(9) logic should go away at least from this layer. So what to do with this diff? - OK to commit? - Test it in snaps? - Call for testers? I it would

Re: vscsi/iscsid: wait for scsi_probe to complete after connections are established

2021-06-29 Thread Ashton Fagg
Friendly ping, really hoping someone can take a look. Diffs re-attached. Thanks, Ash Ashton Fagg writes: > Updated diffs attached. > > - I read style(9) a little more closely and worked out I had some > issues, so I corrected those. > > - Revisited the wording in my proposed documentation

Re: Patch: Send AUTHENTICATION_FAILED in case of unexpected auth method or auth data not being accessible

2021-06-29 Thread Tobias Heider
On Tue, Jun 29, 2021 at 05:26:09PM +0200, Patrick Wildt wrote: > Am Tue, Jun 29, 2021 at 10:39:06AM + schrieb Claudia Priesterjahn: > > We added two AUTHENTICATION_FAILED notifications for the cases that > > the peer used an unexepected authentication method and for the case > > that the

Re: Patch: Send AUTHENTICATION_FAILED in case of unexpected auth method or auth data not being accessible

2021-06-29 Thread Patrick Wildt
Am Tue, Jun 29, 2021 at 10:39:06AM + schrieb Claudia Priesterjahn: > We added two AUTHENTICATION_FAILED notifications for the cases that > the peer used an unexepected authentication method and for the case > that the peer's authentication data is not accessible. Bit of a spacing issue, but

Re: crypto(9): remove unused members from 'cryptocap' structure

2021-06-29 Thread Alexander Bluhm
On Fri, Jun 18, 2021 at 11:49:25PM +0300, Vitaliy Makkoveev wrote: > I'm lurking in crypto(9) and I found 'cryptocap' structure has unused > members. Do we want to keep them or they could gone? Looks like statistics that are never evluated. We should move, but I am not sure about the direction.

Re: More use of mdoc macros in sqrt.3

2021-06-29 Thread Ingo Schwarze
Hi Emil, Emil Engler wrote on Tue, Jun 29, 2021 at 03:41:31PM +0200: > This diff inserts an .Fa to the places where it belongs to as well > as an .Er for EDOM. This patch is completely correct and i just committed it. Thank you, Ingo > Index: lib/libm/man/sqrt.3 >

More use of mdoc macros in sqrt.3

2021-06-29 Thread Emil Engler
This diff inserts an .Fa to the places where it belongs to as well as an .Er for EDOM. Index: lib/libm/man/sqrt.3 === RCS file: /cvs/src/lib/libm/man/sqrt.3,v retrieving revision 1.17 diff -u -p -u -p -r1.17 sqrt.3 ---

Re: gpio(4) support for APU2

2021-06-29 Thread Raimo Niskanen
On Tue, Jun 29, 2021 at 04:22:47AM +0100, Chris Narkiewicz wrote: > On Wed, Jan 29, 2020 at 10:47:28PM +0800, Nathanael Rensen wrote: > > The diff below adds gpio(4) support to wbsio(4) for Nuvoton NCT5104D > > (pcengines APU2). > > I'm resurrecting this thread. I was looking for GPIO support for

Patch: Send AUTHENTICATION_FAILED in case of unexpected auth method or auth data not being accessible

2021-06-29 Thread Claudia Priesterjahn
We added two AUTHENTICATION_FAILED notifications for the cases that the peer used an unexepected authentication method and for the case that the peer's authentication data is not accessible. diff --git a/sbin/iked/ikev2.c b/sbin/iked/ikev2.c index 9e890979110..1870dc18459 100644 ---

Re: patch: __realpath: no need of LOCKLEAF

2021-06-29 Thread Claudio Jeker
On Sat, Jun 26, 2021 at 07:07:42AM +0200, Sebastien Marie wrote: > Hi, > > The following diff removes LOCKLEAF from NDINIT. The code doesn't > doesn't need it: the returned vnode is released immediately. The > string path is built from the namei() call using REALPATH, during > directories

bgpd refactor struct prefix

2021-06-29 Thread Claudio Jeker
This diff moves the rib_entry pointer re into the union to safe some space. For add-path I need to add a few more u_int32_t and that would blow the size of struct prefix from 128 to 132 bytes. malloc would round that up to 256bytes and that is bad for the struct that is allocted in millions in

Re: gpio(4) support for APU2

2021-06-29 Thread Chris Narkiewicz
On Wed, Jan 29, 2020 at 10:47:28PM +0800, Nathanael Rensen wrote: > The diff below adds gpio(4) support to wbsio(4) for Nuvoton NCT5104D > (pcengines APU2). I'm resurrecting this thread. I was looking for GPIO support for APU2 board and found this patch in archives. Any chance of taking it in?