usb: don't pass USBD_EXCLUSIVE_USE to usbd_open_pipe_intr()

2021-08-07 Thread Jonathan Matthew
While working on a new driver, I noticed we have a few places where we pass USBD_EXCLUSIVE_USE as the flags parameter to usbd_open_pipe_intr(), which is wrong. The interrupt pipe is always opened exclusively, and the flags parameter is actually passed to usbd_setup_xfer(), where it means

Re: scp(1) changes in snaps

2021-08-07 Thread Christian Weisgerber
"Theo de Raadt": > 2) With very long names, it truncates the end of the path. This is less useful > information. Imagine a copy operation with multiple files being transferred, > one of them is huge and surprisingly long, but you cannot identify which one > because all the truncated long paths

Re: Fix unsafe snmpd defaults

2021-08-07 Thread Stuart Henderson
On 2021/08/07 15:17, Martijn van Duren wrote: > Let me give one final pushback, if this doesn't convince you then feel > free to commit sthen's diff without my OK, but make sure it stays in > sync with snmp(1). I was convinced enough to try it, hence okaying your previous diff, but practical

Re: Fix unsafe snmpd defaults

2021-08-07 Thread Theo de Raadt
Martijn van Duren wrote: > Maybe, but it also made it clear that relying on the defaults for a  > protocol (USM) that doesn't allow to be negotiated will make users > cry. You have selected defaults that noone will naturally use in their existing *OR NEW* environment, and they could spend a

Re: scp(1) changes in snaps

2021-08-07 Thread Theo de Raadt
Damien Miller wrote: > On Fri, 6 Aug 2021, Christian Weisgerber wrote: > > > Damien Miller: > > > > > Just a head-up: snaps currently contain a set of changes[1] to > > > make scp(1) use the SFTP protocol by default. > > > > > Please report any incompatibilities or bugs that you encounter

Re: Fix unsafe snmpd defaults

2021-08-07 Thread Martijn van Duren
Let me give one final pushback, if this doesn't convince you then feel free to commit sthen's diff without my OK, but make sure it stays in sync with snmp(1). First let me sum up what defaults have changed since 6.9: - community authentication disabled (snmpv1/snmpv2c) - no default community name

Re: less(1): refreshing file of size 0 results in file being treated as a pipe

2021-08-07 Thread Ingo Schwarze
Hi, thank you for reporting this bug and for providing a patch to fix it. I just committed your patch. Also thanks to tb@ and deraadt@ for cross-checking the patch. Yours, Ingo user wrote on Thu, Aug 05, 2021 at 12:43:21AM -0500: > Oops, forgot that OpenBSD doesn't have ! capability in

Re: scp(1) changes in snaps

2021-08-07 Thread Damien Miller
On Fri, 6 Aug 2021, Christian Weisgerber wrote: > Damien Miller: > > > Just a head-up: snaps currently contain a set of changes[1] to > > make scp(1) use the SFTP protocol by default. > > > Please report any incompatibilities or bugs that you encounter here > > (tech@), to bugs@ or to openssh@.