Re: Atomic signal flags for vi(1)

2021-09-01 Thread trondd
Ingo Schwarze wrote: > Hi, > > Ingo Schwarze wrote on Wed, Sep 01, 2021 at 04:38:51PM +0200: > > > Note that the h_hup() and h_term() signal handlers are still unsafe > > after this commit because they also set the "killersig" (how fitting!) > > field in a global struct. > > I like it when

Re: netstart routing domain loopback

2021-09-01 Thread Klemens Nanni
On Wed, Sep 01, 2021 at 11:37:10PM +0200, Alexander Bluhm wrote: > On Wed, Aug 18, 2021 at 04:28:13PM +0200, Alexander Bluhm wrote: > > I want to create an enc1 interface for routing domain 1 and set > > additional addresses on lo1. So my net config looks like this. > > > > ==>

Re: netstart routing domain loopback

2021-09-01 Thread Alexander Bluhm
On Wed, Aug 18, 2021 at 04:28:13PM +0200, Alexander Bluhm wrote: > I want to create an enc1 interface for routing domain 1 and set > additional addresses on lo1. So my net config looks like this. > > ==> /etc/hostname.enc1 <== > rdomain 1 > > ==> /etc/hostname.lo1 <== > rdomain 1 > inet alias

Re: libagentx: Fix thumbling after free

2021-09-01 Thread Martijn van Duren
Bluhm asked me to rethink the freeing strategy. Here's the end result. On Mon, 2021-08-30 at 12:03 +0200, Martijn van Duren wrote: > I missed this one before, since apparently it doesn't show up with > MALLOC_OPTIONS set to "S", but it does if it is empty. > > This probably effects relayd if the

Re: update to tcpdump(8)

2021-09-01 Thread Denis Fondras
Le Wed, Sep 01, 2021 at 06:42:54PM +0100, Jason McIntyre a écrit : > On Wed, Sep 01, 2021 at 06:15:04PM +0200, Denis Fondras wrote: > > I was searching for the sampling command of tcpdump but could not find it > > in the > > manual. In fact it is missing some primitives compared to pcap-filter >

Re: update to tcpdump(8)

2021-09-01 Thread Jason McIntyre
On Wed, Sep 01, 2021 at 06:15:04PM +0200, Denis Fondras wrote: > I was searching for the sampling command of tcpdump but could not find it in > the > manual. In fact it is missing some primitives compared to pcap-filter manual. > hi. it looks like there's a whole heap of duplication going on

Re: Atomic signal flags for vi(1)

2021-09-01 Thread Ingo Schwarze
Hi, Ingo Schwarze wrote on Wed, Sep 01, 2021 at 04:38:51PM +0200: > Note that the h_hup() and h_term() signal handlers are still unsafe > after this commit because they also set the "killersig" (how fitting!) > field in a global struct. I like it when fixing two bugs only amounts to minus:

update to tcpdump(8)

2021-09-01 Thread Denis Fondras
I was searching for the sampling command of tcpdump but could not find it in the manual. In fact it is missing some primitives compared to pcap-filter manual. Index: tcpdump.8 === RCS file: /cvs/src/usr.sbin/tcpdump/tcpdump.8,v

Re: diff(1)ing hardlinks

2021-09-01 Thread Todd C . Miller
On Wed, 01 Sep 2021 01:33:34 +0200, Alexander Hall wrote: > If two files to be compared share the same inode, it should > be reasonable to consider them identical. > > This gives a substantial speedup when comparing directory > structures with many hardlinked files, e.g. when using > rsnapshot

Re: Import timeout(1) from NetBSD

2021-09-01 Thread Theo de Raadt
It needs pledge. > +#include This is wrong, it should be > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define EXIT_TIMEOUT 124 > + > +static sig_atomic_t

Re: [diff] src/usr.sbin/smtpd: table_diff lacks some lookup kinds

2021-09-01 Thread gilles
August 29, 2021 10:16 PM, gil...@poolp.org wrote: > Hellow, > > The K_STRING and K_REGEX lookup kinds are missing from table_db even though > nothing prevents > them from working technically. The following diff is enough to allow db > tables to be used on > regex or string contexts. > >

Re: regress: don't needlessly fiddle with MALLOC_OPTIONS

2021-09-01 Thread Alexander Bluhm
On Wed, Sep 01, 2021 at 01:42:41PM +0200, Jasper Lievisse Adriaanse wrote: > Hi, > > As discussed earlier with bluhm, regress tests shouldn't set or modify > MALLOC_OPTIONS (except under very specific situations, like malloc tests). > It would be better to set the options globally through sysctl

Import timeout(1) from NetBSD

2021-09-01 Thread Job Snijders
Hi, FreeBSD/NetBSD/DragonFly and GNU 'coreutils' have a utility called timeout(1) which allows you to kill a process after X time. Importing timeout would remove the only reason I have coreutils installed :-) I retrieved timeout.{c,1} from

Re: Atomic signal flags for vi(1)

2021-09-01 Thread Ingo Schwarze
Hi Tim, trondd wrote on Tue, Aug 24, 2021 at 07:45:33PM -0400: > "Theo de Raadt" wrote: >> +h_alrm(int signo) >> +{ >> + GLOBAL_CLP; >> + >> + F_SET(clp, CL_SIGALRM); >> >> F_SET is |=, which is not atomic. >> >> This is unsafe. Safe signal handlers need to make single stores to

Re: Incorrect IPL when pool_get(9) is called under rwlock

2021-09-01 Thread Mike Larkin
On Wed, Sep 01, 2021 at 08:53:35AM +0200, Martin Pieuchot wrote: > syzkaller reported [0] the following lock ordering issue: > > db{0}> trace > db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:440 > panic(82464b8f) at panic+0x177 sys/kern/subr_prf.c:202 >

Re: uaq(4): aquantia usb ethernet driver

2021-09-01 Thread Brad Smith
On 8/31/2021 8:46 PM, Jonathan Matthew wrote: Here's a driver for the Aquantia USB ethernet devices I just added to usbdevs. These are somewhat interesting because they theoretically go up to 5GbE and support jumbo frames (not implemented yet). While working on this I noticed that it doesn't

Re: iked(8): client-side DNS support via resolvd(8)

2021-09-01 Thread Florian Obser
On 2021-09-01 13:28 +02, Tobias Heider wrote: > Here's an updated diff with the following changes: > > - Send the ifidx of the configured 'iface' instead of ifidx 0 to prevent > name collisions > - Cache the first received DNS server locally for cleanup/resending. > - Handle

regress: don't needlessly fiddle with MALLOC_OPTIONS

2021-09-01 Thread Jasper Lievisse Adriaanse
Hi, As discussed earlier with bluhm, regress tests shouldn't set or modify MALLOC_OPTIONS (except under very specific situations, like malloc tests). It would be better to set the options globally through sysctl when running the suite, as bluhm does. So remove most cases of MALLOC_OPTIONS from

Re: iked(8): client-side DNS support via resolvd(8)

2021-09-01 Thread Tobias Heider
Here's an updated diff with the following changes: - Send the ifidx of the configured 'iface' instead of ifidx 0 to prevent name collisions - Cache the first received DNS server locally for cleanup/resending. - Handle RTP_PROPOSAL_SOLICIT by resending the cached server. - Remove the cached

Re: rpki-client exclude files from rsync fetch

2021-09-01 Thread Theo de Raadt
Job Snijders wrote: > On Wed, Sep 01, 2021 at 11:14:15AM +0200, Claudio Jeker wrote: > > On Tue, Aug 31, 2021 at 02:23:57PM +0200, Claudio Jeker wrote: > > > RPKI repository can only include a few specific files, everything else is > > > just ignored and deleted after every fetch. Since

Re: diff(1)ing hardlinks

2021-09-01 Thread Stefan Sperling
On Wed, Sep 01, 2021 at 01:12:20PM +0200, Stefan Sperling wrote: > On Wed, Sep 01, 2021 at 01:33:34AM +0200, Alexander Hall wrote: > > If two files to be compared share the same inode, it should > > be reasonable to consider them identical. > > > > This gives a substantial speedup when comparing

Re: rpki-client exclude files from rsync fetch

2021-09-01 Thread Job Snijders
On Wed, Sep 01, 2021 at 11:14:15AM +0200, Claudio Jeker wrote: > On Tue, Aug 31, 2021 at 02:23:57PM +0200, Claudio Jeker wrote: > > RPKI repository can only include a few specific files, everything else is > > just ignored and deleted after every fetch. Since openrsync supports > > --exclude-file

Re: diff(1)ing hardlinks

2021-09-01 Thread Stefan Sperling
On Wed, Sep 01, 2021 at 01:33:34AM +0200, Alexander Hall wrote: > If two files to be compared share the same inode, it should > be reasonable to consider them identical. > > This gives a substantial speedup when comparing directory > structures with many hardlinked files, e.g. when using >

Re: async traceroute(8)

2021-09-01 Thread Theo de Raadt
Stuart Henderson wrote: > On 2021/09/01 11:25, Florian Obser wrote: > > So traceroute sends one probe, waits upto 5^W3 seconds for an answer to > > arrive, sends the next probe and so on. > > > > This makes it a bit faster (10x on a path with two intermediate systems > > not answering) by

Re: async traceroute(8)

2021-09-01 Thread Stuart Henderson
On 2021/09/01 11:25, Florian Obser wrote: > So traceroute sends one probe, waits upto 5^W3 seconds for an answer to > arrive, sends the next probe and so on. > > This makes it a bit faster (10x on a path with two intermediate systems > not answering) by sending probes, waiting for the answer and

Re: rpki-client add http_proxy support

2021-09-01 Thread Claudio Jeker
On Wed, Sep 01, 2021 at 09:38:55AM +, Job Snijders wrote: > On Tue, Aug 31, 2021 at 09:58:54AM +0200, Claudio Jeker wrote: > > This diff improves the http code by a) adding an IO timeout and b) > > implementing http_proxy support. > > > > Works for me using tinyproxy as proxy server. > > OK?

Re: rpki-client add http_proxy support

2021-09-01 Thread Job Snijders
On Tue, Aug 31, 2021 at 09:58:54AM +0200, Claudio Jeker wrote: > This diff improves the http code by a) adding an IO timeout and b) > implementing http_proxy support. > > Works for me using tinyproxy as proxy server. OK? Index: http.c

async traceroute(8)

2021-09-01 Thread Florian Obser
So traceroute sends one probe, waits upto 5^W3 seconds for an answer to arrive, sends the next probe and so on. This makes it a bit faster (10x on a path with two intermediate systems not answering) by sending probes, waiting for the answer and doing reverse DNS lookups async. Please test. diff

Re: rpki-client exclude files from rsync fetch

2021-09-01 Thread Claudio Jeker
On Tue, Aug 31, 2021 at 02:23:57PM +0200, Claudio Jeker wrote: > RPKI repository can only include a few specific files, everything else is > just ignored and deleted after every fetch. Since openrsync supports > --exclude-file now we can use this to limit what is actually accepted by > the

Re: [patch] pool_sethardlimit(9): Actually print warnmess to console

2021-09-01 Thread Jesper Wallin
Ping? On Sat, Aug 21, 2021 at 08:21:55PM +0200, Jesper Wallin wrote: > Hi tech@ > > I'm trying to add log message when the pf(4) state table becomes > exhausted/full. After reading the code, I learned that it's using > pool_sethardlimit(9) to manage the resources. > > Conveniently,

Re: diff(1)ing hardlinks

2021-09-01 Thread Theo de Raadt
shocking this test wasn't already in place. Alexander Hall wrote: > If two files to be compared share the same inode, it should > be reasonable to consider them identical. > > This gives a substantial speedup when comparing directory > structures with many hardlinked files, e.g. when using >

Re: Incorrect IPL when pool_get(9) is called under rwlock

2021-09-01 Thread Mike Larkin
On Wed, Sep 01, 2021 at 08:53:35AM +0200, Martin Pieuchot wrote: > syzkaller reported [0] the following lock ordering issue: > > db{0}> trace > db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:440 > panic(82464b8f) at panic+0x177 sys/kern/subr_prf.c:202 >

Incorrect IPL when pool_get(9) is called under rwlock

2021-09-01 Thread Martin Pieuchot
syzkaller reported [0] the following lock ordering issue: db{0}> trace db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:440 panic(82464b8f) at panic+0x177 sys/kern/subr_prf.c:202 witness_checkorder(82838c20,9,0) at witness_checkorder+0x11eb

Re: uaq(4): aquantia usb ethernet driver

2021-09-01 Thread Kevin Lo
On Wed, Sep 01, 2021 at 10:46:01AM +1000, Jonathan Matthew wrote: > > Here's a driver for the Aquantia USB ethernet devices I just added > to usbdevs. These are somewhat interesting because they theoretically > go up to 5GbE and support jumbo frames (not implemented yet). > > While working on

Re: acpibtn.4: Mention sleep putton, lid status and machdep.{lid,pwr}action

2021-09-01 Thread Jason McIntyre
On Tue, Aug 31, 2021 at 11:51:37PM +, Klemens Nanni wrote: > landry added the sensor back in 2013 and suspend via sleep button also works > (at least on ThinkPads). > > machdep.*action are super useful and I dislike grepping /etc/examples/ > for to read about them. > > acpibtn(4) is the most