Re: syslogd sendmsg

2021-09-10 Thread Vitaliy Makkoveev
On Fri, Sep 10, 2021 at 07:40:58PM +0200, Alexander Bluhm wrote: > Hi, > > After converting syslogd messages to iov, UDP can use sendmsg(2) > instead of snprintf(). > > ok? > I have one question below, but the diff is ok by mvs@ if it is not significant. It is expected we could drop

Re: Diff: Function Length Reduction

2021-09-10 Thread VARIK VALEFOR
STUART HENDERSON: Is any particular aspect of the replacement code bad? Being able to better detect cheesiness in C programs would be nice -- Haskellers are a different breed and need to be taught some things. ;^) Note that OMAR POLO modifies the replacement such that the readability of this

Fix headphone jack on Cirrus 4206

2021-09-10 Thread Tracey Emery
Hello, After reading some Linux commits, it shows the GPIO2 on the CS4206 chips needs to be unmuted to make the headphone jack work. The following diff fixed the headphone jack problem on my iMac12,2, amd64. ok? -- Tracey Emery diff 51d7e35078715d4d1d1e1bf2fb89362bad8797d8 /usr/src blob -

Re: Diff: Function Length Reduction

2021-09-10 Thread Stuart Henderson
On 2021/09/10 16:39, VARIK VALEFOR wrote: > Is any particular aspect of the replacement code bad? The use of 'magic number' ASCII values obfuscates what the code is doing.

Re: updated patch for iwx(4) Tx aggregation

2021-09-10 Thread Dave Voutila
Stefan Sperling writes: > Here is another attempt at adding Tx aggregation to iwx(4). > This patch is based on the latest state in CVS (if_iwx.c r1.107, which > I have committed a minute ago). Sync your tree before applying this patch. > > Compared to previous iterations of this patch, I have

syslogd sendmsg

2021-09-10 Thread Alexander Bluhm
Hi, After converting syslogd messages to iov, UDP can use sendmsg(2) instead of snprintf(). ok? bluhm Index: usr.sbin/syslogd/syslogd.c === RCS file: /cvs/src/usr.sbin/syslogd/syslogd.c,v retrieving revision 1.269 diff -u -p

updated patch for iwx(4) Tx aggregation

2021-09-10 Thread Stefan Sperling
Here is another attempt at adding Tx aggregation to iwx(4). This patch is based on the latest state in CVS (if_iwx.c r1.107, which I have committed a minute ago). Sync your tree before applying this patch. Compared to previous iterations of this patch, I have fixed bugs which caused fatal

Re: EVP_DigestInit.3: OpenSSL_add_all_digests() not needed

2021-09-10 Thread Theo Buehler
On Fri, Sep 10, 2021 at 10:32:54AM -0600, Todd C. Miller wrote: > The man page for OpenSSL_add_all_digests() says it is deprecated > and should not be called by user code. However, EVP_DigestInit.3 > says it must be used. > > One of those is wrong... Calling OpenSSL_add_all_digests() is no

EVP_DigestInit.3: OpenSSL_add_all_digests() not needed

2021-09-10 Thread Todd C . Miller
The man page for OpenSSL_add_all_digests() says it is deprecated and should not be called by user code. However, EVP_DigestInit.3 says it must be used. One of those is wrong... - todd Index: lib/libcrypto/man/EVP_DigestInit.3 ===

Re: let iwx(4) resume in the acpi thread

2021-09-10 Thread Mike Larkin
On Fri, Sep 10, 2021 at 11:12:45AM +0200, Stefan Sperling wrote: > On Fri, Sep 10, 2021 at 10:59:25AM +0200, Stefan Sperling wrote: > > On Fri, Sep 10, 2021 at 10:58:47AM +0200, Stefan Sperling wrote: > > > All those changes are shown below. My device is still happy with this. > > > I will reply

Re: Change vm_dsize to vsize_t

2021-09-10 Thread Theo de Raadt
Sebastien Marie wrote: > On Fri, Sep 10, 2021 at 08:12:58AM -0600, Theo de Raadt wrote: > > > for Rust programs. It should even be free as Rust libc crate doesn't > > > have `struct kinfo_proc` definition. I can't comment on Go side. > > > > The structure has nothing to do with libc! > > > >

Re: Change vm_dsize to vsize_t

2021-09-10 Thread Sebastien Marie
On Fri, Sep 10, 2021 at 08:12:58AM -0600, Theo de Raadt wrote: > > for Rust programs. It should even be free as Rust libc crate doesn't > > have `struct kinfo_proc` definition. I can't comment on Go side. > > The structure has nothing to do with libc! > > So why would it occur there? Because

Re: Change vm_dsize to vsize_t

2021-09-10 Thread Theo de Raadt
> for Rust programs. It should even be free as Rust libc crate doesn't > have `struct kinfo_proc` definition. I can't comment on Go side. The structure has nothing to do with libc! So why would it occur there?

Re: Change vm_dsize to vsize_t

2021-09-10 Thread Sebastien Marie
On Thu, Sep 09, 2021 at 12:01:14PM -0600, Theo de Raadt wrote: > Stuart Henderson wrote: > > > On 2021/09/09 06:47, Greg Steuck wrote: > > > Mark Kettenis writes: > > > > > > >> From: "Theo de Raadt" > > > >> Date: Tue, 07 Sep 2021 07:08:19 -0600 > > > >> > > > >> Or we could coordinate the

Re: Diff: Function Length Reduction

2021-09-10 Thread Stuart Henderson
On 2021/09/10 00:27, VARIK VALEFOR wrote: > P.S. s/originalBuf/vp->buffer/g I think this is a good demonstration of why sometimes it's better to have longer but simpler code.

Re: rpki-client add back keep-alive to http requests

2021-09-10 Thread Claudio Jeker
On Thu, Sep 09, 2021 at 09:18:04AM -0600, Bob Beck wrote: > > ok beck@ > > On Thu, Sep 09, 2021 at 09:35:51AM +0200, Claudio Jeker wrote: > > While Connection: keep-alive should be the default it seems that at least > > some of the CA repositories fail to behave like that. Adding back the > >

gdb: follow frame pointer link over trap frame

2021-09-10 Thread Yuichiro NAITO
When a new trap code is added in OpenBSD kernel, gdb needs to be updated to be taught which symbols are trap frame. This scenario is just the case of a following patch. *1: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/gnu/usr.bin/binutils/gdb/amd64obsd-tdep.c.diff?r1=1.13=1.14=h In current

Re: let iwx(4) resume in the acpi thread

2021-09-10 Thread Stefan Sperling
On Fri, Sep 10, 2021 at 10:59:25AM +0200, Stefan Sperling wrote: > On Fri, Sep 10, 2021 at 10:58:47AM +0200, Stefan Sperling wrote: > > All those changes are shown below. My device is still happy with this. > > I will reply with a new full diff against -current next. > > Full diff: Just realized

Re: let iwx(4) resume in the acpi thread

2021-09-10 Thread Stefan Sperling
On Fri, Sep 10, 2021 at 10:58:47AM +0200, Stefan Sperling wrote: > All those changes are shown below. My device is still happy with this. > I will reply with a new full diff against -current next. Full diff: diff c9db663b670f8930f62c8f20c36e84d72697f036 refs/heads/iwx-resume2 blob -

Re: let iwx(4) resume in the acpi thread

2021-09-10 Thread Stefan Sperling
On Thu, Sep 09, 2021 at 03:15:07PM -0700, Mike Larkin wrote: > On Wed, Sep 08, 2021 at 03:25:20PM +0200, Stefan Sperling wrote: > > On Wed, Sep 08, 2021 at 02:19:00PM +0200, Stefan Sperling wrote: > > > This patch applies on top of all the other iwx(4) diffs I've sent today. > > > It makes iwx(4)

Re: Diff: Function Length Reduction

2021-09-10 Thread VARIK VALEFOR
P.S. s/originalBuf/vp->buffer/g The CORRECTED diff is as follows: diff --git a/usr.bin/vi/vi/v_put.c b/usr.bin/vi/vi/v_put.c index 959d4a47698..4e30bc620d3 100644 --- a/usr.bin/vi/vi/v_put.c +++ b/usr.bin/vi/vi/v_put.c @@ -104,35 +104,6 @@ v_put(SCR *sp, VICMD *vp) static void inc_buf(SCR

Re: [SPAM?] OpenBSD's experience with writing secure c/c++ code.

2021-09-10 Thread Martin Schröder
Am Do., 9. Sept. 2021 um 15:03 Uhr schrieb el3ctr0lyte : > Rust totes itself as a systems programming language that promises memory > safety and so far it seems to deliver on that promise. I was just wondering, > what are your opinions on Rust and do you guys think it is a worth while >