On Sun, Oct 24, 2021 at 07:23:30AM +0200, Sebastien Marie wrote:
>
> ok semarie@
>
> and while reviewing the code, I saw sppp_get_ip_addrs() last argument
> (u_int32_t *srcmask) is always passed as NULL.
>
> In fact, both sppp_get_ip_addrs() and sppp_get_ip6_addrs() has the
> same argument
ok semarie@
and while reviewing the code, I saw sppp_get_ip_addrs() last argument
(u_int32_t *srcmask) is always passed as NULL.
In fact, both sppp_get_ip_addrs() and sppp_get_ip6_addrs() has the
same argument never used.
Does it is something to simplify ? The code inside the functions is
On Sat, Oct 23, 2021 at 06:55:02PM +0100, Ricardo Mestre wrote:
> does rad(8) actually need rpath here? as far as i can see it needs to open the
> config, plus its includes, but that is already done before pledge(2) by imsg
> sending IMSG_RECONF_CONF.
>
> florian@ is this correct or am i trusting
Index: db/btree/bt_close.c
===
RCS file: /cvs/src/lib/libc/db/btree/bt_close.c,v
retrieving revision 1.10
diff -u -p -r1.10 bt_close.c
--- db/btree/bt_close.c 16 Jan 2015 16:48:51 - 1.10
+++ db/btree/bt_close.c 24 Oct 2021
I recently found myself wanting to moniter local time from a number of
locations around the world.
Setting the TZ environment variable on grdc did a wonderfull job at this.
At which point, I wanted to know which clock was showing what time.
This lead to the following patch.
If curious as to how
excluding sys/crypto/xform_ipcomp.c:76:23 as zlib has Z_NULL as 0
diff --git sys/crypto/cryptosoft.c sys/crypto/cryptosoft.c
index dcb815aaa17..be1f3f1ec5c 100644
--- sys/crypto/cryptosoft.c
+++ sys/crypto/cryptosoft.c
@@ -424,7 +424,7 @@ swcr_authcompute(struct cryptop *crp, struct cryptodesc
diff --git sys/ddb/db_break.c sys/ddb/db_break.c
index dfe2f3af912..85354e32987 100644
--- sys/ddb/db_break.c
+++ sys/ddb/db_break.c
@@ -46,8 +46,8 @@
#defineNBREAKPOINTS100
struct db_breakpoint db_break_table[NBREAKPOINTS];
db_breakpoint_tdb_next_free_breakpoint =
diff --git sys/netinet/in_pcb.c sys/netinet/in_pcb.c
index cd60f66b50a..d3b6e4a1015 100644
--- sys/netinet/in_pcb.c
+++ sys/netinet/in_pcb.c
@@ -756,7 +756,7 @@ in_rtchange(struct inpcb *inp, int errno)
{
if (inp->inp_route.ro_rt) {
rtfree(inp->inp_route.ro_rt);
-
diff --git sys/net/bpf.c sys/net/bpf.c
index 87a9d726423..87418c3dc17 100644
--- sys/net/bpf.c
+++ sys/net/bpf.c
@@ -1019,7 +1019,7 @@ bpf_setf(struct bpf_d *d, struct bpf_program *fp, int wf)
KERNEL_ASSERT_LOCKED();
- if (fp->bf_insns == 0) {
+ if (fp->bf_insns == NULL) {
Hi,
There are more m_pullup()s in IPsec input. Pass down the pointer
to the mbuf. At the end it will reach ip_deliver() which expects
a pointer to an mbuf anyway.
ok?
bluhm
Index: netinet/ip_ah.c
===
RCS file:
Any feedback, direction, or suggestions? I'd like to see something
get in as the current situation not only doesn't recover unsaved work
but it sets a user up to potentially lose saved work, too.
Tim.
trondd wrote:
> This is a new attempt at fixing vi(1) recovery by actually writing
> to
On Fri, Oct 22, 2021 at 10:36:55PM +0300, Mikhail wrote:
> On Sat, Oct 16, 2021 at 03:13:39PM +0300, Mikhail wrote:
> > Hello, I was troubleshooting postgresql not being able to start after
> > 'pkill -6 postgres'. The error was:
> >
> > FATAL: could not create semaphores: No space left on device
commited,
Thanks for reporting and this and the patches, and sorry for the delay.
/Benno
Sebastian Benoit(be...@openbsd.org) on 2021.10.23 22:22:10 +0200:
> Jonathon Fletcher(jonathon.fletc...@gmail.com) on 2021.10.19 14:26:51 -0700:
> > On Sun, May 02, 2021 at 11:05:16AM -0700, Jonathon
RFC2578 section 7.1.1:
The INTEGER type (but not the Integer32 type) may also be used to
represent integer-valued information as named-number enumerations.
RFC3416 section 2.5:
A BITS value is encoded as an OCTET STRING
So these two can go.
There's still plenty opportunity for cleanup
Jonathon Fletcher(jonathon.fletc...@gmail.com) on 2021.10.19 14:26:51 -0700:
> On Sun, May 02, 2021 at 11:05:16AM -0700, Jonathon Fletcher wrote:
> > On Sun, Mar 07, 2021 at 06:22:04PM -0800, Jonathon Fletcher wrote:
> > > On Sun, Mar 07, 2021 at 06:46:33PM +0100, Marcus MERIGHI wrote:
> > > >
The diff below removes a few leftover tdb_crypto allocations in esp_input()
and esp_output(). The allocations were needed to pass arguments to the
callback function with the non-blocking crypto API and are redundant now
that crypto is blocking.
This should result in a notable speedup for ESP.
does rad(8) actually need rpath here? as far as i can see it needs to open the
config, plus its includes, but that is already done before pledge(2) by imsg
sending IMSG_RECONF_CONF.
florian@ is this correct or am i trusting too much on my eyes?
Index: rad.c
ensure that sensitive data is zeroed out from mem.
ok?
Index: login_reject.c
===
RCS file: /cvs/src/libexec/login_reject/login_reject.c,v
retrieving revision 1.17
diff -u -p -u -r1.17 login_reject.c
--- login_reject.c 26 Apr
On Sat, Oct 23, 2021 at 10:40:56AM +0100, Martin Pieuchot wrote:
> Diff below switches both poll(2) and select(2) to the kqueue-based
> implementation.
Passed regress on i386.
> In addition it switches libevent(3) to use poll(2) by default for
> testing purposes.
It created some test failures
Ah, right. OK deraadt
Ricardo Mestre wrote:
> the semantics should be to call unveil on something before the NULL,NULL
> otherwise nothing will get unveiled, maybe bob disagrees? :)
>
> regarding the weird behaviour well there are other programs with the same
> issue, see pfctl, it accepts
the semantics should be to call unveil on something before the NULL,NULL
otherwise nothing will get unveiled, maybe bob disagrees? :)
regarding the weird behaviour well there are other programs with the same
issue, see pfctl, it accepts several configs but only stops loading if one
of them is
But the -f file is opened above your proposed unveil() addition. So I think
you only need unveil(NULL,NULL).
While here, I see a different weird problem:
stty -f file -f dsaf -f dsaf -f sadf -f asdf -f sadf
You can pass lots of -f options, and stty will leak them the fd's. I
suspect it
stty(1) can't be pledged for all modes, but it can be unveiled. the only file to
be opened is on stty -f `file', so call unveil(2) afterwards to restrict all fs
access. tested with all arguments through ktrace/kdump.
ok?
Index: stty.c
On Sat, Oct 23, 2021 at 05:47:58PM +0200, Mark Kettenis wrote:
> > Date: Sat, 23 Oct 2021 17:29:36 +0200
> > From: Claudio Jeker
> >
> > The sys___thrsigdivert code can be simplified a bit. It is possible to
> > set the error before the loop and then have the loop exit after polling
> > for
> Date: Sat, 23 Oct 2021 17:29:36 +0200
> From: Claudio Jeker
>
> The sys___thrsigdivert code can be simplified a bit. It is possible to
> set the error before the loop and then have the loop exit after polling
> for pending signals. IMO the results looks nicer than what we have now.
>
> OK?
ok benno@
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.10.23 14:20:19 +0200:
> This diff changes the io read functions to work on ibufs.
> With this the poll loops will consume data with io_buf_read() until a full
> message is received and then that message is processed. Thanks to this
> the
The sys___thrsigdivert code can be simplified a bit. It is possible to
set the error before the loop and then have the loop exit after polling
for pending signals. IMO the results looks nicer than what we have now.
OK?
--
:wq Claudio
Index: kern/kern_sig.c
On Sat, Oct 23, 2021 at 05:21:53PM +0200, Sebastian Benoit wrote:
> differentiate the third 413 from the other two in httpd.
OK kn
differentiate the third 413 from the other two in httpd.
ok?
diff --git usr.sbin/httpd/server_http.c usr.sbin/httpd/server_http.c
index 153829f4201..bf3fae05414 100644
--- usr.sbin/httpd/server_http.c
+++ usr.sbin/httpd/server_http.c
@@ -1406,7 +1406,7 @@ server_response(struct httpd *httpd,
> On 22 Oct 2021, at 21:38, Alexander Bluhm wrote:
>
> Hi,
>
> I found a m_pullup() down in ah input. As it may free or change
> the mbuf, the caller must be careful. All callers do not use the
> mbuf, so we are safe. Nevertheless I would like to use a common
> pattern to handle this. Pass
> On 23 Oct 2021, at 16:08, Tobias Heider wrote:
>
> Now that we have removed all the legacy crypto offloading drivers we can
> simplify the crypto framework API by ripping out the async callbacks.
>
> The diff below removes crypto_dispatch() and crypto_done() and replaces
> them with
On Sat, Oct 23, 2021 at 11:45:03AM +0100, Jason McIntyre wrote:
> i think this is fine. are you asking for an ok because you are a
> developer? if not i'll commit it unless i hear anyone object.
I'm not a developer, so please commit on your behalf.
On Sat, Oct 23, 2021 at 03:08:29PM +0200, Tobias Heider wrote:
> Now that we have removed all the legacy crypto offloading drivers we can
> simplify the crypto framework API by ripping out the async callbacks.
>
> The diff below removes crypto_dispatch() and crypto_done() and replaces
> them with
Stuart Henderson, 2021-10-21 16:45:47 +0100:
> Sometimes I find it useful to list daemons which are set to 'disabled'
> but are actually running. Either those where I have started them by hand
> forgotten to enable in rc.conf.local, or to check for services which
> shouldn't be running but which
Ross L Richardson(open...@rlr.id.au) on 2021.10.09 21:40:50 +1100:
> This relates to the earlier messages I sent to bugs@ in:
> https://marc.info/?t=16330937691=1=2
>
> RFC 7231 [HTTP/1.1] section 4.3.2. "HEAD" states:
> The HEAD method is identical to GET except that the server
Now that we have removed all the legacy crypto offloading drivers we can
simplify the crypto framework API by ripping out the async callbacks.
The diff below removes crypto_dispatch() and crypto_done() and replaces
them with crypto_invoke() which is blocking and only returns after the
operation
This diff changes the io read functions to work on ibufs.
With this the poll loops will consume data with io_buf_read() until a full
message is received and then that message is processed. Thanks to this
the processes no longer block while waiting for more data in the io read
functions.
With this
Diff below is extracted from the current UVM unlocking diff. It adds a
couple of uvm_obj_destroy() and move some uvm_obj_init() around.
uvm_obj_destroy() will be used to release the memory of the, possibly
shared, lock allocated in uvm_obj_init(). When it is call the object
should no longer
On Fri, Oct 22, 2021 at 10:36:55PM +0300, Mikhail wrote:
> On Sat, Oct 16, 2021 at 03:13:39PM +0300, Mikhail wrote:
> > Hello, I was troubleshooting postgresql not being able to start after
> > 'pkill -6 postgres'. The error was:
> >
> > FATAL: could not create semaphores: No space left on device
Right now tcpdump prints noSuchObject/noSuchInstance/endOfMibView as
[P/x/GetRequest]/[P/x/GetNextRequest]/[P/x/GetResponse]. This is because
tcpdump doesn't treat CONTEXT for what it is: context dependent.
I'm not going to untangle this entire mess, but this diff at least gives
us a better
We moved away from the idea of default community in all of our snmp
tools. Let's give tcpdump the same treatment so that people don't
get the wrong idea.
OK?
martijn@
Index: print-snmp.c
===
RCS file:
Anyone?
We really want this one...
- Fix #194: Incorrect NSEC3 response for SOA query below delegation
point.
On 2021-10-20 18:24 +02, Florian Obser wrote:
> Particularly interesting is
> - Fix #190: NSD returns 3 NSEC3 records for NODATA response.
>
> which I believe is a fix for the problem
Diff below switches both poll(2) and select(2) to the kqueue-based
implementation.
In addition it switches libevent(3) to use poll(2) by default for
testing purposes.
I don't have any open bug left with this diff and I'm happily running
GNOME with it. So I'd be happy if you could try to break
Thanks to benno who found the original reference to this value.
Help out some poor soul who might wander in here in the future.
OK?
martijn@
Index: print-snmp.c
===
RCS file: /cvs/src/usr.sbin/tcpdump/print-snmp.c,v
retrieving
On Fri, Oct 22, 2021 at 07:27:28PM +0100, Stuart Henderson wrote:
> On 2021/10/22 12:56, Stuart Henderson wrote:
> > On 2021/10/22 12:20, Antoine Jacoutot wrote:
> > > On Thu, Oct 21, 2021 at 04:45:47PM +0100, Stuart Henderson wrote:
> > > > Sometimes I find it useful to list daemons which are set
45 matches
Mail list logo
