Re: Teach manpages of resolv(8) and unwindctl(8) about sppp(4)

2021-11-10 Thread Bjorn Ketelaars
On Wed 10/11/2021 21:20, Klemens Nanni wrote: > I think only unwind(8) should list all the inputs and unwindctl(8) > should just say "Show learned nameservers". > > unwind(8) is already incomplete regardless of sppp(4) and unwindctl(8) > is a poor duplicate of it. I agree with unwindctl(8). For

ssh/sshd change in snaps

2021-11-10 Thread Damien Miller
Hi, Snaps is now carrying a change to ssh/sshd that converts their mainloops from select(2) to poll/ppoll(2). This change should be completely transparent, but please be on the lookout for any weird behaviour. Bugs in the revised mainloop are most likely to appear as crashes, hangs or ssh/sshd

Re: Faster unhibernate by skipping devices

2021-11-10 Thread Theo de Raadt
You are talking about -current. -current unhibernate has a shortcut where it skips attaching some devices in the bsd.booted "unhibernate" kernel. 7.0 does not have that change. Does 7.0 behave better? If 7.0 behaves better, are you able to backout the the diff which skips attaching devices,

Re: give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Theo de Raadt
> If we move the RTP_PROPOSAL_SOLICIT we might as well at the same time move > the other RTP_PROPOSAL values to give us more room for additional devices. > > It would be a "upgrade with a snapshot or your dns might not work" > situation. or put PPP after SOLICIT The sort function does not care,

Re: bsd.upgrade fails `umount /mnt` with a single partition disk.

2021-11-10 Thread Theo de Raadt
Yuichiro NAITO wrote: > I don't have better idea than executing dd in foreground. > How should we fix this? You have provided really good information. Something is pretty fundamentally broken, and we'll need to look into it. The dd should die because it's filesystem is being taken away.

Re: bsd.upgrade fails `umount /mnt` with a single partition disk.

2021-11-10 Thread Yuichiro NAITO
I tried to call 'db_enter' instead of 'panic' in 'vflush_vnode' function as follows. ``` --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -966,6 +966,7 @@ vflush_vnode(struct vnode *vp, void *arg) vprint("vflush: busy vnode", vp); #endif va->busy++; +

Re: give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2021.11.10 09:46:32 -0700: > Sebastien Marie wrote: > > > I just wonder about the system behaviour after building a new kernel > > and rebooting to build userland: RTP_PROPOSAL_SOLICIT is changed and > > kernel/userland will mismatch. > > > > But UMB

Re: UNIX sockets: use vnode(9) lock to protect `v_socket' dereference

2021-11-10 Thread Vitaliy Makkoveev
On Wed, Nov 10, 2021 at 10:03:48PM +0100, Alexander Bluhm wrote: > On Tue, Oct 26, 2021 at 02:12:36PM +0300, Vitaliy Makkoveev wrote: > > --- sys/kern/uipc_socket.c 14 Oct 2021 23:05:10 - 1.265 > > +++ sys/kern/uipc_socket.c 26 Oct 2021 11:05:59 - > > @@ -315,6 +315,8 @@

Re: Teach manpages of resolv(8) and unwindctl(8) about sppp(4)

2021-11-10 Thread Klemens Nanni
On Wed, Nov 10, 2021 at 04:28:10PM +0100, Bjorn Ketelaars wrote: > Like umb(4), sppp(4) is natively learning DNS information. Diff below > adds this information to the manpages of resolv(8) and unwindctl(8). > While here, also mention umb(4) in unwindctl's manpage. > > Thanks to kn@ for noticing

Re: UNIX sockets: use vnode(9) lock to protect `v_socket' dereference

2021-11-10 Thread Alexander Bluhm
On Tue, Oct 26, 2021 at 02:12:36PM +0300, Vitaliy Makkoveev wrote: > --- sys/kern/uipc_socket.c14 Oct 2021 23:05:10 - 1.265 > +++ sys/kern/uipc_socket.c26 Oct 2021 11:05:59 - > @@ -315,6 +315,8 @@ soclose(struct socket *so, int flags) > /* Revoke async IO early. There is

Re: obsolete()

2021-11-10 Thread Jan Stary
On Nov 10 19:10:59, h...@stare.cz wrote: > https://marc.info/?l=openbsd-tech=163389736000516=2 > > Not related to the original head -5 -n 6 discussion, > but a copy of obsolete() exists in usr.bin/join/ > (and seems to be the only instance, AFAIG). Ah, that one seems to be specific to the

obsolete()

2021-11-10 Thread Jan Stary
https://marc.info/?l=openbsd-tech=163389736000516=2 Not related to the original head -5 -n 6 discussion, but a copy of obsolete() exists in usr.bin/join/ (and seems to be the only instance, AFAIG). Jan

Re: locale in expr(1)

2021-11-10 Thread Jan Stary
On Nov 10 18:15:44, h...@stare.cz wrote: > expr(1) says > > expr1 {=, >, >=, <, <=, !=} expr2 > > Returns the results of integer comparison if both arguments > are decimal integers; otherwise, returns the results of > string comparison using the locale-specific collation

locale in expr(1)

2021-11-10 Thread Jan Stary
expr(1) says expr1 {=, >, >=, <, <=, !=} expr2 Returns the results of integer comparison if both arguments are decimal integers; otherwise, returns the results of string comparison using the locale-specific collation sequence. The result of each comparison is 1

Re: give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Theo de Raadt
Sebastien Marie wrote: > I just wonder about the system behaviour after building a new kernel > and rebooting to build userland: RTP_PROPOSAL_SOLICIT is changed and > kernel/userland will mismatch. > > But UMB proposal was done this way too (moving RTP_PROPOSAL_SOLICIT to > next id). So disturb

Re: extern int optind etc already declared in unistd.h

2021-11-10 Thread Todd C . Miller
On Wed, 10 Nov 2021 17:29:55 +0100, Jan Stary wrote: > With included, there is no need > to declare extern int optind and friends again. Right, most of this is old code that dates from before those were declared in unistd.h. OK millert@ - todd

extern int optind etc already declared in unistd.h

2021-11-10 Thread Jan Stary
With included, there is no need to declare extern int optind and friends again. Jan Index: usr.sbin/amd/amd/get_args.c === RCS file: /cvs/src/usr.sbin/amd/amd/get_args.c,v retrieving revision 1.15 diff -u -p -r1.15

Re: give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Bjorn Ketelaars
On Wed 10/11/2021 16:53, Sebastien Marie wrote: > On Wed, Nov 10, 2021 at 04:22:49PM +0100, Bjorn Ketelaars wrote: > > sppp(4) is currently using RTP_PROPOSAL_STATIC for sending DNS > > proposals, whereas all others sources, e.g. umb(4), are using a specific > > value. Diff below fixes this by

Re: give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Sebastien Marie
On Wed, Nov 10, 2021 at 04:22:49PM +0100, Bjorn Ketelaars wrote: > sppp(4) is currently using RTP_PROPOSAL_STATIC for sending DNS > proposals, whereas all others sources, e.g. umb(4), are using a specific > value. Diff below fixes this by adding RTP_PROPOSAL_PPP. > > Although the diff is limited

remove redundant pledge(2)s on who(1)

2021-11-10 Thread Ricardo Mestre
Hi, There's no need to call pledge(2) so many times, or on many places, with the same promises, just call it once before the switch case while at the same time hoisting one unveil(2) so they are all grouped. The call to pledge(2) on file() can also be simplified since "stdio rpath getpw" will

Teach manpages of resolv(8) and unwindctl(8) about sppp(4)

2021-11-10 Thread Bjorn Ketelaars
Like umb(4), sppp(4) is natively learning DNS information. Diff below adds this information to the manpages of resolv(8) and unwindctl(8). While here, also mention umb(4) in unwindctl's manpage. Thanks to kn@ for noticing the above. Comments/OK? diff --git sbin/resolvd/resolvd.8

give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Bjorn Ketelaars
sppp(4) is currently using RTP_PROPOSAL_STATIC for sending DNS proposals, whereas all others sources, e.g. umb(4), are using a specific value. Diff below fixes this by adding RTP_PROPOSAL_PPP. Although the diff is limited in size it touches several pieces: - sppp(4) - route(4) - route(8) -

Re: locale in who(1)

2021-11-10 Thread Ingo Schwarze
Hi, Martijn van Duren wrote on Wed, Nov 10, 2021 at 02:03:51PM +0100: > I see no reason to keep it. > OK martijn@ if anyone wants to commit this. Done. > On Wed, 2021-11-10 at 13:37 +0100, Jan Stary wrote: >> Why does who(1) need to setlocale()? On some systems, setlocale(LC_TIME) influences

Re: arm64: new gpiokeys(4)

2021-11-10 Thread Jan Stary
On Nov 10 13:20:45, k...@openbsd.org wrote: > On Wed, Nov 10, 2021 at 12:07:37AM +0100, Jan Stary wrote: > > On Nov 09 15:43:04, k...@openbsd.org wrote: > > > This populates `systat sensors' with the correct lid status on my > > > Pinebook Pro: > > > > > > -gpio-key-lid at mainbus0 not

Re: sppp(4)/pppoe(4) - DNS configuration via resolvd(8)

2021-11-10 Thread Klemens Nanni
On Wed, Nov 10, 2021 at 07:35:26AM +0100, Bjorn Ketelaars wrote: > On Mon 08/11/2021 11:52, Bjorn Ketelaars wrote: > > Diff below does two things: > > 1. add PPP IPCP extensions for name server addresses (rfc1877) to > >sppp(4) > > 2. propose negotiated name servers from sppp(4) to resolvd(8)

Re: arm64: new gpiokeys(4)

2021-11-10 Thread Klemens Nanni
On Wed, Nov 10, 2021 at 12:07:37AM +0100, Jan Stary wrote: > On Nov 09 15:43:04, k...@openbsd.org wrote: > > This populates `systat sensors' with the correct lid status on my > > Pinebook Pro: > > > > -gpio-key-lid at mainbus0 not configured > > -gpio-key-power at mainbus0 not configured

Re: locale in who(1)

2021-11-10 Thread Martijn van Duren
I see no reason to keep it. OK martijn@ if anyone wants to commit this. On Wed, 2021-11-10 at 13:37 +0100, Jan Stary wrote: > Why does who(1) need to setlocale()? > > Jan > > > Index: who.c > === > RCS file:

locale in who(1)

2021-11-10 Thread Jan Stary
Why does who(1) need to setlocale()? Jan Index: who.c === RCS file: /cvs/src/usr.bin/who/who.c,v retrieving revision 1.30 diff -u -p -r1.30 who.c --- who.c 12 Jul 2021 15:09:20 - 1.30 +++ who.c 10 Nov

Re: UNIX sockets: use vnode(9) lock to protect `v_socket' dereference

2021-11-10 Thread Vitaliy Makkoveev
Ping... On Thu, Nov 04, 2021 at 05:30:07PM +0300, Vitaliy Makkoveev wrote: > On Fri, Nov 05, 2021 at 08:31:07AM +0100, Martin Pieuchot wrote: > > On 26/10/21(Tue) 14:12, Vitaliy Makkoveev wrote: > > > Another step to make UNIX sockets locking fine grained. > > > > > > The listening socket has

Re: ipsec ip deliver

2021-11-10 Thread Vitaliy Makkoveev
On Tue, Nov 09, 2021 at 05:27:16PM +0100, Alexander Bluhm wrote: > On Tue, Nov 09, 2021 at 02:00:01PM +0100, Denis Fondras wrote: > > > @@ -352,19 +343,19 @@ ipsec_common_input(struct mbuf **mp, int > > >* Call appropriate transform and return -- callback takes care of > > >* everything

Re: relayd regress tcp performance

2021-11-10 Thread Alexander Bluhm
On Tue, Nov 09, 2021 at 07:13:13PM +, Stuart Henderson wrote: > What's the status of this diff? After discussion with jan@ we came to the conclusion that this fix is in the wrong layer. It is better to have a clever algorithm in TCP output to send window updates. jan@ is working on this.

Re: [PATCH] usr.sbin/ldapd: Match bind DN by suffix instead of complete DN.

2021-11-10 Thread Martijn van Duren
On Fri, 2021-10-15 at 06:13 +, Klemens Nanni wrote: > On Sun, Oct 03, 2021 at 10:05:56AM +, Klemens Nanni wrote: > > On Sat, Oct 02, 2021 at 07:03:21PM +0200, vifino wrote: > > > On Sat Oct 2, 2021 at 6:36 PM CEST, Raf Czlonka wrote: > > > > On Sat, Oct 02, 2021 at 02:15:53PM BST, vifino

Re: Faster unhibernate by skipping devices

2021-11-10 Thread Lucas
Since I'm using a snapshot with this, almost everytime I unhibernate I get a "false start": devices start to get enumerated and at one point, the machine reboots and goes back to the POST screen. Most of the time, the second time it boots normally. If it helps, most of the time there are around 8

Re: sppp(4)/pppoe(4) - DNS configuration via resolvd(8)

2021-11-10 Thread Claudio Jeker
On Wed, Nov 10, 2021 at 07:35:26AM +0100, Bjorn Ketelaars wrote: > On Mon 08/11/2021 11:52, Bjorn Ketelaars wrote: > > Diff below does two things: > > 1. add PPP IPCP extensions for name server addresses (rfc1877) to > >sppp(4) > > 2. propose negotiated name servers from sppp(4) to resolvd(8)

Re: sppp(4)/pppoe(4) - DNS configuration via resolvd(8)

2021-11-10 Thread Claudio Jeker
On Wed, Nov 10, 2021 at 08:22:52AM +0100, Sebastien Marie wrote: > On Wed, Nov 10, 2021 at 07:35:26AM +0100, Bjorn Ketelaars wrote: > > On Mon 08/11/2021 11:52, Bjorn Ketelaars wrote: > > > Diff below does two things: > > > 1. add PPP IPCP extensions for name server addresses (rfc1877) to > > >