Re: uhidppctl(8)

2021-12-22 Thread Raf Czlonka
On Wed, Dec 22, 2021 at 08:32:16AM GMT, Claudio Jeker wrote: > On Tue, Dec 21, 2021 at 03:49:47PM -0500, jwinnie@tilde.institute wrote: > > > > Hello OpenBSD developers, > > > > I am interested in contributing to improve the uhidpp(4) > > (Logitech Unifying Reciever) support in OpenBSD. > > > >

Re: uhidppctl(8)

2021-12-22 Thread Anton Lindqvist
On Tue, Dec 21, 2021 at 03:49:47PM -0500, jwinnie@tilde.institute wrote: > Hello OpenBSD developers, > > I am interested in contributing to improve the uhidpp(4) > (Logitech Unifying Reciever) support in OpenBSD. > > Currently, the uhidpp(4) driver only handles detecting certain > sensors, but I

Re: sysctl diskinit tailq foreach

2021-12-22 Thread Alexander Bluhm
On Tue, Dec 21, 2021 at 04:03:22PM +0100, Alexander Bluhm wrote: > I would like to use TAILQ_FOREACH to traverse the disk list. > Code is easier to read. Merged to -current. ok? bluhm Index: kern/kern_sysctl.c === RCS file:

Re: syzkaller vnd ioctl unlock

2021-12-22 Thread Jonathan Gray
On Wed, Dec 22, 2021 at 11:56:38PM +0100, Alexander Bluhm wrote: > Hi, > > syzkaller found a missing unlock in vnd ioctl error path. > > https://syzkaller.appspot.com/bug?id=b35a411a91f835fffb793df63aa8bcd7be99ad87 > > ok? ok jsg@ > > bluhm > > Index: dev/vnd.c >

syzkaller vnd ioctl unlock

2021-12-22 Thread Alexander Bluhm
Hi, syzkaller found a missing unlock in vnd ioctl error path. https://syzkaller.appspot.com/bug?id=b35a411a91f835fffb793df63aa8bcd7be99ad87 ok? bluhm Index: dev/vnd.c === RCS file: /data/mirror/openbsd/cvs/src/sys/dev/vnd.c,v

witness generic mp

2021-12-22 Thread Alexander Bluhm
Hi, Template for option WITNESS is in the architeture GENERIC.MP file if it is supported. It should not be in the global GENERIC config. ok? bluhm Index: conf/GENERIC === RCS file: /data/mirror/openbsd/cvs/src/sys/conf/GENERIC,v

Re: fix vmctl -B net -b bsd.rd to autoinstall

2021-12-22 Thread Dave Voutila
Claudio Jeker writes: > On Wed, Dec 22, 2021 at 10:14:40AM -0500, Dave Voutila wrote: >> >> Claudio Jeker writes: >> >> > I added support for vmctl -cL -B net -b bsd.rd -d disk.img to run the >> > autoinstall by emulating a PXE boot. In the commit >> >

Re: fix vmctl -B net -b bsd.rd to autoinstall

2021-12-22 Thread Claudio Jeker
On Wed, Dec 22, 2021 at 10:14:40AM -0500, Dave Voutila wrote: > > Claudio Jeker writes: > > > I added support for vmctl -cL -B net -b bsd.rd -d disk.img to run the > > autoinstall by emulating a PXE boot. In the commit > >

Re: boot stuck with latest cvs checkout

2021-12-22 Thread Alexander Bluhm
On Wed, Dec 22, 2021 at 05:20:02PM +0100, Hrvoje Popovski wrote: > On 22.12.2021. 17:07, Hrvoje Popovski wrote: > > i've sysupgrade box and reboot it and everything seems fine. then cvs > > checkout it, compile and then box stuck at boot > > > >>> OpenBSD/amd64 BOOT 3.53 > > boot> > > booting

Re: boot stuck with latest cvs checkout

2021-12-22 Thread Hrvoje Popovski
On 22.12.2021. 17:20, Hrvoje Popovski wrote: > On 22.12.2021. 17:07, Hrvoje Popovski wrote: >> Hi all, >> >> i've sysupgrade box and reboot it and everything seems fine. then cvs >> checkout it, compile and then box stuck at boot >> OpenBSD/amd64 BOOT 3.53 >> boot> >> booting hd0a:/bsd:

Re: boot stuck with latest cvs checkout

2021-12-22 Thread Hrvoje Popovski
On 22.12.2021. 17:07, Hrvoje Popovski wrote: > Hi all, > > i've sysupgrade box and reboot it and everything seems fine. then cvs > checkout it, compile and then box stuck at boot > >>> OpenBSD/amd64 BOOT 3.53 > boot> > booting hd0a:/bsd: 10246939+2425860+258068+0+1130496 >

Re: fix vmctl -B net -b bsd.rd to autoinstall

2021-12-22 Thread Dave Voutila
Claudio Jeker writes: > I added support for vmctl -cL -B net -b bsd.rd -d disk.img to run the > autoinstall by emulating a PXE boot. In the commit > https://github.com/openbsd/src/commit/a13de4d12a4c9ba0edc05aab2ad635f782449229 > the feature got removed over eagerly. > > This diff adds this

boot stuck with latest cvs checkout

2021-12-22 Thread Hrvoje Popovski
Hi all, i've sysupgrade box and reboot it and everything seems fine. then cvs checkout it, compile and then box stuck at boot >> OpenBSD/amd64 BOOT 3.53 boot> booting hd0a:/bsd: 10246939+2425860+258068+0+1130496 [97+573872+611580]=0xe8c924 entry point at 0xd0201000

malloc sleep in sysctl diskinit

2021-12-22 Thread Alexander Bluhm
Hi, syzkaller found a race in sysctl_diskinit(). https://syzkaller.appspot.com/bug?id=76838ab8f15c5f1bc22541c60c3c279314e13db0 While malloc sleeps, the disk list could change. Retry allocating enough space until it did not change. Not sure if this is the bug which syzkaller has found. But

Re: [External] : Re: make 'set skip on ...' dynamic

2021-12-22 Thread Claudio Jeker
On Sat, Dec 04, 2021 at 07:01:23PM +0100, Alexandr Nedvedicky wrote: > Hello, > > > On Fri, Dec 03, 2021 at 03:42:09PM +0100, Claudio Jeker wrote: > > > > See comments below. > > > > > > > +void > > > +pfi_group_delmember(const char *group, struct ifnet *ifp) > > > +{ > > > + struct pfi_kif

fix vmctl -B net -b bsd.rd to autoinstall

2021-12-22 Thread Claudio Jeker
I added support for vmctl -cL -B net -b bsd.rd -d disk.img to run the autoinstall by emulating a PXE boot. In the commit https://github.com/openbsd/src/commit/a13de4d12a4c9ba0edc05aab2ad635f782449229 the feature got removed over eagerly. This diff adds this back because I find this super

ipsec kernel lock

2021-12-22 Thread Alexander Bluhm
Hi, IPsec is not MP safe yet. To allow forwarding in parallel without dirty hacks, it is better to protect IPsec input and output with kernel lock. We do not loose much as crypto needs the kernel lock anyway. From here we can refine the lock later. Note that there is no kernel lock in the SPD

Re: rpki-client, stop using size_t for ids

2021-12-22 Thread Claudio Jeker
On Tue, Dec 21, 2021 at 06:24:44PM +, Job Snijders wrote: > On Tue, Dec 21, 2021 at 07:00:03PM +0100, Claudio Jeker wrote: > > For some reasons various ids were stored as size_t (probably because once > > they used to be the index in an array). This is just silly and annoyed me > > for long

Re: uhidppctl(8)

2021-12-22 Thread Claudio Jeker
On Tue, Dec 21, 2021 at 03:49:47PM -0500, jwinnie@tilde.institute wrote: > > Hello OpenBSD developers, > > I am interested in contributing to improve the uhidpp(4) > (Logitech Unifying Reciever) support in OpenBSD. > > Currently, the uhidpp(4) driver only handles detecting certain > sensors,