Re: ping icmp ident collisions

2022-02-20 Thread Jonathan Matthew
On Fri, Feb 18, 2022 at 04:03:28PM +0100, Florian Obser wrote: > On 2022-02-18 12:17 +10, Jonathan Matthew wrote: > > The only thing ping uses to determine whether a received icmp echo reply > > packet is a > > response to one of its requests is the 16 bit icmp ident field. If you > > ping

fw_update: improve 'kept' messaging

2022-02-20 Thread Andrew Hewus Fresh
One of the things on my TODO list has been to improve the "kept" messaging from fw_update. For example, deleting a firmware doesn't list what was kept and if you specified a firmware to install on the command-line the "kept" list only included the specified firmware. Instead, we only keep track

Re: Power-up cc --print-file-name for .so names

2022-02-20 Thread Theo de Raadt
Christian Weisgerber wrote: > Mark Kettenis: > > > There is a scenario where this goes wrong. If a shared library lacks > > a DT_SONAME entry, the library filename is used to generate the > > DT_NEEDED entries. But I would consider such a shared library broken > > and we fixed base a lng

Re: Power-up cc --print-file-name for .so names

2022-02-20 Thread Christian Weisgerber
Mark Kettenis: > There is a scenario where this goes wrong. If a shared library lacks > a DT_SONAME entry, the library filename is used to generate the > DT_NEEDED entries. But I would consider such a shared library broken > and we fixed base a lng time ago. Some care has to be taken when

Re: if_wg: Missing DPRINTF newline

2022-02-20 Thread Theo Buehler
On Sun, Feb 20, 2022 at 01:50:45PM -0600, Matthew Martin wrote: > On Thu, Feb 03, 2022 at 07:53:43AM +, Jason McIntyre wrote: > > On Wed, Feb 02, 2022 at 07:46:39PM -0600, Matthew Martin wrote: > > > Two DPRINTFs in sys/net/if_wg.c are missing a newline. > > > > > > > if this is committed,

Re: if_wg: Missing DPRINTF newline

2022-02-20 Thread Matthew Martin
On Thu, Feb 03, 2022 at 07:53:43AM +, Jason McIntyre wrote: > On Wed, Feb 02, 2022 at 07:46:39PM -0600, Matthew Martin wrote: > > Two DPRINTFs in sys/net/if_wg.c are missing a newline. > > > > if this is committed, the committer may also want to question the dodgy > capitals in "Delay

Re: Fix vi(1) - recovery is a lie

2022-02-20 Thread Theo Buehler
On Sun, Feb 20, 2022 at 01:38:21PM -0500, trondd wrote: > Vi(1) recovery is broken. At best, you lose your new work. At the worst > you can even lose saved work on disk. Pushing again to get something in > place to help the situation. > > I've been running this for a long time on amd64 and

Re: Fix vi(1) - recovery is a lie

2022-02-20 Thread trondd
Vi(1) recovery is broken. At best, you lose your new work. At the worst you can even lose saved work on disk. Pushing again to get something in place to help the situation. I've been running this for a long time on amd64 and arm64. Besides my testing, I've also experienced real power failures