Re: rpki-client: two missing checks for the SIA extension

On Mon, Apr 04, 2022 at 08:44:43PM +0200, Theo Buehler wrote: > p->res->mft and p->res->repo are populated in sbgp_sia_resouce_entry(). > Nothing guarantees that the resources are present. With our current > strstr() implementation we would let a cert with a missing mft through > while we would

rpki-client: two missing checks for the SIA extension

p->res->mft and p->res->repo are populated in sbgp_sia_resouce_entry(). Nothing guarantees that the resources are present. With our current strstr() implementation we would let a cert with a missing mft through while we would crash on a missing repo. Also, we don't check that the SIA extension

OpenBSD Errata: April 5, 2022 (syszlib)

Errata patches for zlib in the kernel have been released for OpenBSD 6.9 and 7.0. Binary updates for the amd64, i386 and arm64 platform are available via the syspatch utility. Source code patches can be found on the respective errata page: https://www.openbsd.org/errata69.html

wscons: const-ify font encoding tables

You'd think that the kernel font bitmaps are a primary example of data that could be read-only... and you'd be wrong. The font encoding tables however are indeed constant as far as I can tell. The diff below marks them as such. NetBSD has the same. ok? diff

Re: rpki-client remove another outdated comment

On Mon, Apr 04, 2022 at 03:35:39PM +0200, Claudio Jeker wrote: > This was fixed in January. Now RRDP issues an RRDP_CLEAR to the parent > which in turns removes all files from the .rrdp cache dir. ok

Re: rpki-client simplify rsync.c

On Mon, Apr 04, 2022 at 03:06:29PM +0200, Claudio Jeker wrote: > Kill a FIXME and simplify the logic around the process list by using a > static ids array on the stack. > > Tested with and without -R. ok

rpki-client remove another outdated comment

This was fixed in January. Now RRDP issues an RRDP_CLEAR to the parent which in turns removes all files from the .rrdp cache dir. -- :wq Claudio Index: rrdp.c === RCS file: /cvs/src/usr.sbin/rpki-client/rrdp.c,v retrieving revision

rpki-client simplify rsync.c

Kill a FIXME and simplify the logic around the process list by using a static ids array on the stack. Tested with and without -R. -- :wq Claudio Index: rsync.c === RCS file: /cvs/src/usr.sbin/rpki-client/rsync.c,v retrieving

Re: rpki-client: remove a stale FIXME

On Mon, Apr 04, 2022 at 01:33:18PM +0200, Theo Buehler wrote: > We fixed this back in January when we added rtype_from_mftfile(). > > Index: main.c > === > RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v > retrieving revision 1.190

Re: rpki-client cache cleanup change

On Mon, Apr 04, 2022 at 12:49:51PM +0200, Claudio Jeker wrote: > This diff alters the way rpki-client cleans up the cache directory. > While with rsync any file can be removed and on the next run it will be > fetched again RRDP has no such logic. It is a very fragile protocol and > only works if

rpki-client: remove a stale FIXME

We fixed this back in January when we added rtype_from_mftfile(). Index: main.c === RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v retrieving revision 1.190 diff -u -p -r1.190 main.c --- main.c 2 Apr 2022 12:17:53 -

rpki-client cache cleanup change

This diff alters the way rpki-client cleans up the cache directory. While with rsync any file can be removed and on the next run it will be fetched again RRDP has no such logic. It is a very fragile protocol and only works if files are not removed by something else. Until now files are just