Re: refcount btrace

2022-04-12 Thread Alexander Bluhm
On Mon, Apr 11, 2022 at 07:19:00PM +0200, Martin Pieuchot wrote: > On 08/04/22(Fri) 12:16, Alexander Bluhm wrote: > > On Fri, Apr 08, 2022 at 02:39:34AM +, Visa Hankala wrote: > > > On Thu, Apr 07, 2022 at 07:55:11PM +0200, Alexander Bluhm wrote: > > > > On Wed, Mar 23, 2022 at 06:13:27PM

Re: Kill selrecord()

2022-04-12 Thread Theo de Raadt
I don't think this is the right time to rush and commit big diffs which noone can actively test, not even build on all architectures, because there are no snapshots being built, because the tree is semi-frozen to make a release. visa is right. Visa Hankala wrote: > On Mon, Apr 11, 2022 at

Re: vfs: document (and correct) the protection required for manipulating v_numoutput

2022-04-12 Thread Visa Hankala
On Sun, Mar 27, 2022 at 03:36:20PM +0200, Sebastien Marie wrote: > v_numoutput is a struct member of vnode which is used to keep track the > number > of writes in progress. > > in several function comments, it is marked as "Manipulates v_numoutput. Must > be > called at splbio()". > > So I

Re: Kill selrecord()

2022-04-12 Thread Visa Hankala
On Mon, Apr 11, 2022 at 07:14:46PM +0200, Martin Pieuchot wrote: > Now that poll(2) & select(2) use the kqueue backend under the hood we > can start retiring the old machinery. > > The diff below does not touch driver definitions, however it : > > - kills selrecord() & doselwakeup() > > - make

fix openrsync on big endian archs

2022-04-12 Thread Claudio Jeker
Hit this on sparc64. io_read_ulong() calls io_read_int() which already does the le32toh() call. So skip the 2nd le32toh() call here. With this openrsync works a lot better. -- :wq Claudio Index: io.c === RCS file:

Re: vfs: document (and correct) the protection required for manipulating v_numoutput

2022-04-12 Thread Sebastien Marie
On Sun, Mar 27, 2022 at 03:36:20PM +0200, Sebastien Marie wrote: > Hi, > > v_numoutput is a struct member of vnode which is used to keep track the > number > of writes in progress. > > in several function comments, it is marked as "Manipulates v_numoutput. Must > be > called at splbio()". >

rpki-client: move sbgp_sia() to a better place

2022-04-12 Thread Theo Buehler
This only moves sbgp_sia() a bit down between the code handling the NID_sbgp_ipAddrBlock and the NID_certificate_policies extensions. Surely this is better than to stick it between some random helper functions for sbgp_ipaddrblk() and sbgp_assysnum(). Index: cert.c

Re: rpki-client: reuse URI location code for AIAs and CRLs

2022-04-12 Thread Claudio Jeker
On Tue, Apr 12, 2022 at 09:58:21AM +0200, Theo Buehler wrote: > We can generalize sbgp_sia_location() and reuse it for AIAs and CRLs. > This makes the checks a bit more stringent, which seems to be fine in > practice. It also ensures that there are no embedded NULs which came > up recently. One

rpki-client: reuse URI location code for AIAs and CRLs

2022-04-12 Thread Theo Buehler
We can generalize sbgp_sia_location() and reuse it for AIAs and CRLs. This makes the checks a bit more stringent, which seems to be fine in practice. It also ensures that there are no embedded NULs which came up recently. One thing I'm not sure about is that valid_uri() refuses URIs with "/."