Mark pw_error __dead in util.h

The function is already marked __dead in passwd.c, so appears to just be an oversight. diff --git util.h util.h index dd64f478e23..752f8bb9fc5 100644 --- util.h +++ util.h @@ -97,7 +97,7 @@ void pw_edit(int, const char *); void pw_prompt(void); void pw_copy(int, int, const struct passwd *,

ratecheck mutex

Hi, We have one comment that locking for ratecheck(9) is missing. In all other places locking status of the struct timeval *lasttime is unclear. The easiest fix is a global mutex for all lasttime in ratecheck(). This covers the usual usecase of the function. Same for ppsratecheck(9), lasttime

Re: another syzkaller problem in pf

On Tue, May 03, 2022 at 07:42:34PM +0200, Moritz Buhl wrote: > commit 4b3977248902c22d96aaebdb5784840debc2631c > Author: mikeb > Date: Mon Nov 24 13:22:09 2008 + > > Fix splasserts seen in pr 5987 by propagating a flag that discribes > whether we're called from the interrupt

Re: another syzkaller problem in pf

On 2022-05-03, Moritz Buhl wrote: > Hi tech@, > > Syzkaller found a few crashes in pf_anchor_global_RB_REMOVE. > https://syzkaller.appspot.com/bug?id=a97f712331903ce38b8c084a489818b9bb5c6fcb > and also > https://syzkaller.appspot.com/text?tag=CrashLog=15ace9aaf0 > > The call stack is

Re: aml parse error

On Tue, May 03, 2022 at 04:46:55PM +0200, aphekz wrote: > On Mon, May 02, 2022 at 07:05:24PM -0700, Mike Larkin wrote: > > On Mon, May 02, 2022 at 11:42:57PM +0200, aphekz wrote: > > > > > > May 2 21:29:06 dev /bsd: ### AML PARSE ERROR (0x8f3a): Undefined name: > > > OPST > > > May 2 21:29:06

another syzkaller problem in pf

Hi tech@, Syzkaller found a few crashes in pf_anchor_global_RB_REMOVE. https://syzkaller.appspot.com/bug?id=a97f712331903ce38b8c084a489818b9bb5c6fcb and also https://syzkaller.appspot.com/text?tag=CrashLog=15ace9aaf0 The call stack is something like this: pf_anchor_global_RB_REMOVE

Re: acme-client: check token names

On 2022-05-03 17:41 +0430, Ali Farzanrad wrote: > > Hi Florian, > > Yes, I read the RFC, it should work, but I couldn't test it yet, because > my domain manager is a little lazy (I've registeret 2 subdomains for my > domain, but it is not listed in name servers yet). I'll probably test > it

[PATCH] smtpd: always use an enhanced status code

A server that supports enhanced status codes must use them for all replies. --- usr.sbin/smtpd/bounce.c | 2 +- usr.sbin/smtpd/lka_session.c | 4 ++-- usr.sbin/smtpd/smtp_session.c | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git usr.sbin/smtpd/bounce.c

Re: rttimer move callback to the queue struct

On Tue, May 03, 2022 at 11:30:13AM +0200, Claudio Jeker wrote: > Next stage of rttimer cleanup. Move the callback from the rttimer to the > rttimer_queue struct. The callback is always the same for a queue so there > is no need to define it on every call. > > On top of that replace

Re: acme-client: check token names

Florian Obser wrote: > On 2022-05-02 03:04 +0430, Ali Farzanrad wrote: > > Hi tech@, > > > > I know that acme-client is unveiled properly, but isn't it better to > > check token names? > > Nice catch, the token is untrusted input. > We should validate this differently though. > > RFC 8555, 8.5

Re: [External] : Re: add sanity checks to IGMP/MLD

On Tue, May 03, 2022 at 02:12:36PM +0200, Claudio Jeker wrote: > On Tue, May 03, 2022 at 02:08:33PM +0200, Alexandr Nedvedicky wrote: > > Hello > > > > On Tue, May 03, 2022 at 10:44:48AM +0200, Claudio Jeker wrote: > > > > > > > > The RFC does not use the usual MUST to enforce any of this. > >

Re: [External] : Re: add sanity checks to IGMP/MLD

On Tue, May 03, 2022 at 02:08:33PM +0200, Alexandr Nedvedicky wrote: > Hello > > On Tue, May 03, 2022 at 10:44:48AM +0200, Claudio Jeker wrote: > > > > > The RFC does not use the usual MUST to enforce any of this. > > So yes, we should probably not be too strict because there is no way to > >

Re: [External] : Re: add sanity checks to IGMP/MLD

Hello On Tue, May 03, 2022 at 10:44:48AM +0200, Claudio Jeker wrote: > > The RFC does not use the usual MUST to enforce any of this. > So yes, we should probably not be too strict because there is no way to > force accept the packet when pf_walk_header() returns PF_DROP. > > I agree that the

Re: acme-client: check token names

On 2022-05-02 03:04 +0430, Ali Farzanrad wrote: > Hi tech@, > > I know that acme-client is unveiled properly, but isn't it better to > check token names? Nice catch, the token is untrusted input. We should validate this differently though. RFC 8555, 8.5 HTTP Challenge: token (required,

rttimer move callback to the queue struct

Next stage of rttimer cleanup. Move the callback from the rttimer to the rttimer_queue struct. The callback is always the same for a queue so there is no need to define it on every call. On top of that replace rt_timer_queue_destroy() with rt_timer_queue_flush(). With this queues can no longer be

Re: add sanity checks to IGMP/MLD

On Tue, May 03, 2022 at 12:05:06AM +0200, Alexander Bluhm wrote: > On Mon, May 02, 2022 at 11:30:58PM +0200, Alexandr Nedvedicky wrote: > > hello, > > > > bluhm@ has committed a fix [1] which makes pf to accept IGMP/MLD messages. > > If I remember correct pf(4) was dropping those messages because

Re: [External] : Re: add sanity checks to IGMP/MLD

On Tue, May 03, 2022 at 10:10:23AM +0200, Alexandr Nedvedicky wrote: > updated diff is below. > thanks for taking a look at it. OK bluhm@ > 8<---8<---8<--8< > diff --git a/sys/net/pf.c b/sys/net/pf.c > index f15e1ead8c0..bf9593952ec 100644

Re: [External] : Re: add sanity checks to IGMP/MLD

Hello, On Tue, May 03, 2022 at 09:19:44AM +0200, Alexander Bluhm wrote: > On Tue, May 03, 2022 at 12:26:52AM +0200, Alexandr Nedvedicky wrote: > > OK ? or should I also drop a check for link-local source address > > in IPv6? > > The link-local check makes sense. > > > +

Re: wsmouse(4): tapping

... and this is the complete link: https://marc.info/?l=openbsd-tech=165006255922269=2 On 5/3/22 10:03, Ulf Brosziewski wrote: > The implementation of the tapping mechanism in wsmouse(4) has a bug > concerning the transitions into the hold/drag state, see > https://marc.info/... > for

wsmouse(4): tapping

The implementation of the tapping mechanism in wsmouse(4) has a bug concerning the transitions into the hold/drag state, see https://marc.info/... for details. The patch proposed in that message is obsolete. I've been made aware that there is another problem, the transition only works with

Re: [External] : Re: add sanity checks to IGMP/MLD

On Tue, May 03, 2022 at 12:26:52AM +0200, Alexandr Nedvedicky wrote: > OK ? or should I also drop a check for link-local source address > in IPv6? The link-local check makes sense. > 8<---8<---8<--8< > diff --git a/sys/net/pf.c

Re: kstat(1): implement wait with setitimer(2)

On Mon, May 02, 2022 at 08:39:07PM -0500, Scott Cheloha wrote: > On Sat, Apr 30, 2022 at 01:27:44AM +0200, Alexander Bluhm wrote: > > otherwise diff looks good to me > > Still look good? OK bluhm@ > Index: kstat.c > === > RCS file: