[v5] amd64: simplify TSC sync testing

2022-07-30 Thread Scott Cheloha
Hi, At the urging of sthen@ and dv@, here is v5. Two major changes from v4: - Add the function tc_reset_quality() to kern_tc.c and use it to lower the quality of the TSC timecounter if we fail the sync test. tc_reset_quality() will choose a new active timecounter if, after the quality

Re: echo(1): check for stdio errors

2022-07-30 Thread Todd C . Miller
On Sat, 30 Jul 2022 18:19:02 -0500, Scott Cheloha wrote: > Bump. The standard's error cases for fflush(3) are identical to those > for fclose(3): > > https://pubs.opengroup.org/onlinepubs/9699919799/functions/fflush.html > https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html >

Re: echo(1): check for stdio errors

2022-07-30 Thread Scott Cheloha
On Mon, Jul 11, 2022 at 01:27:23PM -0500, Scott Cheloha wrote: > On Mon, Jul 11, 2022 at 08:31:04AM -0600, Todd C. Miller wrote: > > On Sun, 10 Jul 2022 20:58:35 -0900, Philip Guenther wrote: > > > > > Three thoughts: > > > 1) Since stdio errors are sticky, is there any real advantage to checking

Re: Consistency and cleanup in /share/misc/airport

2022-07-30 Thread Stuart Henderson
On 2022/07/30 22:34, Thomas Wager wrote: > On Fri, 2022-07-29 at 16:09 -0400, Daniel Dickman wrote: > > > I think they’re called Metropolitan Area Airport Codes: > > > > I found a list here: > > Metropolitan Area Airport Codes > > wikitravel.org > > > > > > Do you want to submit a revised

Re: Consistency and cleanup in /share/misc/airport

2022-07-30 Thread Thomas Wager
On Fri, 2022-07-29 at 16:09 -0400, Daniel Dickman wrote: > I think they’re called Metropolitan Area Airport Codes: > > I found a list here: > Metropolitan Area Airport Codes > wikitravel.org > > > Do you want to submit a revised patch with all the corrections? > Thanks, I double checked with

Re: interface media without netlock

2022-07-30 Thread Mark Kettenis
> Date: Thu, 28 Jul 2022 13:30:12 +0200 > From: Alexander Bluhm > > Hi, > > The netlock for SIOCSIFMEDIA and SIOCGIFMEDIA ioctl is not necessary. > Legacy drivers run with kernel lock, interface media is MP safe or > has kernel lock. > > ixl(4) talks about net lock but in fact has kernel lock.

Re: interface media current data

2022-07-30 Thread Mark Kettenis
> Date: Sat, 30 Jul 2022 18:45:39 +0300 > From: Vitaliy Makkoveev > > On Wed, Jul 27, 2022 at 08:53:38PM +0200, Mark Kettenis wrote: > > > Date: Wed, 27 Jul 2022 00:11:19 +0200 > > > From: Alexander Bluhm > > > > > > On Tue, Jul 26, 2022 at 11:19:27PM +0200, Mark Kettenis wrote: > > > > >

Re: interface media current data

2022-07-30 Thread Vitaliy Makkoveev
On Wed, Jul 27, 2022 at 08:53:38PM +0200, Mark Kettenis wrote: > > Date: Wed, 27 Jul 2022 00:11:19 +0200 > > From: Alexander Bluhm > > > > On Tue, Jul 26, 2022 at 11:19:27PM +0200, Mark Kettenis wrote: > > > > Date: Tue, 26 Jul 2022 18:11:01 +0200 > > > > From: Alexander Bluhm > > > > > > > >

Re: vmctl create: accept exactly one file

2022-07-30 Thread Dave Voutila
Klemens Nanni writes: > Do not silently ignore additional arguments: > > $ vmctl create > usage: vmctl [-v] create [-b base | -i disk] [-s size] disk > $ vmctl create -s 1G 1.img 2.img > vmctl: raw imagefile created > $ ls *.img > 1.img > > $

Re: randomise arc4random() rekey interval

2022-07-30 Thread Visa Hankala
On Sat, Jul 30, 2022 at 06:40:21PM +1000, Damien Miller wrote: > On Fri, 29 Jul 2022, Theo de Raadt wrote: > > > The question is what _rs_random_u32() will do when it calls > > _rs_stir_if_needed(). > > > > There is one potential problem. lib/libcrypto/arc4random/*.h contains > > portable

Re: randomise arc4random() rekey interval

2022-07-30 Thread Damien Miller
On Fri, 29 Jul 2022, Theo de Raadt wrote: > The question is what _rs_random_u32() will do when it calls > _rs_stir_if_needed(). > > There is one potential problem. lib/libcrypto/arc4random/*.h contains > portable wrappers for _rs_forkdetect(), which actually do things. > memset(rs, 0,

Re: inteldrm: fix build without intagp

2022-07-30 Thread Jonathan Gray
On Sat, Jul 30, 2022 at 07:51:07AM +, Klemens Nanni wrote: > Pull inteldrm_refcnt out of NINTAGP > 0, otherwise it remains undefined but > still used in inteldrm_attachhook(): > > if (inteldrm_refcnt == 0) { > i915_init(); > } > inteldrm_refcnt++; > > OK? ok

inteldrm: fix build without intagp

2022-07-30 Thread Klemens Nanni
Pull inteldrm_refcnt out of NINTAGP > 0, otherwise it remains undefined but still used in inteldrm_attachhook(): if (inteldrm_refcnt == 0) { i915_init(); } inteldrm_refcnt++; OK? Index: sys/dev/pci/drm/i915/i915_drv.c

vmctl create: accept exactly one file

2022-07-30 Thread Klemens Nanni
Do not silently ignore additional arguments: $ vmctl create usage: vmctl [-v] create [-b base | -i disk] [-s size] disk $ vmctl create -s 1G 1.img 2.img vmctl: raw imagefile created $ ls *.img 1.img $ ./obj/vmctl create -s 1G 1.qcow2

bioctl.8: noauto flag has no effect in bootloaders

2022-07-30 Thread Klemens Nanni
Reading "at boot time" may come off as "in the bootloader", which seems plausible since we support booting off root on softraid and at leat one platform automatically assembles all available softraid volumes in the bootloader, whether they contain the boot disk or not. But all currently supported