remove cpu var from i386

2022-08-20 Thread Jonathan Gray
removed from amd64 in locore.S 1.71 in 2015 the cpuid_level == -1 path can go in a later step diff --git sys/arch/amd64/include/cpu.h sys/arch/amd64/include/cpu.h index b8db48f2714..d8b7bc61ede 100644 --- sys/arch/amd64/include/cpu.h +++ sys/arch/amd64/include/cpu.h @@ -369,7 +369,6 @@ struct

USB string descriptor requests

2022-08-20 Thread bug
I got a StarTech SV431USBDDM KVM switch, and it specifically mangles the string descriptor responses for my keyboard (which otherwise works just fine) when probed about the vendor string after plugging in or resetting the device. After a ton of messing around, I also found out that this problem

Re: Consistency and cleanup in /share/misc/airport

2022-08-20 Thread Daniel Dickman
I've committed the updates for the German airports but left the metropolitan area airports alone. Thanks!

Re: improve transmeta pci device names

2022-08-20 Thread Jonathan Gray
On Sat, Aug 20, 2022 at 09:52:15PM -0400, Daniel Dickman wrote: > On Sat, Aug 20, 2022 at 9:50 PM Jonathan Gray wrote: > > why not just > > > > product TRANSMETA SDRAM 0x0396 SDRAM > > product TRANSMETA BIOS 0x0397 BIOS > > > That works too. ok jsg@ for that version

Re: improve transmeta pci device names

2022-08-20 Thread Daniel Dickman
On Sat, Aug 20, 2022 at 9:50 PM Jonathan Gray wrote: > why not just > > product TRANSMETA SDRAM 0x0396 SDRAM > product TRANSMETA BIOS 0x0397 BIOS That works too.

Re: improve transmeta pci device names

2022-08-20 Thread Jonathan Gray
On Sat, Aug 20, 2022 at 09:04:23PM -0400, Daniel Dickman wrote: > We have some generic PCI devices names: > > product TRANSMETA MEM1 0x0396 Mem1 > product TRANSMETA MEM2 0x0397 Mem2 > > Likely because these devices both appear as class=5 and subclass=0 (which > indicates a RAM

improve transmeta pci device names

2022-08-20 Thread Daniel Dickman
We have some generic PCI devices names: product TRANSMETA MEM1 0x0396 Mem1 product TRANSMETA MEM2 0x0397 Mem2 Likely because these devices both appear as class=5 and subclass=0 (which indicates a RAM device): # pcidump -v ... 0:0:1: Transmeta Mem1 0x: Vendor ID:

Re: regress: vmd: disable on i386

2022-08-20 Thread Dave Voutila
Klemens Nanni writes: > vmd/Makefile filters for amd64 itself but still, no need to enter > on !amd64. > ok dv@. > Index: ../Makefile > === > RCS file: /cvs/src/regress/usr.sbin/Makefile,v > retrieving revision 1.26 > diff -u -p

Change soabort() return type to void

2022-08-20 Thread Vitaliy Makkoveev
We never interesting soabort() return value. I don't see any reason to change pru_abort() return type right now, because it calls (*pru_usrreq)() within. I'll modify it with the upcoming PRU_ABORT split. Index: sys/kern/uipc_socket.c

Re: pcb mutex for divert input

2022-08-20 Thread Vitaliy Makkoveev
> On 21 Aug 2022, at 00:31, Alexander Bluhm wrote: > > Hi, > > A inpcb mutex seems usable to serialize access to socket receive > buffer. I have tried it for divert and udp input. > > As first step I would like to replace the kernel lock with a per > PCB mutex in divert input. > > ok? > ok

pcb mutex for divert input

2022-08-20 Thread Alexander Bluhm
Hi, A inpcb mutex seems usable to serialize access to socket receive buffer. I have tried it for divert and udp input. As first step I would like to replace the kernel lock with a per PCB mutex in divert input. ok? bluhm Index: netinet/in_pcb.c

Re: ifconfig, wireguard output less verbose, unless -A or

2022-08-20 Thread Jason McIntyre
On Sat, Aug 20, 2022 at 02:25:25PM +0100, Stuart Henderson wrote: > > > > Long output with as an argument, wgpeers section present: > > > > pce-0067# ifconfig.ifaliases wg0 > > wg0: flags=80c3 mtu 1420 > > index 8 priority 0 llprio 3 > > wgport 51820 > > wgpubkey qcb...

Re: regress: installboot: add initial tests, don't hook up yet

2022-08-20 Thread Klemens Nanni
On Sat, Aug 20, 2022 at 09:26:03AM +, Klemens Nanni wrote: > installboot is not trivial, especially when it comes to the matrix of > platforms, softraid softraid support and boot loader filesystem support. > > It is especially annoying to run into issues in the installer where > debugging

Re: move PRU_BIND request to (*pru_bind)() handler

2022-08-20 Thread Alexander Bluhm
On Sat, Aug 20, 2022 at 05:56:51PM +0300, Vitaliy Makkoveev wrote: > We have 15 PRU_ requests to split. Is the one request per diff fine? Yes. OK bluhm@ > Index: sys/kern/uipc_usrreq.c > === > RCS file:

Re: move PRU_BIND request to (*pru_bind)() handler

2022-08-20 Thread Vitaliy Makkoveev
On Sat, Aug 20, 2022 at 03:49:08PM +0200, Alexander Bluhm wrote: > On Fri, Aug 19, 2022 at 04:28:24PM -0900, Philip Guenther wrote: > > On Fri, Aug 19, 2022 at 12:42 PM Vitaliy Makkoveev wrote: > > > > > bluhm@ pointed, that many KASSERT()s are not welcomed, so I didn't > > > insert them into

Re: move PRU_BIND request to (*pru_bind)() handler

2022-08-20 Thread Alexander Bluhm
On Fri, Aug 19, 2022 at 04:28:24PM -0900, Philip Guenther wrote: > On Fri, Aug 19, 2022 at 12:42 PM Vitaliy Makkoveev wrote: > > > bluhm@ pointed, that many KASSERT()s are not welcomed, so I didn't > > insert them into newly introduced handlers. Anyway except the tcp(4) > > protocol, `so_pcb'

Re: ifconfig, wireguard output less verbose, unless -A or

2022-08-20 Thread Stuart Henderson
On 2022/07/14 09:37, Mikolaj Kucharski wrote: > Hi, > > Per other thread, Theo expressed dissatisfaction with long ifconfig(8) > for wg(4) interface. Stuart Henderson pointed me at direction, which > below diff makes it work. > > I guess to questions are: > > - Does the behaviour of ifconfig(8)

refactor pcb lookup

2022-08-20 Thread Alexander Bluhm
Hi, Can we rename the the function in_pcbhashlookup() to in_pcblookup()? Then we have in_pcblookup() and in_pcblookup_listen() as public PCB interface. Using a hash table is only an implementation detail. For internal use I would like to introduce in_pcbhash_insert() and in_pcbhash_lookup() to

Re: random(6): undefined cast and error checking

2022-08-20 Thread Theo Buehler
On Fri, Aug 05, 2022 at 10:55:23PM +0200, Theo Buehler wrote: > On Fri, Aug 05, 2022 at 02:12:35PM -0500, luci...@bronze.ctrl-c.club wrote: > > So this is the final verison of the patch solving the following > > problems: > > > > >The program is broken in multiple ways: return value clamping,

Re: remove support for Cyrix 486DLC & Cyrix 6x86

2022-08-20 Thread Jonathan Gray
On Fri, Aug 19, 2022 at 10:31:30PM -0400, Daniel Dickman wrote: > The below diff removes detection code for the Cyrix 486DLC and Cyrix 6x86 > CPUs from OpenBSD/i386. > > The Cyrix 486DLC is a 486-class CPU which we no longer support. > > The 6x86, also known as the M1, does not support CPUID by

regress: installboot: add initial tests, don't hook up yet

2022-08-20 Thread Klemens Nanni
installboot is not trivial, especially when it comes to the matrix of platforms, softraid softraid support and boot loader filesystem support. It is especially annoying to run into issues in the installer where debugging capabilities are limited -- I've had that with softraid on sparc64 where the

regress: vmd: disable on i386

2022-08-20 Thread Klemens Nanni
vmd/Makefile filters for amd64 itself but still, no need to enter on !amd64. Index: ../Makefile === RCS file: /cvs/src/regress/usr.sbin/Makefile,v retrieving revision 1.26 diff -u -p -r1.26 Makefile --- ../Makefile 11 Nov 2021

installboot: fix argc check to prevent installing w/o disk

2022-08-20 Thread Klemens Nanni
Just forgot to pass the disk during sparc64 tests and was surprised to see it treating a file as disk: # installboot -nv /usr/mdec/bootblk /ofwboot.test Using / as root would install bootstrap on ./usr/mdec/bootblk using first-stage ./ofwboot.test, second-stage