Re: move PRU_CONTROL request to (*pru_control)()

2022-09-01 Thread Philip Guenther
Yes, splitting {tcp,udp}_usrreqs and {tcp,udp}6_usrreqs is clearly the Right Thing. ok guenther@ Unrelated to this specific callback, but I think you should consider splitting out uipc_dgram_usrreqs out from uipc_usrreqs, as the SOCK_DGRAM case differs from the other two for multiple callbacks.

sparc64: ofwboot: support booting from softraid 1C

2022-09-01 Thread Klemens Nanni
This is practically the same diff we already landed for arm64. The kernel already supports booting off 1C and with tech@'s "installboot: sparc64: fix -r on multi-chunk softraid chunk" diff the install process will no longer fail when installing bootstraps onto any softraid volume which requires

installboot: sparc64: fix -r on multi-chunk softraid chunk

2022-09-01 Thread Klemens Nanni
Running installboot(8) on softraid(4) volumes means installing stages on every softraid chunk. The overall idea is the same, but MD implementations differ. sparc64_softraid.c's sr_install_bootblk() reuses sparc64_installboot.c's md_installboot() for this. For sparc64, md_installboot() does the

Re: protocol attach wait

2022-09-01 Thread Vitaliy Makkoveev
On Thu, Sep 01, 2022 at 10:58:49PM +0300, Vitaliy Makkoveev wrote: > On Thu, Sep 01, 2022 at 09:00:50PM +0200, Alexander Bluhm wrote: > > On Mon, Aug 15, 2022 at 05:12:22PM +0200, Alexander Bluhm wrote: > > > System calls should not fail due to temporary memory shortage in > > > malloc(9) or

Re: protocol attach wait

2022-09-01 Thread Vitaliy Makkoveev
On Thu, Sep 01, 2022 at 09:00:50PM +0200, Alexander Bluhm wrote: > On Mon, Aug 15, 2022 at 05:12:22PM +0200, Alexander Bluhm wrote: > > System calls should not fail due to temporary memory shortage in > > malloc(9) or pool_get(9). > > > > Pass down a wait flag to pru_attach(). During syscall

move PRU_CONTROL request to (*pru_control)()

2022-09-01 Thread Vitaliy Makkoveev
The 'proc *' is not used for PRU_CONTROL request, so remove it from pru_control() wrapper. I want to use existing in{6,}_control for tcp(4) and udp(4) sockets, so for inet6 case I introduced `tcp6_usrreqs' and `udp6_usrreqs' structures. I also want to use them for the following PRU_SOCKADDR and

Re: httpd: overwrite rather than error for duplicate type entries

2022-09-01 Thread Florian Obser
Pretty sure this doesn't compile. If it were to compile it would leak memory. On 1 September 2022 20:32:55 CEST, Ben Fuller wrote: >Hi, > >In my httpd.conf, I include /usr/share/misc/mime.types but also want to >define a few of my own type rules: in particular, I wanted to use > >

Re: protocol attach wait

2022-09-01 Thread Alexander Bluhm
On Mon, Aug 15, 2022 at 05:12:22PM +0200, Alexander Bluhm wrote: > System calls should not fail due to temporary memory shortage in > malloc(9) or pool_get(9). > > Pass down a wait flag to pru_attach(). During syscall socket(2) > it is ok to wait, this logic was missing for internet pcb. Pfkey

Re: printcap.5: Fix phototypesetter name

2022-09-01 Thread Jason McIntyre
On Wed, Aug 31, 2022 at 10:57:21AM -0400, Josiah Frentsos wrote: > Index: printcap.5 > === > RCS file: /cvs/src/share/man/man5/printcap.5,v > retrieving revision 1.28 > diff -u -p -r1.28 printcap.5 > --- printcap.510 Feb 2020

Re: move PRU_CONNECT2 request to (*pru_connect2)()

2022-09-01 Thread Alexander Bluhm
On Thu, Sep 01, 2022 at 08:42:33PM +0300, Vitaliy Makkoveev wrote: > Well, let's be conservative. The `unp2' assignment restored to it's > original place. OK bluhm@ > Index: sys/kern/uipc_usrreq.c > === > RCS file:

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Sebastian Benoit
Job Snijders(j...@openbsd.org) on 2022.09.01 03:37:59 +: > Dear all, > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > ASCII art parent/child process relationships are grouped and displayed. > Here is an example: > > $ ps ad -O ppid,user > PID PPID USER

Re: move PRU_CONNECT2 request to (*pru_connect2)()

2022-09-01 Thread Vitaliy Makkoveev
On Thu, Sep 01, 2022 at 05:59:44PM +0200, Alexander Bluhm wrote: > On Thu, Sep 01, 2022 at 01:27:18AM +0300, Vitaliy Makkoveev wrote: > > +int > > +uipc_connect2(struct socket *so, struct socket *so2) > > +{ > > + struct unpcb *unp = sotounpcb(so), *unp2 = sotounpcb(so2); > > + int error; > >

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Job Snijders
On Thu, Sep 01, 2022 at 06:14:17PM +0200, Florian Obser wrote: > >> NetBSD's and FreeBSD's ps(1) use '-d' to display process hierarchy. > > > > using -f would follow the path of least resistance. Is there really a > > common > > user commnity between freebsd netbsd and openbsd? I doubt it. > >

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Theo de Raadt
Florian Obser wrote: > On 2022-09-01 09:55 -06, "Theo de Raadt" wrote: > > Job Snijders wrote: > > > >> On Thu, Sep 01, 2022 at 03:14:40PM +0200, Martin Schröder wrote: > >> > Am Do., 1. Sept. 2022 um 05:38 Uhr schrieb Job Snijders > >> > : > >> > > Some ps(1) implementations have an '-d'

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Florian Obser
On 2022-09-01 09:55 -06, "Theo de Raadt" wrote: > Job Snijders wrote: > >> On Thu, Sep 01, 2022 at 03:14:40PM +0200, Martin Schröder wrote: >> > Am Do., 1. Sept. 2022 um 05:38 Uhr schrieb Job Snijders : >> > > Some ps(1) implementations have an '-d' ('descendancy') option. Through >> > > ASCII

Re: add sendmmsg and recvmmsg systemcalls

2022-09-01 Thread Moritz Buhl
I addressed your concerns as well as these of jca, just the kernel part (and the new ktrace stuff) below. One minor thing: I didn't see any kdump output where one struct was contained in another one but I am printing it like ddb would so I guess it should be fine. Index: kern/syscalls.master

Re: move PRU_CONNECT2 request to (*pru_connect2)()

2022-09-01 Thread Alexander Bluhm
On Thu, Sep 01, 2022 at 01:27:18AM +0300, Vitaliy Makkoveev wrote: > +int > +uipc_connect2(struct socket *so, struct socket *so2) > +{ > + struct unpcb *unp = sotounpcb(so), *unp2 = sotounpcb(so2); > + int error; > + > + if ((error = unp_connect2(so, so2))) > + return

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Theo de Raadt
Job Snijders wrote: > On Thu, Sep 01, 2022 at 03:14:40PM +0200, Martin Schröder wrote: > > Am Do., 1. Sept. 2022 um 05:38 Uhr schrieb Job Snijders : > > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > > > ASCII art parent/child process relationships are grouped and

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Stuart Henderson
On 2022/09/01 15:14, Martin Schröder wrote: > Am Do., 1. Sept. 2022 um 05:38 Uhr schrieb Job Snijders : > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > > ASCII art parent/child process relationships are grouped and displayed. > > > > Thoughts? > > gnu ps has > > -d

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Job Snijders
On Thu, Sep 01, 2022 at 03:14:40PM +0200, Martin Schröder wrote: > Am Do., 1. Sept. 2022 um 05:38 Uhr schrieb Job Snijders : > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > > ASCII art parent/child process relationships are grouped and displayed. > > > > Thoughts? >

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Martin Schröder
Am Do., 1. Sept. 2022 um 05:38 Uhr schrieb Job Snijders : > Some ps(1) implementations have an '-d' ('descendancy') option. Through > ASCII art parent/child process relationships are grouped and displayed. > > Thoughts? gnu ps has -d Select all processes except session leaders. and

immutable userland mappings

2022-09-01 Thread Theo de Raadt
In the last few years, I have been improving the strictness of userland memory layout. An example is the recent addition of MAP_STACK and msyscall(). The first one marks pages that are stack, so that upon entry to the kernel we can check if the stack-pointer is pointing in the stack range. If

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Matthias Schmidt
Hi Job, * Job Snijders wrote: > Dear all, > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > ASCII art parent/child process relationships are grouped and displayed. > Here is an example: > > $ ps ad -O ppid,user > PID PPID USER TT STATTIME

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

2022-09-01 Thread Martin Pieuchot
On 01/09/22(Thu) 03:37, Job Snijders wrote: > Dear all, > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > ASCII art parent/child process relationships are grouped and displayed. > Here is an example: > > $ ps ad -O ppid,user > PID PPID USER TT STAT

Re: bgpd switch rde_peer to RB tree

2022-09-01 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.01 12:04:03 +0200: > Convert the rde_peer hash table to an RB tree. This is a bit more complex > because rde_peer list is used in a lot of places. As a bonus use > peer_foreach in mrt.c to write the table v2 peer header (this needs a > special

Re: bgpd switch rde_peer to RB tree

2022-09-01 Thread Theo Buehler
On Thu, Sep 01, 2022 at 12:04:03PM +0200, Claudio Jeker wrote: > Convert the rde_peer hash table to an RB tree. This is a bit more complex > because rde_peer list is used in a lot of places. As a bonus use > peer_foreach in mrt.c to write the table v2 peer header (this needs a > special callback

Re: bgpd cleanup hash leftovers

2022-09-01 Thread Theo Buehler
On Thu, Sep 01, 2022 at 12:48:32PM +0200, Claudio Jeker wrote: > bgpd no longer needs siphash.h and also remove a hash member and a > prototype which are now unused. ok

Re: bgpd cleanup hash leftovers

2022-09-01 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.01 12:48:32 +0200: > bgpd no longer needs siphash.h and also remove a hash member and a > prototype which are now unused. > > -- > :wq Claudio > > Index: rde.h > === > RCS

bgpd cleanup hash leftovers

2022-09-01 Thread Claudio Jeker
bgpd no longer needs siphash.h and also remove a hash member and a prototype which are now unused. -- :wq Claudio Index: rde.h === RCS file: /cvs/src/usr.sbin/bgpd/rde.h,v retrieving revision 1.268 diff -u -p -r1.268 rde.h ---

bgpd switch rde_peer to RB tree

2022-09-01 Thread Claudio Jeker
Convert the rde_peer hash table to an RB tree. This is a bit more complex because rde_peer list is used in a lot of places. As a bonus use peer_foreach in mrt.c to write the table v2 peer header (this needs a special callback struct because two values need to be passed to the callback). The rest