Re: Move PRU_SOCKADDR and PRU_PEERADDR requests to corresponding pru_wrappers

2022-09-02 Thread Alexander Bluhm
On Sat, Sep 03, 2022 at 02:21:29AM +0300, Vitaliy Makkoveev wrote: > So, let's finish split int two steps, the diff converts PRU_SOCKADDR. OK bluhm@ > Index: sys/kern/uipc_usrreq.c > === > RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v

Re: protocol attach wait

2022-09-02 Thread Vitaliy Makkoveev
On Fri, Sep 02, 2022 at 11:56:02AM +0200, Alexander Bluhm wrote: > On Thu, Sep 01, 2022 at 11:04:19PM +0300, Vitaliy Makkoveev wrote: > > On Thu, Sep 01, 2022 at 10:58:49PM +0300, Vitaliy Makkoveev wrote: > > > On Thu, Sep 01, 2022 at 09:00:50PM +0200, Alexander Bluhm wrote: > > > > On Mon, Aug

Re: add sendmmsg and recvmmsg systemcalls

2022-09-02 Thread Moritz Buhl
Here is an updated version of the kernel part for sendmmsg. mbuhl Index: sys/kern/syscalls.master === RCS file: /mount/openbsd/cvs/src/sys/kern/syscalls.master,v retrieving revision 1.230 diff -u -p -r1.230 syscalls.master ---

Re: Remove "#ifdef INET6" block from in_setpeeraddr()

2022-09-02 Thread Vitaliy Makkoveev
On Fri, Sep 02, 2022 at 10:46:12PM +0200, Alexander Bluhm wrote: > On Fri, Sep 02, 2022 at 06:01:20PM +0300, Vitaliy Makkoveev wrote: > > We always call in6_setpeeraddr() and never call in_setpeeraddr() fro the > > inet6 case. > > Should we do it the other way around? > > By pushing the inet6

Re: Move PRU_SOCKADDR and PRU_PEERADDR requests to corresponding pru_wrappers

2022-09-02 Thread Vitaliy Makkoveev
On Fri, Sep 02, 2022 at 10:48:56PM +0200, Alexander Bluhm wrote: > On Fri, Sep 02, 2022 at 05:56:33PM +0300, Vitaliy Makkoveev wrote: > > Introduce in{,6}_sockaddr() and in{,6}_peeraddr() functions, and use > > them for all except tcp(4) sockets. Use tcp_sockaddr() and > > tcp_peeraddr() functions

[please test] pvclock(4): fix several bugs

2022-09-02 Thread Scott Cheloha
dv@ suggested coming to the list to request testing for the pvclock(4) driver. Attached is a patch that corrects several bugs. Most of these changes will only matter in the non-TSC_STABLE case on a multiprocessor VM. Ideally, nothing should break. - pvclock yields a 64-bit value. The BSD

Re: rpki-client stop all repo fetching a bit before the timeout

2022-09-02 Thread Claudio Jeker
On Fri, Sep 02, 2022 at 09:50:06PM +, Job Snijders wrote: > Hi Claudio, > > This looks mostly OK, just a few nit: > > On Fri, Sep 02, 2022 at 10:02:33PM +0200, Claudio Jeker wrote: > > @@ -1223,8 +1224,26 @@ repo_check_timeout(int timeout) > > { > > struct repo *rp; > > time_t

Re: rpki-client stop all repo fetching a bit before the timeout

2022-09-02 Thread Job Snijders
Hi Claudio, This looks mostly OK, just a few nit: On Fri, Sep 02, 2022 at 10:02:33PM +0200, Claudio Jeker wrote: > @@ -1223,8 +1224,26 @@ repo_check_timeout(int timeout) > { > struct repo *rp; > time_t now; > + int diff; > > now =

Re: vmd(8): compute i8254 Read-Back latch from singular timestamp

2022-09-02 Thread Scott Cheloha
On Fri, Sep 02, 2022 at 01:13:00PM -0400, Dave Voutila wrote: > > Scott Cheloha writes: > > > The 8254 data sheet [1] says this about the Read-Back command: > > > >> The read-back command may be used to latch multi- > >> ple counter output latches (OL) by setting the > >> COUNT bit D5 = 0 and

Re: Move PRU_SOCKADDR and PRU_PEERADDR requests to corresponding pru_wrappers

2022-09-02 Thread Alexander Bluhm
On Fri, Sep 02, 2022 at 05:56:33PM +0300, Vitaliy Makkoveev wrote: > Introduce in{,6}_sockaddr() and in{,6}_peeraddr() functions, and use > them for all except tcp(4) sockets. Use tcp_sockaddr() and > tcp_peeraddr() functions to keep debug ability. > > The key management and route domain sockets

Re: Remove "#ifdef INET6" block from in_setpeeraddr()

2022-09-02 Thread Alexander Bluhm
On Fri, Sep 02, 2022 at 06:01:20PM +0300, Vitaliy Makkoveev wrote: > We always call in6_setpeeraddr() and never call in_setpeeraddr() fro the > inet6 case. Should we do it the other way around? By pushing the inet6 case into the callee allows less switches in the callers. Instead of adding

Re: rpki-client stop all repo fetching a bit before the timeout

2022-09-02 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.02 22:02:33 +0200: > Lets try to finish work by stopping all syncs and fall back to what we > have in cache after 7/8 of the timeout (timeout - 1/2 repo_timeout). > This way we still have 1/8 of time to finish the calculation and produce > output.

Re: rpki-client stop all repo fetching a bit before the timeout

2022-09-02 Thread Theo Buehler
On Fri, Sep 02, 2022 at 10:02:33PM +0200, Claudio Jeker wrote: > Lets try to finish work by stopping all syncs and fall back to what we > have in cache after 7/8 of the timeout (timeout - 1/2 repo_timeout). > This way we still have 1/8 of time to finish the calculation and produce > output. > >

Re: mld6 remove global variable

2022-09-02 Thread Sebastian Benoit
that was meant to be an ok :) Sebastian Benoit(be...@openbsd.org) on 2022.09.02 22:04:41 +0200: > Alexander Bluhm(alexander.bl...@gmx.net) on 2022.09.02 20:38:04 +0200: > > Hi, > > > > Due to the KAME scope address hack, the link-local all nodes and > > routers IPv6 addresses cannot be const.

Re: mld6 remove global variable

2022-09-02 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2022.09.02 20:38:04 +0200: > Hi, > > Due to the KAME scope address hack, the link-local all nodes and > routers IPv6 addresses cannot be const. So move memory from data > to stack to make variables MP safe. > > ok? > > bluhm > > Index:

rpki-client stop all repo fetching a bit before the timeout

2022-09-02 Thread Claudio Jeker
Lets try to finish work by stopping all syncs and fall back to what we have in cache after 7/8 of the timeout (timeout - 1/2 repo_timeout). This way we still have 1/8 of time to finish the calculation and produce output. Tested this diff by setting the deadline to fire after 60sec. -- :wq

Re: KNF rpki-client

2022-09-02 Thread Theo Buehler
On Fri, Sep 02, 2022 at 09:05:45PM +0200, Claudio Jeker wrote: > Split some overly long lines. ok > > -- > :wq Claudio > > Index: main.c > === > RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v > retrieving revision 1.215 > diff

KNF rpki-client

2022-09-02 Thread Claudio Jeker
Split some overly long lines. -- :wq Claudio Index: main.c === RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v retrieving revision 1.215 diff -u -p -r1.215 main.c --- main.c 30 Aug 2022 22:42:32 - 1.215 +++ main.c

Re: rpki-client abort repos on timeout

2022-09-02 Thread Theo Buehler
On Fri, Sep 02, 2022 at 08:49:12PM +0200, Claudio Jeker wrote: > This diff uses the now available aborts to stop repository > synchronisations once the timeout is hit. > > I played with very short repo_timeouts and it seems to work better then > what we have now. I generally prefer explicit

rpki-client abort repos on timeout

2022-09-02 Thread Claudio Jeker
This diff uses the now available aborts to stop repository synchronisations once the timeout is hit. I played with very short repo_timeouts and it seems to work better then what we have now. -- :wq Claudio ? obj Index: extern.h ===

mld6 remove global variable

2022-09-02 Thread Alexander Bluhm
Hi, Due to the KAME scope address hack, the link-local all nodes and routers IPv6 addresses cannot be const. So move memory from data to stack to make variables MP safe. ok? bluhm Index: netinet6/mld6.c === RCS file:

Re: rpki-client add abort to rrdp

2022-09-02 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.02 19:55:28 +0200: > We want to be able to abort RRDP syncs. Now the problem is that depending > on the state the abort request is more or less complex. What needs to be > avoided is that a message received after the corresponding RRDP session >

rpki-client add abort to rrdp

2022-09-02 Thread Claudio Jeker
We want to be able to abort RRDP syncs. Now the problem is that depending on the state the abort request is more or less complex. What needs to be avoided is that a message received after the corresponding RRDP session was removed. This is mainly the RRDP_FILE and RRDP_HTTP_FIN messages that cause

Re: vmd(8): compute i8254 Read-Back latch from singular timestamp

2022-09-02 Thread Mike Larkin
On Fri, Sep 02, 2022 at 11:42:03AM -0500, Scott Cheloha wrote: > The 8254 data sheet [1] says this about the Read-Back command: > > > The read-back command may be used to latch multi- > > ple counter output latches (OL) by setting the > > COUNT bit D5 = 0 and selecting the desired coun- > >

Re: vmd(8): compute i8254 Read-Back latch from singular timestamp

2022-09-02 Thread Mike Larkin
On Fri, Sep 02, 2022 at 11:42:03AM -0500, Scott Cheloha wrote: > The 8254 data sheet [1] says this about the Read-Back command: > > > The read-back command may be used to latch multi- > > ple counter output latches (OL) by setting the > > COUNT bit D5 = 0 and selecting the desired coun- > >

Re: vmd(8): compute i8254 Read-Back latch from singular timestamp

2022-09-02 Thread Dave Voutila
Scott Cheloha writes: > The 8254 data sheet [1] says this about the Read-Back command: > >> The read-back command may be used to latch multi- >> ple counter output latches (OL) by setting the >> COUNT bit D5 = 0 and selecting the desired coun- >> ter(s). This single command is functionally

Re: divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread YASUOKA Masahiko
Hi, On Fri, 2 Sep 2022 17:40:13 +0200 Alexander Bluhm wrote: > On Fri, Sep 02, 2022 at 03:04:34PM +0200, YASUOKA Masahiko wrote: >> The diff is to fix a problem in a complex setup. >> >> Normal setup of divert-reply for TCP connection: >> >> client --- relayd --- server >> >> -

vmd(8): compute i8254 Read-Back latch from singular timestamp

2022-09-02 Thread Scott Cheloha
The 8254 data sheet [1] says this about the Read-Back command: > The read-back command may be used to latch multi- > ple counter output latches (OL) by setting the > COUNT bit D5 = 0 and selecting the desired coun- > ter(s). This single command is functionally equiva- > lent to several counter

Re: divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread Alexander Bluhm
On Fri, Sep 02, 2022 at 03:04:34PM +0200, YASUOKA Masahiko wrote: > Hi, > > The diff is to fix a problem in a complex setup. > > Normal setup of divert-reply for TCP connection: > > client --- relayd --- server > > - transparently forward TCP connections > - divert-reply is configured the

Remove "#ifdef INET6" block from in_setpeeraddr()

2022-09-02 Thread Vitaliy Makkoveev
We always call in6_setpeeraddr() and never call in_setpeeraddr() fro the inet6 case. Index: sys/netinet/in_pcb.c === RCS file: /cvs/src/sys/netinet/in_pcb.c,v retrieving revision 1.273 diff -u -p -r1.273 in_pcb.c ---

Move PRU_SOCKADDR and PRU_PEERADDR requests to corresponding pru_wrappers

2022-09-02 Thread Vitaliy Makkoveev
Introduce in{,6}_sockaddr() and in{,6}_peeraddr() functions, and use them for all except tcp(4) sockets. Use tcp_sockaddr() and tcp_peeraddr() functions to keep debug ability. The key management and route domain sockets returns EINVAL error for PRU_SOCKADDR request, so keep this behaviour for a

some more kernel const

2022-09-02 Thread Miod Vallat
Constify nam2blk[] and chrtoblktbl[], these are never modified at runtime. Plus an octeon bonus: devmap[]. Index: sys/arch/alpha/alpha/autoconf.c === RCS file: /OpenBSD/src/sys/arch/alpha/alpha/autoconf.c,v retrieving revision 1.38

Re: Race in disk_attach_callback?

2022-09-02 Thread Klemens Nanni
On Mon, Aug 29, 2022 at 07:51:24PM +, Miod Vallat wrote: > > What's the status on this diff? > > I'm waiting for review from at least one of the softraid suspects prior > to putting this in, in case there are further cinematics to address. Sounds like a good idea. In the meantime, while

Re: unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Sebastian Benoit
Stuart Henderson(s...@spacehopper.org) on 2022.09.02 12:16:06 +0100: > On 2022/09/02 11:25, Sebastian Benoit wrote: > > > > > Sep 2 06:39:58 x1c unbound: [14264:0] notice: Restart of unbound > > > > > 1.16.0. > > > > > Sep 2 06:39:58 x1c unbound: [14264:0] notice: init module 0: > > > > >

divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread YASUOKA Masahiko
Hi, The diff is to fix a problem in a complex setup. Normal setup of divert-reply for TCP connection: client --- relayd --- server - transparently forward TCP connections - divert-reply is configured the outbound connection to the server - so that the PF state is removed when the PCB is

tcp timer mutex

2022-09-02 Thread Alexander Bluhm
Hi, To remove pressure from the exclusive netlock, I would like to run tcp_slowtimo() with a mutex only. That means that all the consumers have to read tcp_now only once to get consistent time. Same for tcp_iss, update it with mutex, read it once. ok? bluhm Index: net/pf.c

Re: move PRU_CONTROL request to (*pru_control)()

2022-09-02 Thread Alexander Bluhm
On Thu, Sep 01, 2022 at 10:52:33PM +0300, Vitaliy Makkoveev wrote: > The 'proc *' is not used for PRU_CONTROL request, so remove it from > pru_control() wrapper. > > I want to use existing in{6,}_control for tcp(4) and udp(4) sockets, so > for inet6 case I introduced `tcp6_usrreqs' and

libX11: disable thread safety constructor in 1.18.1

2022-09-02 Thread Matthieu Herrb
Hi again, So libX11 1.8.1 introduced a constructor to call XInitThreads(3) unconditionnaly at library load time, to make sure all multithreaded X applications would have correct locks around Xlib calls. Of course this behaviour change also exposes some bugs in existing code. A first one was

Re: add sendmmsg and recvmmsg systemcalls

2022-09-02 Thread Alexander Bluhm
On Thu, Sep 01, 2022 at 06:06:10PM +0200, Moritz Buhl wrote: > I addressed your concerns as well as these of jca, just the kernel > part (and the new ktrace stuff) below. > > One minor thing: I didn't see any kdump output where one struct was > contained in another one but I am printing it like

Re: unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Stuart Henderson
On 2022/09/02 11:25, Sebastian Benoit wrote: > > > > Sep 2 06:39:58 x1c unbound: [14264:0] notice: Restart of unbound > > > > 1.16.0. > > > > Sep 2 06:39:58 x1c unbound: [14264:0] notice: init module 0: validator > > > > Sep 2 06:39:58 x1c unbound: [14264:0] notice: init module 1: iterator > >

xterm at 30bpp with TrueType fonts regression

2022-09-02 Thread Matthieu Herrb
Hi, if you happen to have a machine where the X server is running with a default depth of 30 bits per pixel and a True Color Visual (10 bit/rgb component), xterm wih TrueType fonts (using faceName X resource or the -fa command-line option) will display as a black window... This happens to be a

Re: unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Mikolaj Kucharski
On Fri, Sep 02, 2022 at 11:25:20AM +0200, Sebastian Benoit wrote: > Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 08:07:01 +: > > On Fri, Sep 02, 2022 at 09:53:54AM +0200, Sebastian Benoit wrote: > > > Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 06:47:00 +: > > > >

Re: protocol attach wait

2022-09-02 Thread Alexander Bluhm
On Thu, Sep 01, 2022 at 11:04:19PM +0300, Vitaliy Makkoveev wrote: > On Thu, Sep 01, 2022 at 10:58:49PM +0300, Vitaliy Makkoveev wrote: > > On Thu, Sep 01, 2022 at 09:00:50PM +0200, Alexander Bluhm wrote: > > > On Mon, Aug 15, 2022 at 05:12:22PM +0200, Alexander Bluhm wrote: > > > > System calls

rpki-client refactor rsync process

2022-09-02 Thread Claudio Jeker
The rsync process implements a limit by stopping to read commands from its stdin once too many processes are run. This is all nice and fine but it does not allow to send a abort request to the process reliably. This diff refactors the rsync process and introduces a state queue which can have more

Re: unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Sebastian Benoit
Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 08:07:01 +: > On Fri, Sep 02, 2022 at 09:53:54AM +0200, Sebastian Benoit wrote: > > Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 06:47:00 +: > > > Hi, > > > > > > I have a question, could or should unbound in base be

httpd: fix default request body size

2022-09-02 Thread YASUOKA Masahiko
Hello, For HTTP request body, if neither "Content-Encoding: chunked" nor "Content-Length" is specified, it should mean body length is 0. In RFC 9112 Section 6.3, 7.: | 7. If this is a request message and none of the above are true, then | the message body length is zero (no message body

Re: unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Mikolaj Kucharski
On Fri, Sep 02, 2022 at 09:53:54AM +0200, Sebastian Benoit wrote: > Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 06:47:00 +: > > Hi, > > > > I have a question, could or should unbound in base be delivered with: > > > > # cat /etc/login.conf.d/unbound > > unbound:\ > >

Re: unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Sebastian Benoit
Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 06:47:00 +: > Hi, > > I have a question, could or should unbound in base be delivered with: > > # cat /etc/login.conf.d/unbound > unbound:\ > :openfiles-cur=4096:\ > :openfiles-max=8192:\ > :tc=daemon: > > or

Re: sparc64: ofwboot: support booting from softraid 1C

2022-09-02 Thread Stefan Sperling
On Thu, Sep 01, 2022 at 08:31:04PM +, Klemens Nanni wrote: > This is practically the same diff we already landed for arm64. > > The kernel already supports booting off 1C and with tech@'s > "installboot: sparc64: fix -r on multi-chunk softraid chunk" diff the > install process will no longer

Re: sparc64: ofwboot: support booting from softraid 1C

2022-09-02 Thread Mark Kettenis
> Date: Thu, 1 Sep 2022 20:31:04 + > From: Klemens Nanni > > This is practically the same diff we already landed for arm64. > > The kernel already supports booting off 1C and with tech@'s > "installboot: sparc64: fix -r on multi-chunk softraid chunk" diff the > install process will no

Re: httpd: overwrite rather than error for duplicate type entries

2022-09-02 Thread Sebastian Benoit
thanks, commited! Florian Obser(flor...@openbsd.org) on 2022.09.02 08:08:09 +0200: > This diff is correct and the use-case makes sense to me. > OK florian > > > On 2022-09-01 21:30 +01, Ben Fuller wrote: > > On Thu, Sep 01, 2022 at 21:22:13 +0100, Ben Fuller wrote: > >> On Thu, Sep 01, 2022 at

unbound and cannot increase max open fds from 512 to 4152

2022-09-02 Thread Mikolaj Kucharski
Hi, I have a question, could or should unbound in base be delivered with: # cat /etc/login.conf.d/unbound unbound:\ :openfiles-cur=4096:\ :openfiles-max=8192:\ :tc=daemon: or the like? Above is taken from dovecot. I was able to trigger via rcctl reload unbound following

Re: httpd: overwrite rather than error for duplicate type entries

2022-09-02 Thread Florian Obser
This diff is correct and the use-case makes sense to me. OK florian On 2022-09-01 21:30 +01, Ben Fuller wrote: > On Thu, Sep 01, 2022 at 21:22:13 +0100, Ben Fuller wrote: >> On Thu, Sep 01, 2022 at 21:44:34 +0200, Florian Obser wrote: >> > Pretty sure this doesn't compile. >> > If it were to