Re: Questions about the code review process in OpenBSD

Nov 5, 2022, 00:19 by ch...@nmedia.net: > i...@tutanota.com [i...@tutanota.com] wrote: > >> >> Is it a condition for code to go into the OpenBSD source tree (not >> talking about ports) that at least one other developer has reviewed the >> code? >> > > Yes > >> Is there a process in place to

Re: Questions about the code review process in OpenBSD

i...@tutanota.com [i...@tutanota.com] wrote: > > Is it a condition for code to go into the OpenBSD source tree (not > talking about ports) that at least one other developer has reviewed the > code? > Yes > Is there a process in place to guarantee this? > Yes, manual review all the way down.

Re: azalia module fix for 7.2-stable and some Intel 500 HDA Chips

On Fri, Nov 04, 2022 at 10:11:55AM -0500, John Browning wrote: > Hey, > It's: hw.vendor=LENOVO > hw.product=20Y4S1QE00 > hw.version=ThinkPad P1 Gen 4i > > That patch seems to be a better method. > > Thanks! thanks for the report, committed

Questions about the code review process in OpenBSD

I am trying to understand how the code review process is conducted in OpenBSD. I can see all the OK's in the commit log, but not every commit has the OK. On FreeBSD there where a serious problem with a developer who was hired to by Netgear to create a WireGuard VPN implementation as a kernel-mode

pflow(4): make `so' dereference safe

Each pflow(4) interface has associated socket, referenced as sc->so. We set this socket in pflowioctl() which is called with both kernel and net locks held. In the pflow_output_process() task we do sc->so dereference, which is protected by kernel lock. But the sosend(), called deeper by

Re: azalia module fix for 7.2-stable and some Intel 500 HDA Chips

On Fri, Nov 04, 2022 at 04:22:55PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Nov 2022 02:06:11 +1100 > > From: Jonathan Gray > > > > On Fri, Nov 04, 2022 at 09:10:52AM -0500, John Browning wrote: > > > Hi, > > > I noticed I did not have sound on my new thinkpad which has a newer > > > Intel

Re: azalia module fix for 7.2-stable and some Intel 500 HDA Chips

> Date: Sat, 5 Nov 2022 02:06:11 +1100 > From: Jonathan Gray > > On Fri, Nov 04, 2022 at 09:10:52AM -0500, John Browning wrote: > > Hi, > > I noticed I did not have sound on my new thinkpad which has a newer > > Intel 500 HDA chipset. > > > > bsd$ doas pcidump -vvv 0:31:3 > > 0:31:3: Intel 500

Re: azalia module fix for 7.2-stable and some Intel 500 HDA Chips

Hey, It's: hw.vendor=LENOVO hw.product=20Y4S1QE00 hw.version=ThinkPad P1 Gen 4i That patch seems to be a better method. Thanks! On Fri, Nov 4, 2022 at 10:06 AM Jonathan Gray wrote: > > On Fri, Nov 04, 2022 at 09:10:52AM -0500, John Browning wrote: > > Hi, > > I noticed I did not have sound on

Re: azalia module fix for 7.2-stable and some Intel 500 HDA Chips

On Fri, Nov 04, 2022 at 09:10:52AM -0500, John Browning wrote: > Hi, > I noticed I did not have sound on my new thinkpad which has a newer > Intel 500 HDA chipset. > > bsd$ doas pcidump -vvv 0:31:3 > 0:31:3: Intel 500 Series HD Audio > 0x: Vendor ID: 8086, Product ID: 43c8 > 0x0004:

special case mpe(4) in in6_ifattach()

So mpe(4) is a special device. It is a point-to-multipoint interface that does not do multicast. So setting IFF_MULTICAST on the interface is not correct but IPv6 depends on it because neighbor discovery. Now there is no neighbor discovery on mpe(4) the neighbors are handled via BGP. So lets

azalia module fix for 7.2-stable and some Intel 500 HDA Chips

Hi, I noticed I did not have sound on my new thinkpad which has a newer Intel 500 HDA chipset. bsd$ doas pcidump -vvv 0:31:3 0:31:3: Intel 500 Series HD Audio 0x: Vendor ID: 8086, Product ID: 43c8 0x0004: Command: 0006, Status: 0010 0x0008:Class: 04 Multimedia, Subclass: 01

Re: rpki-client: missing initializer in output.c

On Fri, Nov 04, 2022 at 01:50:11PM +0100, Theo Buehler wrote: > Doesn't really matter, but it looks odd and -Wmissing-field-initializers > flags this. > > Index: output.c > === > RCS file: /cvs/src/usr.sbin/rpki-client/output.c,v >

rpki-client: missing initializer in output.c

Doesn't really matter, but it looks odd and -Wmissing-field-initializers flags this. Index: output.c === RCS file: /cvs/src/usr.sbin/rpki-client/output.c,v retrieving revision 1.27 diff -u -p -r1.27 output.c --- output.c30 Aug

Re: bgpctl show mpls label in fib output

On Fri, Nov 04, 2022 at 09:12:13AM +0100, Theo Buehler wrote: > On Thu, Nov 03, 2022 at 03:26:35PM +0100, Claudio Jeker wrote: > > Noticed while figuring out the kroute bug with MPLS. > > I think it would be nice to know the MPLS label of a fib MPLS route. > > > > bgpctl show fib table 13 > >

Re: bgpctl show mpls label in fib output

On Thu, Nov 03, 2022 at 03:26:35PM +0100, Claudio Jeker wrote: > Noticed while figuring out the kroute bug with MPLS. > I think it would be nice to know the MPLS label of a fib MPLS route. > > bgpctl show fib table 13 > flags: B = BGP, C = Connected, S = Static >N = BGP Nexthop reachable