Re: Remove last queue(3) *_END() user from tree

> Date: Sun, 27 Nov 2022 22:16:10 + > From: Klemens Nanni > > queue(3) NOTES says > The SLIST_END(), LIST_END(), SIMPLEQ_END(), STAILQ_END() and TAILQ_END() > macros are deprecated; they provided symmetry with the historical > CIRCLEQ_END() and just expand to NULL. > > We still h

Remove last queue(3) *_END() user from tree

queue(3) NOTES says The SLIST_END(), LIST_END(), SIMPLEQ_END(), STAILQ_END() and TAILQ_END() macros are deprecated; they provided symmetry with the historical CIRCLEQ_END() and just expand to NULL. We still have one user, though: $ cd /usr/src/ $ grep -rslwE '(S?LIST|(S

Remove useless nd6_init_done from nd6_init()

Only ip6_init() calls nd6_init(), exactly once, just like it calls frag6_init() which on the other hand does not have some fra6_init_done to guard against itself. Like all other domains, ip6_init() is called in domaininit(), early in the kernel's main(). This variable was probably never useful an

Re: nd6: Statically initialise DAD list, remove obsolete dad_init

ok mvs@ > On 27 Nov 2022, at 23:29, Klemens Nanni wrote: > > On Sun, Nov 27, 2022 at 11:12:30PM +0300, Vitaliy Makkoveev wrote: >> dad_init should go away too. > > Thanks for pointing out the obvious. > --- > The list of IPv6 addresses to perfom Duplicate Address Detection on is > entirely stat

Re: nd6: Statically initialise DAD list, remove obsolete dad_init

On Sun, Nov 27, 2022 at 11:12:30PM +0300, Vitaliy Makkoveev wrote: > dad_init should go away too. Thanks for pointing out the obvious. --- The list of IPv6 addresses to perfom Duplicate Address Detection on is entirely static to nd6_nbr.c; ttatically initialise it so `dad_init' can go. nd6_dad_f

Re: nd6: Clean up DAD initialisation

dad_init should go away too. > On 27 Nov 2022, at 21:18, Klemens Nanni wrote: > > The list of IPv6 addresses to perfom Duplicate Address Detection on is > entirely static to nd6_nbr.c incl. its state vars with the exception of > ip6_dad_pending aka. the net.inet6.ip6.dad_pending sysctl(2). > >

dwpcie(4): Add MSI support

Joel Carnat reported that using both disk slots of the ODROID-HC4 doesn't work with OpenBSD. I never tried that in mine, but could indeed reproduce the issue. The machine seems to hang on doing disk I/O, so I started looking at interrupts. PCIe interrupts on this machine have always been fishy.

nd6: DAD: Remove useless variable, simplify code

Using a local `duplicate' variable to defer the actual checks by a few lines, interleaved with comments (saying the same thing but negated), is harder to follow that neccessary. Fold the logic and merge comments (remove the last obvious one missing a negation) to save 20 LOC. Feedback? Objection?

nd6: Clean up DAD initialisation

The list of IPv6 addresses to perfom Duplicate Address Detection on is entirely static to nd6_nbr.c incl. its state vars with the exception of ip6_dad_pending aka. the net.inet6.ip6.dad_pending sysctl(2). Statically initialise the list head, pull dad_init from the middle to the file up to where th

Re: Segfault in x509_constraints_uri_host

On Sun, Nov 27, 2022 at 05:07:20PM +, Anton Borowka wrote: > Hi, > > I was trying to create a certificate with an URI SAN using > p5-io-socket-ssl and got a segfault in > lib/libcrypto/x509/x509_constraints.c:x509_constraints_uri_host() > > perl -MIO::Socket::SSL::Utils -le 'CERT_create >

Segfault in x509_constraints_uri_host

Hi, I was trying to create a certificate with an URI SAN using p5-io-socket-ssl and got a segfault in lib/libcrypto/x509/x509_constraints.c:x509_constraints_uri_host() perl -MIO::Socket::SSL::Utils -le 'CERT_create ext=>[{sn=>"subjectAltName",data=>"URI:urn:open62541.server.application"}]' I

Add Intel Optane DC to pcidevs

Hi, Intel Optane DC SSDs are not yet identified in CURRENT (e.g., https://ark.intel.com/content/www/us/en/ark/products/201861/intel-optane-ssd-dc-p5800x-series-400gb-2-5in-pcie-x4-3d-xpoint.html ). The following patch gets rid of the "unknown product 0x4140" output of the corresponding nvme(

Re: dhcpleased, resolvd, slaacd: accurate lock error message

On Sun, 27 Nov 2022 12:41:23 +, Klemens Nanni wrote: > On Sat, Nov 26, 2022 at 07:33:40PM -0700, Theo de Raadt wrote: > > Yes, that is understandable and suggests "no need to panic". > > Sure, I wasn't sure yet as to whether this is the only way open(2) can > yield EAGAIN (in this use case), b

nd6 DAD: Remove useless casts

All *dp variables are of type 'struct dadq *' already; no object change. OK? diff --git a/sys/netinet6/nd6_nbr.c b/sys/netinet6/nd6_nbr.c index 0cd55d966a1..15d7b253c01 100644 --- a/sys/netinet6/nd6_nbr.c +++ b/sys/netinet6/nd6_nbr.c @@ -1112,7 +1112,7 @@ nd6_dad_start(struct ifaddr *ifa)

Re: dhcpleased, resolvd, slaacd: accurate lock error message

On Sat, Nov 26, 2022 at 07:33:40PM -0700, Theo de Raadt wrote: > Yes, that is understandable and suggests "no need to panic". Sure, I wasn't sure yet as to whether this is the only way open(2) can yield EAGAIN (in this use case), but since you seem to agree.. Todd, do you want to commit this diff

Re: pfsync panic after pf_purge backout

On 27.11.2022. 9:28, Hrvoje Popovski wrote: > On 27.11.2022. 1:51, Alexandr Nedvedicky wrote: >> Hello, >> >> On Sat, Nov 26, 2022 at 08:33:28PM +0100, Hrvoje Popovski wrote: >> >>> I just need to say that with all pf, pfsync and with pf_purge diffs >>> after hackaton + this diff on tech@ >>> http

Re: pfsync panic after pf_purge backout

On 27.11.2022. 1:51, Alexandr Nedvedicky wrote: > Hello, > > On Sat, Nov 26, 2022 at 08:33:28PM +0100, Hrvoje Popovski wrote: > >> I just need to say that with all pf, pfsync and with pf_purge diffs >> after hackaton + this diff on tech@ >> https://www.mail-archive.com/tech@openbsd.org/msg72582.h