Re: mountd: potential use of uninitialized stack data

2023-02-22 Thread Alexander Bluhm
On Wed, Feb 22, 2023 at 10:19:57AM -0700, Todd C. Miller wrote: > On Wed, 22 Feb 2023 17:11:47 +0100, Moritz Buhl wrote: > > > The tool finds a path to ex_search where fsb.f_fsid is uninitialized. > > > > ex_search compares the potentially uninitialized stack data: > > > > ex_search(fsid_t *fsid)

Re: Add the -m (--prune-empty-dirs) option to openrsync

2023-02-22 Thread bukhris
Hello again, Job Sorry for the recurring formatting and tab issues. Here's the updated diff. Index: extern.h === RCS file: /cvs/src/usr.bin/rsync/extern.h,v retrieving revision 1.44 diff -u -p -u -p -r1.44 extern.h --- extern.h2

Re: Add the -m (--prune-empty-dirs) option to openrsync

2023-02-22 Thread Mohamed Bukhris
Hello Job, Sorry for the formatting issues, here's the fixed version, diffed properly via CVS. Index: extern.h === RCS file: /cvs/src/usr.bin/rsync/extern.h,v retrieving revision 1.44 diff -u -p -u -p -r1.44 extern.h --- extern.h  

Re: mountd: potential use of uninitialized stack data

2023-02-22 Thread Todd C . Miller
On Wed, 22 Feb 2023 17:11:47 +0100, Moritz Buhl wrote: > The tool finds a path to ex_search where fsb.f_fsid is uninitialized. > > ex_search compares the potentially uninitialized stack data: > > ex_search(fsid_t *fsid) > { > struct exportlist *ep; > > ep = exphead; > while (ep)

mountd: potential use of uninitialized stack data

2023-02-22 Thread Moritz Buhl
Dear tech@, codechecker found the following problem with fsb in sbin/mountd: mntsrv(...) ... struct statfs fsb; ... if (realpath(rpcpath, dirpath) == NULL) { bad = errno; if (debug) fprintf(std

iwx(4) -77 firmware diff for testing

2023-02-22 Thread Stefan Sperling
Below is my work-in-progress diff to update iwx(4) to latest firmware. Every system tracking -current should already have the new -77 firmware images. The new images contain security fixes of (to me) unknown severity. Unfortunately there have been quite a number of firmware API changes since our l

Re: Add the -m (--prune-empty-dirs) option to openrsync

2023-02-22 Thread Job Snijders
Dear Mohamed, On Wed, Feb 22, 2023 at 05:42:10AM +, Mohamed Bukhris wrote: > This patch adds the -m/--prume-empty-dirs option to openrsync > while keeping said feature compatible with rsync > this avoids the 27 -> 31 protocol mismatch error by not sharing the -m option > to remote > This was