pax: GNU tar base-256 size field support

2023-04-18 Thread Todd C . Miller
I recently ran into a problem with busybox tar generating archives where the size field is base-256 encoded for files larger than 8GB. Apparently this is a GNU tar extension. Do we want to support this in pax? Below is an initial diff that at least produces the correct results when listing the

Fwd: [patch] [arm64] cpu.c patch based on amd64 idea, provides more debug for multicore kernel

2023-04-18 Thread S V
Hello, tech! I'm attaching simple patch that adds two "features" to mp kernel for arm64 arch: 1. It allows to enable debug flag to drop to DDB to debug mp init problems 2. It allows some buggy arm64 processors to break from loop and dirty (or not so dirty) boot to multicore instead of eternal

Re: in_ioctl*: hoist identical privilege checks

2023-04-18 Thread Klemens Nanni
On Sat, Apr 15, 2023 at 01:48:02PM +, Klemens Nanni wrote: > On Fri, Apr 14, 2023 at 11:33:18PM +, Klemens Nanni wrote: > > All cases do the same check up first, so merge it before the switch. Committed. > > It could be hoisted further in both in_ioctl() and in_ioctl_change_ifaddr(), > >

synaptics touchpad with no multifinger support

2023-04-18 Thread la ninpre
Hello, tech@ So I installed OpenBSD on old Compaq laptop and noticed that scrolling with touchpad is not working. I started investigating to see why it is the case and found out a few odd things in wscons(4) and pckbc(4) drivers. Basically, the laptop's touchpad lacks multifinger support (see

Re: bgpd pass flowspec rules to RDE

2023-04-18 Thread Theo Buehler
On Tue, Apr 18, 2023 at 05:22:26PM +0200, Claudio Jeker wrote: > This adds the needed bits to send the flowspec rules to the RDE. > The RDE just drops them on the ground for now. ok tb

Re: bgpd add flowspec support to rde_prefix.c

2023-04-18 Thread Theo Buehler
On Tue, Apr 18, 2023 at 03:38:12PM +0200, Claudio Jeker wrote: > Extend the pt_entry api to handle flowspec. > Introduce pt_get_flow() and pt_add_flow() to lookup and insert flowspec > objects. Add pt_getflowspec() which works somewhat similar to pt_getaddr() > to extract the flowspec NLRI from a

Re: Call sysctl_ifnames() with shared netlock

2023-04-18 Thread Alexander Bluhm
On Mon, Apr 17, 2023 at 05:43:05PM +0300, Vitaliy Makkoveev wrote: > On Mon, Apr 17, 2023 at 02:58:59PM +0200, Alexander Bluhm wrote: > > On Mon, Apr 17, 2023 at 01:20:28AM +0300, Vitaliy Makkoveev wrote: > > > It performs read-only access to netlock protected data. > > > > OK bluhm@ > > > >

Re: Remove kernel lock from ifa_ifwithaddr()

2023-04-18 Thread Alexander Bluhm
On Tue, Apr 18, 2023 at 06:49:39PM +0300, Vitaliy Makkoveev wrote: > rtable_setsource(... , NULL) actually doesn't destroy object pointed by > `ar_source', so for this call netlock is not required. However this > optimisation doesn't produce any visible effect, so no objections to > call

Re: Remove kernel lock from ifa_ifwithaddr()

2023-04-18 Thread Vitaliy Makkoveev
On Tue, Apr 18, 2023 at 03:15:54PM +0200, Alexander Bluhm wrote: > On Mon, Apr 17, 2023 at 03:16:36AM +0300, Vitaliy Makkoveev wrote: > > Index: sys/dev/usb/if_umb.c > This umb chunk is OK bluhm@ > > > Index: sys/net/if.c > > === > >

bgpd pass flowspec rules to RDE

2023-04-18 Thread Claudio Jeker
This adds the needed bits to send the flowspec rules to the RDE. The RDE just drops them on the ground for now. -- :wq Claudio Index: bgpd.c === RCS file: /cvs/src/usr.sbin/bgpd/bgpd.c,v retrieving revision 1.257 diff -u -p -r1.257

Re: Call sysctl_source() with shared netlock

2023-04-18 Thread Vitaliy Makkoveev
On Tue, Apr 18, 2023 at 03:36:09PM +0200, Alexander Bluhm wrote: > On Mon, Apr 17, 2023 at 05:53:28PM +0200, Alexander Bluhm wrote: > > On Mon, Apr 17, 2023 at 04:32:13PM +0200, Alexander Bluhm wrote: > > > On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote: > > > > It seems

Re: bgpd print flowspec definitions in printconf

2023-04-18 Thread Theo Buehler
On Tue, Apr 18, 2023 at 03:11:29PM +0200, Claudio Jeker wrote: > This adds the bit to show flowspec rules in the printconfig output > when run with bgpd -nvf config. > > I did not fix the ICMP handling yet. It feels like too much of an edge > case for now. Reads fine ok tb

bgpd add flowspec support to rde_prefix.c

2023-04-18 Thread Claudio Jeker
Extend the pt_entry api to handle flowspec. Introduce pt_get_flow() and pt_add_flow() to lookup and insert flowspec objects. Add pt_getflowspec() which works somewhat similar to pt_getaddr() to extract the flowspec NLRI from a pt_entry. There is a hack in pt_getaddr() to return something. This is

Re: Call sysctl_source() with shared netlock

2023-04-18 Thread Alexander Bluhm
On Mon, Apr 17, 2023 at 05:53:28PM +0200, Alexander Bluhm wrote: > On Mon, Apr 17, 2023 at 04:32:13PM +0200, Alexander Bluhm wrote: > > On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote: > > > It seems rt_setsource() needs some attention, but sysctl_source() could > > > be called

Re: pfctl + bgpd for loop ugliness

2023-04-18 Thread Denis Fondras
Le Tue, Apr 18, 2023 at 02:43:26PM +0200, Theo Buehler a écrit : > On Tue, Apr 18, 2023 at 02:06:46PM +0200, Claudio Jeker wrote: > > This and the others are IIRC streight from pfctl. So if someone wants a > > free commit :) > > How about this. pfctl and bgpd are the same, except that the bgpd

Re: Remove kernel lock from ifa_ifwithaddr()

2023-04-18 Thread Alexander Bluhm
On Mon, Apr 17, 2023 at 03:16:36AM +0300, Vitaliy Makkoveev wrote: > Index: sys/dev/usb/if_umb.c > === > RCS file: /cvs/src/sys/dev/usb/if_umb.c,v > retrieving revision 1.50 > diff -u -p -r1.50 if_umb.c > --- sys/dev/usb/if_umb.c

bgpd print flowspec definitions in printconf

2023-04-18 Thread Claudio Jeker
This adds the bit to show flowspec rules in the printconfig output when run with bgpd -nvf config. I did not fix the ICMP handling yet. It feels like too much of an edge case for now. -- :wq Claudio Index: printconf.c === RCS file:

Re: xhci(4): map MSI-X

2023-04-18 Thread David Gwynne
I can't recall a real device that worked with MSI but not with msi-x, so I'm ok with chucking it in. On Tue, 18 Apr 2023, 21:15 Patrick Wildt, wrote: > Hi, > > I noticed that on Qemu with arm64 we're falling back to legacy > interrupts with xhci(4) on PCI. Turns out that the virtual xHCI >

pfctl + bgpd for loop ugliness

2023-04-18 Thread Theo Buehler
On Tue, Apr 18, 2023 at 02:06:46PM +0200, Claudio Jeker wrote: > This and the others are IIRC streight from pfctl. So if someone wants a > free commit :) How about this. pfctl and bgpd are the same, except that the bgpd one has a bsearch() nitems on top. pfctl regress is happy. Index:

Re: bgpd flowspec parser

2023-04-18 Thread Claudio Jeker
On Tue, Apr 18, 2023 at 12:52:00PM +0200, Theo Buehler wrote: > On Tue, Apr 18, 2023 at 11:29:26AM +0200, Claudio Jeker wrote: > > This diff adds the parse.y and config.c bits for flowspec. > > I tried to make flowspec rules as similar to pf rules (even though > > flowspec is more flexible). > >

Re: llvm15: Make -mbranch-protection=bti the default

2023-04-18 Thread Theo de Raadt
Christian Weisgerber wrote: > Mark Kettenis: > > > CVSROOT:/cvs > > Module name:src > > Changes by: kette...@cvs.openbsd.org2023/04/17 12:10:26 > > > > Modified files: > > gnu/llvm/clang/lib/Driver/ToolChains: Clang.cpp > > > > Log message: > > Make

xhci(4): map MSI-X

2023-04-18 Thread Patrick Wildt
Hi, I noticed that on Qemu with arm64 we're falling back to legacy interrupts with xhci(4) on PCI. Turns out that the virtual xHCI does not support MSI, but it does support MSI-X. By having xhci(4) map MSI-X as well I can use that on Qemu. My x395, which so far used MSI, is still working fine

Re: bgpd flowspec parser

2023-04-18 Thread Theo Buehler
On Tue, Apr 18, 2023 at 11:29:26AM +0200, Claudio Jeker wrote: > This diff adds the parse.y and config.c bits for flowspec. > I tried to make flowspec rules as similar to pf rules (even though > flowspec is more flexible). > > Now this diff does nothing in itself but is already large enough to

llvm15: Make -mbranch-protection=bti the default

2023-04-18 Thread Christian Weisgerber
Mark Kettenis: > CVSROOT: /cvs > Module name: src > Changes by: kette...@cvs.openbsd.org2023/04/17 12:10:26 > > Modified files: > gnu/llvm/clang/lib/Driver/ToolChains: Clang.cpp > > Log message: > Make -mbranch-protection=bti the default on OpenBSD. LLVM 15 reshuffled

bgpd flowspec parser

2023-04-18 Thread Claudio Jeker
This diff adds the parse.y and config.c bits for flowspec. I tried to make flowspec rules as similar to pf rules (even though flowspec is more flexible). Now this diff does nothing in itself but is already large enough to not add more to it. In parse.y the individual flowspec components are built

Re: unwind(8): fix (some?) bad packet log messages

2023-04-18 Thread Sebastien Marie
On Sat, Apr 15, 2023 at 12:11:28PM +0200, Florian Obser wrote: > Turns out I found a way to trigger "bad packet: too short" messages by > suspending / resuming my laptop in just the right spot. That allowed me > to figure out what's going on: > When asr fails (i.e. the stub strategy) it obviously