Re: Add another Lenovo NVMe device id

2023-05-03 Thread Kevin Lo
May I commit this diff? Thanks. On Thu, Apr 27, 2023 at 02:44:12PM +0800, Kevin Lo wrote: > > Found in my x1 extreme gen 1: > nvme0 at pci4 dev 0 function 0 vendor "Lenovo", unknown product 0x0006 rev > 0x00: msix, NVMe 1.2 > > ok? > > Index: sys/dev/pci/pcidevs >

Re: installer: amd64 EFI: default to GPT

2023-05-03 Thread Andrew Daugherity
On Sun, Apr 30, 2023 at 1:43 AM Klemens Nanni wrote: > > Installing to a wiped disk on EFI machines suggests MBR not GPT when chosing > (E)dit because MBR vs. GPT in this manual case is picked based on existing > data on the disk, not whether it has EFI. > > Fix that so users get correct

Re: OpenBSD 7.2 on Oracle Cloud

2023-05-03 Thread Aaron Mason
On Mon, May 1, 2023 at 4:56 AM Stefan Fritsch wrote: > > Hi, > > what qemu version are you using? I cannot reproduce this with qemu 7.2. > Can you try with a newer qemu? > > Cheers, > Stefan > What is the host OS where you're running QEMU? Just looking to eliminate any variables at play here.

Re: crontab: support random offsets for steps

2023-05-03 Thread Job Snijders
An illustration of the idea, this crontab configuration: $ crontab -l | grep touch */10 * * * * touch /tmp/normal-$(date +\%s) */~10* * * * touch /tmp/mixedup-$(date +\%s) Resulted on my local machine in the following: $ ls

Re: Push kernel lock deep down to sys_sysctl()

2023-05-03 Thread Alexander Bluhm
On Fri, Apr 21, 2023 at 05:17:46PM +0300, Vitaliy Makkoveev wrote: > At least network subset of sysctl(8) MIBs relies on netlock or another > locks and doesn't require kernel lock. Also some integers in other > subsets can be read without kernel lock held. > > Diff below actually pushes kernel

crontab: support random offsets for steps

2023-05-03 Thread Todd C . Miller
Crontab supports things like "*/20" in the minutes column to run every 20 minutes. For example, given: */20 * * * * echo I am right on time The job above would run at 0, 20, and 40 minutes of every hours. job@ asked whether we could support a random offset so that jobs would not always start

Re: Push kernel lock deep down to sys_sysctl()

2023-05-03 Thread Vitaliy Makkoveev
Ping. > On 21 Apr 2023, at 17:17, Vitaliy Makkoveev wrote: > > At least network subset of sysctl(8) MIBs relies on netlock or another > locks and doesn't require kernel lock. Also some integers in other > subsets can be read without kernel lock held. > > Diff below actually pushes kernel lock

Re: nd6 less kernel lock

2023-05-03 Thread Klemens Nanni
On Wed, May 03, 2023 at 12:22:16AM +0200, Alexander Bluhm wrote: > Hi, > > Some checks in nd6_resolve() do not require kernel lock. The analog > code for ARP has been unlocked in if_ether.c revision 1.250 since > 2022/06/27 20:47:10. Same diff here, thought I sent/committed that already. OK kn

Re: bgpctl update json.c and convert to json_do_string

2023-05-03 Thread Theo Buehler
On Wed, May 03, 2023 at 11:57:23AM +0200, Claudio Jeker wrote: > This diff is taking the changes from rpki-client (json.c / json.h) and > then converts json_do_printf() using "%s" fmt string to json_do_string(). > Also a few json_do_printf() with static strings are converted. Looks all good > A

bgpctl update json.c and convert to json_do_string

2023-05-03 Thread Claudio Jeker
This diff is taking the changes from rpki-client (json.c / json.h) and then converts json_do_printf() using "%s" fmt string to json_do_string(). Also a few json_do_printf() with static strings are converted. A few calls with more complex fmt strings remain. -- :wq Claudio Index: json.c

Re: pfioctl: DIOCGETRULESET{,S}: drop net lock

2023-05-03 Thread Alexandr Nedvedicky
Hello, On Sat, Apr 29, 2023 at 01:37:52PM +, Klemens Nanni wrote: > Both walk the list of rulesets aka. anchors, first one yields a count, > second yields a specific's anchor name. > > Same data access pattern, different copy out, basically. > > pf_anchor_global are contained within

Re: rpki-client convert to json_do_string()

2023-05-03 Thread Theo Buehler
On Wed, May 03, 2023 at 09:59:44AM +0200, Claudio Jeker wrote: > This replaces simple json_do_printf("name", "%s", buf); calls to > json_do_string(). This affects all json_do_printf() calls since no call > was more complex. ok tb

rpki-client convert -f output to json_do api

2023-05-03 Thread Claudio Jeker
This diff converts the current print code of -f to use json_do api. I did some minimal refactoring to reduce code repetition and more is for sure possible. I changed the way how the errstr is dumped but apart from that the objects remain the same (apart from spacing differences). -- :wq Claudio

rpki-client convert to json_do_string()

2023-05-03 Thread Claudio Jeker
This replaces simple json_do_printf("name", "%s", buf); calls to json_do_string(). This affects all json_do_printf() calls since no call was more complex. -- :wq Claudio Index: output-json.c === RCS file: