Re: Unlock ip6_sysctl()

2023-05-17 Thread Vitaliy Makkoveev
> On 18 May 2023, at 01:14, Alexander Bluhm wrote: > > On Wed, May 17, 2023 at 12:46:02PM +0300, Vitaliy Makkoveev wrote: >> Introduce `ip6_soiikey_lock' rwlock(9) to protect `ip6_soiikey'. It >> accessed only by ip6_sysctl_soiikey() and ip6_sysctl() is the only >> ip6_sysctl_soiikey() caller so

Re: Unlock ip6_sysctl()

2023-05-17 Thread Alexander Bluhm
On Wed, May 17, 2023 at 12:46:02PM +0300, Vitaliy Makkoveev wrote: > Introduce `ip6_soiikey_lock' rwlock(9) to protect `ip6_soiikey'. It > accessed only by ip6_sysctl_soiikey() and ip6_sysctl() is the only > ip6_sysctl_soiikey() caller so context switch is allowed here. Also > remove unused

Re: Add LRO counter in ix(4)

2023-05-17 Thread Alexander Bluhm
On Tue, May 16, 2023 at 09:11:48PM +0200, Jan Klemkow wrote: > @@ -412,6 +412,10 @@ tcp_stats(char *name) > p(tcps_outhwtso, "\t\t%u output TSO packet%s hardware processed\n"); > p(tcps_outpkttso, "\t\t%u output TSO packet%s generated\n"); > p(tcps_outbadtso, "\t\t%u output TSO

Re: Add LRO counter in ix(4)

2023-05-17 Thread Hrvoje Popovski
On 16.5.2023. 21:11, Jan Klemkow wrote: > Hi, > > This diff introduces new counters for LRO packets, we get from the > network interface. It shows, how many packets the network interface has > coalesced into LRO packets. > > In followup diff, this packet counter will also be used to set the >

Re: ix hardware tso

2023-05-17 Thread Alexander Bluhm
On Tue, May 16, 2023 at 12:35:06PM -0600, Todd C. Miller wrote: > On Tue, 16 May 2023 19:26:07 +0200, Alexander Bluhm wrote: > > > On Tue, May 16, 2023 at 11:15:31AM -0600, Todd C. Miller wrote: > > > Would it be possible to move the forward declaration of struct tdb > > > to netinet/tcp_var.h so

Relax netlock to shared netlock and push it down to mrt_sysctl_vif()

2023-05-17 Thread Vitaliy Makkoveev
Also read-only access to netlock protected data. Index: sys/netinet/ip_input.c === RCS file: /cvs/src/sys/netinet/ip_input.c,v retrieving revision 1.384 diff -u -p -r1.384 ip_input.c --- sys/netinet/ip_input.c 16 May 2023

Relax netlock to shared netlock and push it down to mrt_sysctl_mfc()

2023-05-17 Thread Vitaliy Makkoveev
mrt_rtwalk_mfcsysctl() performs read-only access to protected data, so rtable_walk() could be called with shared netlock. Index: sys/netinet/ip_input.c === RCS file: /cvs/src/sys/netinet/ip_input.c,v retrieving revision 1.384 diff -u

Unlock ip6_sysctl()

2023-05-17 Thread Vitaliy Makkoveev
Introduce `ip6_soiikey_lock' rwlock(9) to protect `ip6_soiikey'. It accessed only by ip6_sysctl_soiikey() and ip6_sysctl() is the only ip6_sysctl_soiikey() caller so context switch is allowed here. Also remove unused `oldkey' from ip6_sysctl_soiikey(). For IPV6CTL_MRTSTATS, IPV6CTL_MRTMIF and