Re: userdel: remove login group for =uid

2023-05-24 Thread Stuart Henderson
On 2023/05/24 20:00, Omar Polo wrote: > On 2023/05/19 10:24:58 -0600, Todd C. Miller wrote: > > If /etc/usermgmt.conf has a line like: > > > > group =uid > > > > where a new user's group ID in the passwd file is the same as their > > user ID, remove that group when the user is removed.

Re: pfioctl: drop net lock from SIOC{S,G}LIMIT

2023-05-24 Thread Klemens Nanni
On Thu, May 25, 2023 at 03:20:04AM +, Klemens Nanni wrote: > pfsync_in_bus() looks like the only place where the static array > pf_pool_limits[] is accessed without the pf lock, so grab it there. > > Limits themselves are protected by the pf lock and pool(9)s are never > destroyed and have

pfioctl: drop net lock from SIOC{S,G}LIMIT

2023-05-24 Thread Klemens Nanni
pfsync_in_bus() looks like the only place where the static array pf_pool_limits[] is accessed without the pf lock, so grab it there. Limits themselves are protected by the pf lock and pool(9)s are never destroyed and have builtint per-pool locks, so the net lock is not needed. (pf_pool_limits[]

Re: ifconfig description for wireguard peers

2023-05-24 Thread Hrvoje Popovski
On 23.5.2023. 21:13, Klemens Nanni wrote: > On Sat, Jan 14, 2023 at 02:28:27PM +, Stuart Henderson wrote: >> On 2023/01/12 04:49, Mikolaj Kucharski wrote: >>> Hi, >>> >>> Is there anything else which I can do, to help this diff reviwed and >>> increase the chance of getting in? >>> >>> Thread

Re: patch: make CRYPTO_get_ex_new_index not return 0

2023-05-24 Thread Marc Aldorasi
On Wed, May 24, 2023 at 2:16 PM Theo Buehler wrote: > On Tue, May 23, 2023 at 12:40:40PM -0400, Marc Aldorasi wrote: > > The man page for CRYPTO_get_ex_new_index says that "the value 0 is > > reserved for the legacy "app_data" APIs", but the function can still > > return 0, which can cause issues

Re: Virtio fix for testing

2023-05-24 Thread Stefan Fritsch
I forgot to mention that no stress test is necessary. If it boots and the virtio devices work at all, that should be enough. Cheers, Stefan Am 20.05.23 um 15:00 schrieb Stefan Fritsch: Hi, with help from Aaron Mason, I have found the problem responsible for the vioscsi panic on oracle cloud

Re: patch: make CRYPTO_get_ex_new_index not return 0

2023-05-24 Thread Theo Buehler
On Tue, May 23, 2023 at 12:40:40PM -0400, Marc Aldorasi wrote: > The man page for CRYPTO_get_ex_new_index says that "the value 0 is > reserved for the legacy "app_data" APIs", but the function can still > return 0, which can cause issues for programs that use both APIs. The > attached patch

Re: userdel: remove login group for =uid

2023-05-24 Thread Omar Polo
On 2023/05/19 10:24:58 -0600, Todd C. Miller wrote: > If /etc/usermgmt.conf has a line like: > > group =uid > > where a new user's group ID in the passwd file is the same as their > user ID, remove that group when the user is removed. The group is > only removed if it matches the login

Re: Installer: use $(

2023-05-24 Thread Todd C . Miller
On Tue, 23 May 2023 23:41:32 +0200, Christian Weisgerber wrote: > This replaces "$(cat file)" with the ksh construct "$( Admittedly cosmetic. > > I have left the line > > local _sec=$(cat $HTTP_SEC 2>/dev/null) > > unchanged, since it would require > > { local var=$(<$HTTP_SEC); }

Re: rpki-client: prime file modification times to optimize failover from RRDP to RSYNC

2023-05-24 Thread Job Snijders
Dear all, Claudio made some suggestions to pass the desired modification times around in a different way, below is an updated patch proposal. I also added some instrumentation to also adjust GBRs and TAKs. RIPE & APNIC informally indicated some interest in this hack. Kind regards, Job Index:

Re: ix(4): LRO forwarding

2023-05-24 Thread Alexander Bluhm
On Tue, May 23, 2023 at 02:14:57PM +0200, Jan Klemkow wrote: > Hi, > > This diff sets needed offloading flags and the calculated mss to LRO > mbufs in ix(4). Thus, we can forward this packets and process them via > tcp_if_output_tso(). This diff also uses tcp_if_output_tso() in > ip6_forward().

Re: sticky(8): mark S_ISVTX as Dv

2023-05-24 Thread Todd C . Miller
On Wed, 24 May 2023 16:04:13 +0200, Omar Polo wrote: > It makes `man -k any=S_ISVTX' slightly more useful by pointing at > sticky(8) too other than strmode(3); may help if someone (like me :-) > forgot about sticky(8) files. OK millert@ - todd

Re: Installer: use $(

2023-05-24 Thread Klemens Nanni
24 мая 2023 г. 18:05:29 Todd C. Miller : > On Tue, 23 May 2023 22:22:04 -, Klemens Nanni wrote: > >> I'm pointing this out because the error message we'd get provides less >> information with your diff: >> >>     $ echo $(cat /nope) 2>/dev/null >>     cat: /nope: No such file or directory

Re: Installer: use $(

2023-05-24 Thread Florian Obser
makes sense to me, OK florian fwiw On 2023-05-24 08:05 -06, Todd C. Miller wrote: > On Tue, 23 May 2023 22:22:04 -, Klemens Nanni wrote: > >> I'm pointing this out because the error message we'd get provides less >> information with your diff: >> >> $ echo $(cat /nope) 2>/dev/null >>

Re: Installer: use $(

2023-05-24 Thread Todd C . Miller
On Tue, 23 May 2023 22:22:04 -, Klemens Nanni wrote: > I'm pointing this out because the error message we'd get provides less > information with your diff: > > $ echo $(cat /nope) 2>/dev/null > cat: /nope: No such file or directory > vs. > echo $(< /nope) 2>/dev/null >

sticky(8): mark S_ISVTX as Dv

2023-05-24 Thread Omar Polo
It makes `man -k any=S_ISVTX' slightly more useful by pointing at sticky(8) too other than strmode(3); may help if someone (like me :-) forgot about sticky(8) files. ok? diff /usr/src commit - beb1c6c70ae1e2a18abd99274d326b36106135ad path + /usr/src blob -