patch: suppress spurious symlink tranfer log msgs

2023-06-26 Thread Lyndon Nerenberg (VE7TFX/VE6BBM)
rsync logs every symlink it encounters as a transfer, even when the local target already exists. This patch moves the log statement into the conditional where it belongs. --lyndon Index: uploader.c === RCS file:

Re: btrace(8) allow to store kstack in a map

2023-06-26 Thread Klemens Nanni
On Mon, Jun 26, 2023 at 10:52:20PM +0200, Claudio Jeker wrote: > count() is strange since it only works on maps (at least from what I > figured out). I need to double check how min() and max() work. Since the > usage also seems non-intuitive. > > I find the documentation of bt(5) rather weak. So

Re: btrace(8) allow to store kstack in a map

2023-06-26 Thread Claudio Jeker
On Mon, Jun 26, 2023 at 04:53:45PM +, Klemens Nanni wrote: > On Mon, Jun 26, 2023 at 05:24:53PM +0200, Claudio Jeker wrote: > > I created this simple btrace script to help find malloc(9) leaks but > > it did not work. First step was adding kstack support to the map > > implementation. But then

Re: Possible typo in pf NAT FAQ

2023-06-26 Thread Ashlen
This diff is incorrect, I should've tested it before sending it. Thank you to everyone that replied and sorry if it was a bother/inconvenience. On Mon, 19 Jun 2023 08:07 +0200, Alexandr Nedvedicky wrote: > Hello, > > On Sun, Jun 18, 2023 at 06:29:28PM -0600, Ashlen wrote: > > On Sun, 18 Jun 2023

Re: pax: truncate times to MAX_TIME_T, not INT_MAX

2023-06-26 Thread Otto Moerbeek
On Mon, Jun 26, 2023 at 11:09:10AM -0600, Todd C. Miller wrote: > If the mtime in the file header is larger than MAX_TIME_T, trucate > it to MAX_TIME_T, not INT_MAX. The existing assignment dates from > before we had a MAX_TIME_T definition in pax. How strange the checks use MAX_TIME_T as a

Re: inpcb sip hash mutex contention

2023-06-26 Thread Alexander Bluhm
On Sat, Jun 24, 2023 at 11:20:50AM +1000, David Gwynne wrote: > maybe it's time to re-evaluate siphash? In one of our products we have replaced SipHash with xxHash. https://xxhash.com/ https://github.com/Cyan4973/xxHash bluhm

pax: truncate times to MAX_TIME_T, not INT_MAX

2023-06-26 Thread Todd C . Miller
If the mtime in the file header is larger than MAX_TIME_T, trucate it to MAX_TIME_T, not INT_MAX. The existing assignment dates from before we had a MAX_TIME_T definition in pax. OK? - todd Index: cpio.c === RCS file:

Re: btrace(8) allow to store kstack in a map

2023-06-26 Thread Klemens Nanni
On Mon, Jun 26, 2023 at 05:24:53PM +0200, Claudio Jeker wrote: > I created this simple btrace script to help find malloc(9) leaks but > it did not work. First step was adding kstack support to the map > implementation. But then it still did not work because btrace did not > enable the kstack

ldpd: use new ibuf api

2023-06-26 Thread Claudio Jeker
Adjust ldpd to follow the new ibuf API. Diff is simple but as usual I could not test it out so please test. -- :wq Claudio Index: hello.c === RCS file: /cvs/src/usr.sbin/ldpd/hello.c,v retrieving revision 1.58 diff -u -p -r1.58

Re: posix_spawn(3): explain that handling NULL envp is an extension

2023-06-26 Thread Theo Buehler
> -.An \ Shouten Aq Mt e...@freebsd.org > +.An \ Schouten Aq Mt e...@freebsd.org Committed. Thanks

Re: posix_spawn(3): explain that handling NULL envp is an extension

2023-06-26 Thread Todd C . Miller
On Mon, 26 Jun 2023 17:24:38 +0200, Paul de Weerd wrote: > Having never heard of posix_spawn(3), I read the full manpage and > (besides wondering "what's the point"), found that it's misspelled Ed > Schouten's name: Yes, that should be fixed. - todd

btrace(8) allow to store kstack in a map

2023-06-26 Thread Claudio Jeker
I created this simple btrace script to help find malloc(9) leaks but it did not work. First step was adding kstack support to the map implementation. But then it still did not work because btrace did not enable the kstack reporting for the probe. This turned out to be an issue with the if ()

Re: posix_spawn(3): explain that handling NULL envp is an extension

2023-06-26 Thread Paul de Weerd
Having never heard of posix_spawn(3), I read the full manpage and (besides wondering "what's the point"), found that it's misspelled Ed Schouten's name: Index: posix_spawn.3 === RCS file: /cvs/src/lib/libc/gen/posix_spawn.3,v

Re: posix_spawn(3): explain that handling NULL envp is an extension

2023-06-26 Thread Lucas de Sena
On 2023-06-26, Marc Espie wrote: > Note that a NULL environment is undefined behavior according to POSIX. > If you read the OpenGroup description, it very clearly states that > envp is a pointer to a NULL terminated array. > > Does GNU/Linux at least document that passing a NULL pointer means no

Re: eigrpd: use new ibuf API

2023-06-26 Thread Theo Buehler
On Mon, Jun 26, 2023 at 12:22:16PM +0200, Claudio Jeker wrote: > This diff changes some parts of eigrpd to use the new ibuf API. > There is one ibuf_seek() left in packet.c since the changes done to the > header there are not as trivial as in any other daemon. So that part I > left out for now.

eigrpd: use new ibuf API

2023-06-26 Thread Claudio Jeker
This diff changes some parts of eigrpd to use the new ibuf API. There is one ibuf_seek() left in packet.c since the changes done to the header there are not as trivial as in any other daemon. So that part I left out for now. The suggested changes on the other hand are simple. Again if someone

Re: posix_spawn(3): explain that handling NULL envp is an extension

2023-06-26 Thread Marc Espie
On Sun, Jun 25, 2023 at 07:07:33PM -0300, Lucas de Sena wrote: > The manual already describes how posix_spawn(3) behaves when passing it > a NULL envp, but does not make it clear that it is an OpenBSD extension: > > > If envp is NULL, the environment is passed unchanged from the parent > >

ldapd better bufferevent error callback

2023-06-26 Thread Claudio Jeker
Noticed this since an ldapd ran out of memory and the error printed by the callback is just not helpful. So lets try to improve this. I think errno is not clobbered so log_warn() should work and then also add an indication if it is read or write. -- :wq Claudio Index: conn.c

Re: posix_spawn(3): explain that handling NULL envp is an extension

2023-06-26 Thread Jason McIntyre
On Sun, Jun 25, 2023 at 07:07:33PM -0300, Lucas de Sena wrote: > The manual already describes how posix_spawn(3) behaves when passing it > a NULL envp, but does not make it clear that it is an OpenBSD extension: > > > If envp is NULL, the environment is passed unchanged from the parent > >

Re: ports: brz Distributed version control system based on bzr

2023-06-26 Thread Stuart Henderson
wrong mailing list, moved to ports@ & reply-to set. On 2023/06/24 23:02, Alfred Morgan wrote: > bzr got deleted from openbsd ports about 2 years ago (died along with > Python2). > https://cvsweb.openbsd.org/ports/devel/bzr/Attic/Makefile?only_with_tag=HEAD > bzr was superseded by brz but brz