Re: link mbufs/inpcbs to pf_states, not pf_state_keys

2023-09-29 Thread Alexander Bluhm
On Tue, Aug 22, 2023 at 06:30:31AM +0200, Alexandr Nedvedicky wrote: > Currently we have something like this: > > { mbuf, pcb } <-> state key <-> { state, state ... } > > with this diff we get to: > > { mbuf, pcb } <-> state <-> state key > > Basically when we do process

Re: pfkey: forward after validation

2023-09-29 Thread Alexander Bluhm
On Fri, Sep 29, 2023 at 01:46:40AM +0200, Tobias Heider wrote: > Like with route messages we should really only forward pfkey messages > that made it past the validation step. This fixes a lot of possible > crashes in ipsecctl -m. > > ok? OK bluhm@ > diff /home/user/got/co/src > commit - 1ce2bc2

Re: sysupgrade: omit default sets answer

2023-09-29 Thread Theo de Raadt
It does not seem crucial to commit this just before a release. Klemens Nanni wrote: > On Fri, Sep 29, 2023 at 05:28:46PM +0200, Florian Obser wrote: > > On 2023-09-29 14:41 UTC, Klemens Nanni wrote: > > > The response file contains only to non-defaults, except for > > > Set name(s)? (or 'abor

Re: sysupgrade: omit default sets answer

2023-09-29 Thread Klemens Nanni
On Fri, Sep 29, 2023 at 05:28:46PM +0200, Florian Obser wrote: > On 2023-09-29 14:41 UTC, Klemens Nanni wrote: > > The response file contains only to non-defaults, except for > > Set name(s)? (or 'abort' or 'done') [done] done > > > > which is the hardcoded default since 2009: > >

Re: sysupgrade: omit default sets answer

2023-09-29 Thread Florian Obser
On 2023-09-29 14:41 UTC, Klemens Nanni wrote: > The response file contains only to non-defaults, except for > Set name(s)? (or 'abort' or 'done') [done] done > > which is the hardcoded default since 2009: > ask "Set name(s)? (or 'abort' or 'done')" done > > We pass it since r1.

sysupgrade: omit default sets answer

2023-09-29 Thread Klemens Nanni
The response file contains only to non-defaults, except for Set name(s)? (or 'abort' or 'done') [done] done which is the hardcoded default since 2009: ask "Set name(s)? (or 'abort' or 'done')" done We pass it since r1.23 in 2019 Let sysupgrade(8) create auto_upgrade.co

Unused cipher_get_keyiv_len()

2023-09-29 Thread Theo Buehler
This function is unused since the commit below. commit f1cc710a366b47da6f96be2110292f8cd0933e7e Author: djm Date: Sun Apr 30 23:13:25 2017 + remove compat20/compat13/compat15 variables ok markus@ Index: cipher.c ===