Re: Term::Cap full revamp

2023-10-22 Thread Matthieu Herrb
On Fri, Oct 20, 2023 at 11:52:25AM +0200, Marc Espie wrote: > I guess i will probably leave it alone after this. > This does quite a few things compared to my former patches. > > - totally get rid of eval, it doen't make sense anymore > - declare variables before they get used, which tends to >

Re: Prevent off-by-one accounting hang in out-of-swap situations

2023-10-22 Thread Martin Pieuchot
On 22/10/23(Sun) 20:29, Miod Vallat wrote: > > On 21/10/23(Sat) 14:28, Miod Vallat wrote: > > > > Stuart, Miod, I wonder if this also help for the off-by-one issue you > > > > are seeing. It might not. > > > > > > It makes the aforementioned issue disappear on the affected machine. > > > >

Re: Prevent off-by-one accounting hang in out-of-swap situations

2023-10-22 Thread Miod Vallat
> On 21/10/23(Sat) 14:28, Miod Vallat wrote: > > > Stuart, Miod, I wonder if this also help for the off-by-one issue you > > > are seeing. It might not. > > > > It makes the aforementioned issue disappear on the affected machine. > > Thanks at lot for testing! Spoke too soon. I have just hit

Re: nfsd: don't clear SB_NOINTR flag

2023-10-22 Thread Vitaliy Makkoveev
On Fri, Oct 20, 2023 at 10:51:46PM +0200, Alexander Bluhm wrote: > On Mon, Oct 16, 2023 at 10:17:50PM +0300, Vitaliy Makkoveev wrote: > > This socket comes from userland, so this flag is never set. This makes > > SB_NOINTR flag immutable, because we only set this bit on NFS client > > socket

Re: relayd does not delete control socket on shutdown

2023-10-22 Thread Theo de Raadt
Otto Moerbeek wrote: > On Sat, Oct 21, 2023 at 10:40:45PM +0300, Kapetanakis Giannis wrote: > > > On 21/10/2023 20:39, Florian Obser wrote: > > > Which was 8 years ago. I don't understand why you see a change in 7.4. > > > > > > Anyway, we decided to not clean up control sockets in any of our

Re: relayd does not delete control socket on shutdown

2023-10-22 Thread Otto Moerbeek
On Sat, Oct 21, 2023 at 10:40:45PM +0300, Kapetanakis Giannis wrote: > On 21/10/2023 20:39, Florian Obser wrote: > > Which was 8 years ago. I don't understand why you see a change in 7.4. > > > > Anyway, we decided to not clean up control sockets in any of our > > privsep daemons because leaving

Re: malloc: more info in error message for write-after-free with option D

2023-10-22 Thread Masato Asou
Hi, I wanted an extension to malloc() that would report the caller of all memory leaks. It works fine for me! ok asou@ -- ASOU Masato From: Otto Moerbeek Date: Tue, 10 Oct 2023 12:39:00 +0200 > Hi, > > This diff adds better error reporting for write-after-free or the more > general write of