signed overflow in atan2

2018-02-14 Thread Eitan Adler
>31))>0x7ff0)|| ((iy|((ly|-ly)>>31))>0x7ff0)) /* x or y is NaN */ return x+y; - if(((hx-0x3ff0)|lx)==0) return atan(y); /* x=1.0 */ + if(hx==0x3ff0&==0) return atan(y); /* x=1.0 */ m = ((hy>>31)&1)|((hx>>30)&2); /* 2*sign(x)+sig

Re: init(8): unifdef LOGIN_CAP

2018-01-06 Thread Eitan Adler
On 6 January 2018 at 17:03, Eitan Adler <li...@eitanadler.com> wrote: > On 6 January 2018 at 05:48, Todd C. Miller <todd.mil...@sudo.ws> wrote: >> There's no need for a compile-time knob to control the use of >> login.conf. > > What about usr.bin/login, us

Re: init(8): unifdef LOGIN_CAP

2018-01-06 Thread Eitan Adler
On 6 January 2018 at 05:48, Todd C. Miller <todd.mil...@sudo.ws> wrote: > There's no need for a compile-time knob to control the use of > login.conf. What about usr.bin/login, usr.bin/passwd, usr.bin/newgrp, etc? -- Eitan Adler

Re: libedit patch

2014-05-15 Thread Eitan Adler
minor changes were needed). A true vendor import would be sufficient as well. :) -- Eitan Adler

libedit patch

2014-05-14 Thread Eitan Adler
: + retval = history_save_fp(h, va_arg(va, FILE *)); + if (retval == -1) + he_seterrev(ev, _HE_HIST_WRITE); break; case H_PREV_EVENT: -- Eitan Adler

Re: ip6opt.c

2014-02-06 Thread Eitan Adler
On Tue, Feb 4, 2014 at 8:54 PM, Alexander Bluhm alexander.bl...@gmx.net wrote: On Tue, Feb 04, 2014 at 08:35:02PM -0500, Eitan Adler wrote: Hi all, The following bug was recently fixed in DragonFlyBSD and FreeBSD: libc/net: Fix issue in inet6_opt_init() (from RFC 3542): * The RFC says

ip6opt.c

2014-02-04 Thread Eitan Adler
3) - 1; } -- Eitan Adler

Re: pf.os: add additional fingerprints

2013-12-03 Thread Eitan Adler
On Tue, Dec 3, 2013 at 3:55 AM, Stuart Henderson st...@openbsd.org wrote: On 2013/12/02 23:39, Eitan Adler wrote: Hi all, This is a simple enough patch: Index: pf.os ==*= RCS file: /cvs/src/etc/pf.os,v retrieving revision

pf.os: add additional fingerprints

2013-12-02 Thread Eitan Adler
:1:64:N,W3,N,N,T0,N,N,S,M*: Solaris:8:RFC1323:Solaris 8 RFC1323 -- Eitan Adler

1 31 and related bugs

2013-11-23 Thread Eitan Adler
examples. -- Eitan Adler

Small patch for fmt(1)

2013-11-18 Thread Eitan Adler
) { if (!isupper(*line++)) -- Eitan Adler

Re: Small patch for fmt(1)

2013-11-18 Thread Eitan Adler
On Mon, Nov 18, 2013 at 11:09 PM, Philip Guenther guent...@gmail.com wrote: On Mon, Nov 18, 2013 at 7:16 PM, Eitan Adler li...@eitanadler.com wrote: The argument passed to isupper must be The argument to isupper() must be EOF or representable as an unsigned char; otherwise, the result

rs, jot: missing headers

2013-11-14 Thread Eitan Adler
patches get mangled: http://people.freebsd.org/~eadler/files/o/0001.jot.diff and http://people.freebsd.org/~eadler/files/o/0002.rs.diff ] -- Eitan Adler FreeBSD Source, Ports, Doc committer

Re: rm(1) static addition

2013-04-28 Thread Eitan Adler
On 28 April 2013 15:25, Marc Espie es...@nerim.net wrote: On Sat, Apr 27, 2013 at 09:12:21AM -0400, Eitan Adler wrote: FWIW I don't believe this sort of patch significantly affects debugging because that should be done with -O0 -g anyways. Bwahahaha You're lucky to not run into compiler

Re: rm(1) static addition

2013-04-27 Thread Eitan Adler
, Otto Moerbeek wrote: On Sat, Apr 27, 2013 at 01:08:06AM -0400, Eitan Adler wrote: Adding static to internal function allows the compiler to better detect dead code (functions, variables, etc) and makes it easier for the compiler to optimize; e.g., since it knows a function will only

rm(1) static addition

2013-04-26 Thread Eitan Adler
] || ((a)[1] == '.' !(a)[2]))) -void +static void checkdot(char **argv) { char *p, **save, **t; @@ -411,7 +411,7 @@ } } -void +static void usage(void) { (void)fprintf(stderr, usage: %s [-dfiPRr] file ...\n, __progname); -- Eitan Adler