The vnode definition on vnode(9) is missing the v_uvcount field.
Also, some of the fields use a tab between the data type and name while
others use spaces. The same is true for the code at /src/sys/sys/vnode.h
Index: share/man/man9/vnode.9
When building OpenBSD with the ACPIVIDEO_DEBUG option set the
compilation fails:
cc1: warnings being treated as errors
/usr/src/sys/dev/acpi/acpivideo.c: In function 'acpivideo_set_policy':
/usr/src/sys/dev/acpi/acpivideo.c:136: warning: format '%X' expects type
'unsigned int', but argument 3 has
On Thu, 2 Apr 2015 18:51:38 +0200
Martin Pieuchot wrote:
> Even if that's true, nothing prevent us to commit this diff first, as
> long as it does not introduce regression and then work on the possible
> refactoring needed to support debounce packets :)
That is great to hear.
Because the way pms_
On Wed, 01 Apr 2015 21:23:15 +0200
Ulf Brosziewski wrote:
> Yes, without some refactoring there won't be an elegant way.
> pms_sync_elantech_v2 encodes some sync state in the 'flags' field
> (ELANTECH_F_2FINGER_PACKET), but doing the same in the v3/CRC case might
> be ugly.
Admittedly I am biased
On Wed, 01 Apr 2015 20:05:46 +0200
Ulf Brosziewski wrote:
> Hi,
>
> there might be a problem. The Linux driver for that touchpad type also
> accepts "debounce packets", which have the same format as for the
> non-crc version. I have no idea whether that is correct and if those
> packets do occur
On Wed, 1 Apr 2015 18:02:59 +0200
Stefan Sperling wrote:
> Interesting, thanks.
>
> If you don't hear from anyone else about this please ask me again in
> a week from now. I can test on v3 hardware by then but not any earlier.
>
> Please write this as if-else instead of switch:
>
> > @@ -2271,1
This diff adds support for Elantech v3 touchpads using the "crc_enabled"
integrity check. I tested this patch with my Elantech v3 touchpad using
firmware version 0x454f00, it now works correctly.
Other hardware versions should not be affected by this change. I could
not check if this introduces re