Is there something wrong with my diff? I don't see it.
Please review it.
Bump.
gzip violates wpath if you tell it to extract stdin and restore the
original filename.
The original mail didn't go through after 12 hours so I'm resending it,
sorry if you get 2.
Index: regress/usr.bin/gzip/Makefile
===
RCS file:
It appears that all the fdata() calls use fmt strings supplied at
compile time so this patch makes all the same assumptions, the only
change is that it uses the right functions for the job.
Index: usr.sbin/tcpdump/smbutil.c
===
f(s));
- p = strchr(fmt,']');
- strncpy(s,fmt,p-fmt);/* XXX? */
- fmt = p+1;
+ p = memccpy(s, fmt, ']', sizeof(s));
+ fmt += p-s;
+ *--p = '\0';
buf = fdata1(buf,s,maxbuf);
if (buf == NULL)
return(NULL);
On 21/04/13 12:07AM, Guilherme Janczak wr
The code was a bit odd.
I'm bundling a trivial style change that makes the "return 0" statement into
"return NULL".
Additionally, there is a very similar function called str_save() which
could be implemented as a call to this str_nsave() function.
Would OpenBSD mind if I sent a patch to do
