chilepeso in units(1)

2023-04-12 Thread Jan Stary
An apparent typo was introduced in http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/units/units.lib.diff?r1=1.144=1.145=h Does nobody use units(1) on their Chilean vacation anymore? Jan Index: units.lib === RCS file:

Re: lidaction on an M1 macbook

2023-04-12 Thread Jan Stary
> > aplsmc(4) provides support for the lid position sensor. Should that be mentioned in aplsmc(4)? Index: aplsmc.4 === RCS file: /cvs/src/share/man/man4/man4.arm64/aplsmc.4,v retrieving revision 1.2 diff -u -p -r1.2 aplsmc.4 ---

Re: lidaction on an M1 macbook

2023-04-12 Thread Jan Stary
> > o On arm64, add a machdep.lidaction sysctl(8) > > for aplsmc(4) Apple Silicon laptops. Should that be mentioned in the arm64 examples/sysctl.conf as on other such architectures? Index: etc/etc.arm64/sysctl.conf === RCS file:

Re: iostat's four drives by default

2022-10-06 Thread Jan Stary
ping On Sep 18 18:16:45, h...@stare.cz wrote: > Better diff: remove the comment as well. > > > Index: iostat.8 > === > RCS file: /cvs/src/usr.sbin/iostat/iostat.8,v > retrieving revision 1.28 > diff -u -p -r1.28 iostat.8 > ---

Re: iostat's four drives by default

2022-09-18 Thread Jan Stary
Better diff: remove the comment as well. Index: iostat.8 === RCS file: /cvs/src/usr.sbin/iostat/iostat.8,v retrieving revision 1.28 diff -u -p -r1.28 iostat.8 --- iostat.817 Sep 2022 11:39:09 - 1.28 +++ iostat.818

iostat's four drives by default

2022-09-18 Thread Jan Stary
By default, iostat displays the first for drives. It would be less surprising if it displayed all drives. It seems that the reason to display four is that it fits into the 80 columns (that is, with -d; otherwise, the cpu and tty display make the line overflow anyway). Jan Index:

iostat.8 wording

2022-09-15 Thread Jan Stary
I believe this reads a little bit better. Jan Index: iostat.8 === RCS file: /cvs/src/usr.sbin/iostat/iostat.8,v retrieving revision 1.27 diff -u -p -r1.27 iostat.8 --- iostat.87 Sep 2018 12:54:44 - 1.27 +++

Re: obsolete dump options syntax

2022-06-02 Thread Jan Stary
On Jun 02 07:16:52, dera...@openbsd.org wrote: > Your diff completely breaks a majority of the ways people use it. Does that mean people mostly use the undocumented obsolete syntax that obsolete() keeps supported? > Jan Stary wrote: > > &g

Re: obsolete dump options syntax

2022-06-02 Thread Jan Stary
On Jun 02 14:36:16, h...@stare.cz wrote: > # dump /home > dump: option requires an argument -- h > > # dump /music > dump: option requires an argument -- s > > # dump /media > dump: option requires an argument -- d > > What? Before passing

dump(8) wording

2022-06-02 Thread Jan Stary
The following wording of dump(8) can IMHO be be simplified without any loss: Rewinding or ejecting tape features after a close operation on a tape device depend on the name of the tape unit device used. I am not a native speaker; but if I parse that right, what "features" are

obsolete dump options syntax

2022-06-02 Thread Jan Stary
# dump /home dump: option requires an argument -- h # dump /music dump: option requires an argument -- s # dump /media dump: option requires an argument -- d What? Before passing its options to getopt(), dump's main() processes them with

Re: apmd(8): reconnecting AC, not battery

2022-05-28 Thread Jan Stary
On May 28 10:34:35, s...@spacehopper.org wrote: > On 2022/05/28 06:52, Jason McIntyre wrote: > > On Fri, May 27, 2022 at 07:19:37PM +0200, Jan Stary wrote: > > > apmd says: > > > > > > When the power status changes (battery is connected or disconnected), >

apmd(8): reconnecting AC, not battery

2022-05-27 Thread Jan Stary
apmd says: When the power status changes (battery is connected or disconnected), apmd fetches the current status and reports it via syslog(3) with logging facility LOG_DAEMON. Is "battery" really meant here? Should that be the AC power? Batteries are typically not being reconnected while

Re: apm -m means one of two things now

2022-02-11 Thread Jan Stary
On Feb 10 16:33:20, j...@juef.net wrote: > (Thu, 10 Feb 14:59) Jan Stary: > > With the recent change to apm -m, > > reporting either the battery lifetime > > or the estimated time to charge (thank you), > > the manpage seems to have been left behind. > > > >

apm -m means one of two things now

2022-02-10 Thread Jan Stary
With the recent change to apm -m, reporting either the battery lifetime or the estimated time to charge (thank you), the manpage seems to have been left behind. While here, tweak some of the wording: - "in minutes" or "in percent" is not parenthetical; say it explicitly - surely -a displays the

Re: request for testing: malloc and large allocations

2022-02-05 Thread Jan Stary
On Feb 05 17:35:46, o...@drijf.net wrote: > On Sat, Feb 05, 2022 at 05:22:50PM +0100, Jan Stary wrote: > > > On Feb 02 00:04:37, alexander.bl...@gmx.net wrote: > > > On Tue, Feb 01, 2022 at 08:00:36AM +0100, Otto Moerbeek wrote: > > > > > A

Re: request for testing: malloc and large allocations

2022-02-05 Thread Jan Stary
On Feb 02 00:04:37, alexander.bl...@gmx.net wrote: > On Tue, Feb 01, 2022 at 08:00:36AM +0100, Otto Moerbeek wrote: > > > Are you running with any malloc flags? > > > > This bug report enabled me to find a bug that would pop up if G mode > > is enabled. > > > > New diff below. New tests

Re: locale-specific collation sequence?

2022-02-01 Thread Jan Stary
Intended to affect collation order. It may for example affect alphabetic sorting, regular expressions including equivalence classes, and the strcoll(3) and strxfrm(3) functions. so only in strcoll(3) does one eventualy read that the locale has in fact no effect on collation. That was

locale-specific collation sequence?

2022-02-01 Thread Jan Stary
Looking at the source, it's simply strcoll(). Jan Index: bin/expr/expr.1 === RCS file: /cvs/src/bin/expr/expr.1,v retrieving revision 1.24 diff -u -p -r1.24 expr.1 --- bin/expr/expr.1 16 Aug 2017 20:10:58 -

unistd.h already declares optind and friends

2022-02-01 Thread Jan Stary
Index: yppoll/yppoll.c === RCS file: /cvs/src/usr.sbin/yppoll/yppoll.c,v retrieving revision 1.15 diff -u -p -r1.15 yppoll.c --- yppoll/yppoll.c 16 Jan 2015 06:40:22 - 1.15 +++ yppoll/yppoll.c 1 Feb 2022 22:35:00

Re: kern.file in sysctl(8)

2021-12-24 Thread Jan Stary
On Dec 24 10:20:03, h...@stare.cz wrote: > Similarly for kern.proc and ps(1). In fact, warnx("use netstat to view %s", string); warnx("use dmesg to view %s", string); warnx("use ps to view %s information", string); warnx("use vmstat or systat to view %s information", warnx("use fstat to view %s

Re: kern.file in sysctl(8)

2021-12-24 Thread Jan Stary
Similarly for kern.proc and ps(1). On Dec 24 10:18:15, h...@stare.cz wrote: > The sysctl(2) manpage also lists the corresponding sysctl(8) variables: > > Information may be retrieved and set using the sysctl(8) utility; > the variable names used by this utility are given here in parentheses.

kern.file in sysctl(8)

2021-12-24 Thread Jan Stary
The sysctl(2) manpage also lists the corresponding sysctl(8) variables: Information may be retrieved and set using the sysctl(8) utility; the variable names used by this utility are given here in parentheses. Among these is kern.file, which, understandably, just points to fstat(8). Would it

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-05 Thread Jan Stary
On Dec 04 14:28:23, h...@stare.cz wrote: > On Dec 04 12:23:42, h...@stare.cz wrote: > > On Dec 01 09:07:43, h...@stare.cz wrote: > > > > > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > > > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > > > > > interested in

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-04 Thread Jan Stary
On Dec 04 12:23:42, h...@stare.cz wrote: > On Dec 01 09:07:43, h...@stare.cz wrote: > > > > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > > > > interested in squashing the remaining bugs. Please test with your

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-04 Thread Jan Stary
On Dec 01 09:07:43, h...@stare.cz wrote: > > > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > > > interested in squashing the remaining bugs. Please test with your > > > > > usual > > > > > setup & report back. >

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-01 Thread Jan Stary
> > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > > interested in squashing the remaining bugs. Please test with your usual > > > > setup & report back. > > > > > > Thanks to all the testers, here's a new version

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-11-30 Thread Jan Stary
On Nov 30 10:40:25, s...@spacehopper.org wrote: > On 2021/11/29 22:50, Martin Pieuchot wrote: > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > interested in squashing the remaining bugs. Please test with your usual > >

Re: Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Jan Stary
> > Stop building the kernel with -Wno-uninitialized on clang archs. > > This hides real problems like the recently fixed uninitialised memory > > use in pf and igc. > > > > [-Wsometimes-uninitialized] /sys/arch/arm/arm/cpu.c:352:6: warning: > > variable 'ci' is used uninitialized whenever 'if'

Re: smtpd: LINE_MAX might not be enough for a response

2021-11-24 Thread Jan Stary
On Nov 25 01:38:35, h...@stare.cz wrote: > On Nov 24 14:47:48, j...@maudlin.dev wrote: > > > > Jan Stary writes: > > > smtpd just failed to parse a SMTP response (below), > > > saying 'line too long'. > > > > > > Looking at the sourc

Re: smtpd: LINE_MAX might not be enough for a response

2021-11-24 Thread Jan Stary
On Nov 24 14:47:48, j...@maudlin.dev wrote: > > Jan Stary writes: > > smtpd just failed to parse a SMTP response (below), > > saying 'line too long'. > > > > Looking at the source, this seems to be parse_smtp_response() in util.c, > > which errors out

smtpd: LINE_MAX might not be enough for a response

2021-11-24 Thread Jan Stary
This is current/amd64 on a PC. smtpd just failed to parse a SMTP response (below), saying 'line too long'. Looking at the source, this seems to be parse_smtp_response() in util.c, which errors out right away with if (len >= LINE_MAX) return "line too long"; Apparently,

Re: extern optind etc already declared

2021-11-22 Thread Jan Stary
On Nov 23 00:10:08, h...@stare.cz wrote: > extern optind and friends are already declared > once unistd.h is included, to these can be removed. This is the same for usr.bin except ssh. Jan Index: usr.bin//env/env.c === RCS

extern optind etc already declared in unistd.h

2021-11-22 Thread Jan Stary
extern optind and friends are already declared once unistd.h is included, to these can be removed. This is the usr.sbin part; I am not touching nsd and other third-party stuff. Jan Index: usr.sbin//yppoll/yppoll.c === RCS

Re: New hw.perfpolicy behavior

2021-11-18 Thread Jan Stary
On Nov 10 00:21:59, h...@stare.cz wrote: > On Nov 02 12:30:56, dera...@openbsd.org wrote: > > Paul de Weerd wrote: > > > > > A recent commit by Theo changed the hw.perfpolicy behavior to always > > > run at full speed when AC power is on. This means that my workstation > > > (and servers, once

Re: cwm: fix invalid KeyCode in configuration

2021-11-18 Thread Jan Stary
On Nov 19 00:01:04, stef...@sdaoden.eu wrote: > Jan Stary wrote in > : > |On Nov 18 20:13:03, h...@stare.cz wrote: > |> On Nov 16 21:33:31, hen...@camandro.org wrote: > |>> I've tried to setup a line like: > |>> bind-key XF86MonBrightnessDown &quo

Re: cwm: fix invalid KeyCode in configuration

2021-11-18 Thread Jan Stary
On Nov 18 20:13:03, h...@stare.cz wrote: > On Nov 16 21:33:31, hen...@camandro.org wrote: > > I've tried to setup a line like: > > bind-key XF86MonBrightnessDown "" > > in my .cwmrc and the result was that no key event was sent to my windows. > > Please excuse my X ignorance, but shouldn't

Re: cwm: fix invalid KeyCode in configuration

2021-11-18 Thread Jan Stary
On Nov 16 21:33:31, hen...@camandro.org wrote: > I've tried to setup a line like: > bind-key XF86MonBrightnessDown "" > in my .cwmrc and the result was that no key event was sent to my windows. Please excuse my X ignorance, but shouldn't XF86MonBrightnessDown be catched by the X server (to take

Re: Fix vi(1) recovery - new method

2021-11-16 Thread Jan Stary
On Oct 09 20:26:13, tro...@kagu-tsuchi.com wrote: > This is a new attempt at fixing vi(1) recovery by actually writing > to the recovery file. Previously I restored the SIGALRM method that > was deleted in the 90's but wondered if that was still the best way > to handle this. Checking and

Re: locale in expr(1)

2021-11-15 Thread Jan Stary
On Nov 15 17:58:38, schwa...@usta.de wrote: > Hi Marc, > > Marc Espie wrote on Mon, Nov 15, 2021 at 05:06:23PM +0100: > > On Mon, Nov 15, 2021 at 03:43:47PM +0100, Jan Stary wrote: > >> On Nov 10 18:46:08, h...@stare.cz wrote: > >>> On Nov 10 18:15:44, h...@st

Re: locale in expr(1)

2021-11-15 Thread Jan Stary
Here's a try (see below); one sentence one line while here. I would also replace 'results' with 'result' everywhere, but I am not a native speaker. Jan On Nov 10 18:46:08, h...@stare.cz wrote: > On Nov 10 18:15:44, h...@stare.cz wrote: > > expr(1) says > > > > expr1 {=, >, >=, <, <=,

Re: extern int optind etc already declared in unistd.h

2021-11-15 Thread Jan Stary
(Does anyone want to commit this please?) On Nov 10 09:31:57, mill...@openbsd.org wrote: > On Wed, 10 Nov 2021 17:29:55 +0100, Jan Stary wrote: > > > With included, there is no need > > to declare extern int optind and friends again. > > Right, most of this is old cod

Re: obsolete()

2021-11-10 Thread Jan Stary
On Nov 10 19:10:59, h...@stare.cz wrote: > https://marc.info/?l=openbsd-tech=163389736000516=2 > > Not related to the original head -5 -n 6 discussion, > but a copy of obsolete() exists in usr.bin/join/ > (and seems to be the only instance, AFAIG). Ah, that one seems to be specific to the

obsolete()

2021-11-10 Thread Jan Stary
https://marc.info/?l=openbsd-tech=163389736000516=2 Not related to the original head -5 -n 6 discussion, but a copy of obsolete() exists in usr.bin/join/ (and seems to be the only instance, AFAIG). Jan

Re: locale in expr(1)

2021-11-10 Thread Jan Stary
On Nov 10 18:15:44, h...@stare.cz wrote: > expr(1) says > > expr1 {=, >, >=, <, <=, !=} expr2 > > Returns the results of integer comparison if both arguments > are decimal integers; otherwise, returns the results of > string comparison using the locale-specific collation

locale in expr(1)

2021-11-10 Thread Jan Stary
expr(1) says expr1 {=, >, >=, <, <=, !=} expr2 Returns the results of integer comparison if both arguments are decimal integers; otherwise, returns the results of string comparison using the locale-specific collation sequence. The result of each comparison is 1

extern int optind etc already declared in unistd.h

2021-11-10 Thread Jan Stary
With included, there is no need to declare extern int optind and friends again. Jan Index: usr.sbin/amd/amd/get_args.c === RCS file: /cvs/src/usr.sbin/amd/amd/get_args.c,v retrieving revision 1.15 diff -u -p -r1.15

Re: arm64: new gpiokeys(4)

2021-11-10 Thread Jan Stary
On Nov 10 13:20:45, k...@openbsd.org wrote: > On Wed, Nov 10, 2021 at 12:07:37AM +0100, Jan Stary wrote: > > On Nov 09 15:43:04, k...@openbsd.org wrote: > > > This populates `systat sensors' with the correct lid status on my > > > Pinebook Pro: > > >

locale in who(1)

2021-11-10 Thread Jan Stary
Why does who(1) need to setlocale()? Jan Index: who.c === RCS file: /cvs/src/usr.bin/who/who.c,v retrieving revision 1.30 diff -u -p -r1.30 who.c --- who.c 12 Jul 2021 15:09:20 - 1.30 +++ who.c 10 Nov

Re: New hw.perfpolicy behavior

2021-11-09 Thread Jan Stary
On Nov 10 00:21:59, h...@stare.cz wrote: > Regarding C states, this machine has > > acpicpu0 at acpi0: C3(350@96 mwait.1@0x20), C2(500@64 mwait.1@0x10), > C1(1000@1 mwait.1), PSS > > I suppose the cpu supports C1, C2, C3, but can someone please kindly > explain (or point to an explanation of)

Re: New hw.perfpolicy behavior

2021-11-09 Thread Jan Stary
On Nov 02 12:30:56, dera...@openbsd.org wrote: > Paul de Weerd wrote: > > > A recent commit by Theo changed the hw.perfpolicy behavior to always > > run at full speed when AC power is on. This means that my workstation > > (and servers, once I upgrade them) now consumes significantly more > >

Re: arm64: new gpiokeys(4)

2021-11-09 Thread Jan Stary
On Nov 09 15:43:04, k...@openbsd.org wrote: > This populates `systat sensors' with the correct lid status on my > Pinebook Pro: > > -gpio-key-lid at mainbus0 not configured > -gpio-key-power at mainbus0 not configured > +gpiokeys0 at mainbus0: "Lid" > +gpiokeys0 at

Re: add 802.11n 40MHz support to iwn(4)

2021-11-09 Thread Jan Stary
On Nov 09 00:36:03, h...@stare.cz wrote: > As a naive test of speed, I am downloading a 100MB file > from a http server just behind the AP with > ftp -o /dev/null http://stare.cz/.tmp/file > An average of ten runs is 5.31 MB/s without the diff > and 3.37 MB/s with the (updated) diff. Any idea how

Re: add 802.11n 40MHz support to iwn(4)

2021-11-08 Thread Jan Stary
On Nov 01 12:56:26, s...@stsp.name wrote: > This patch adds 802.11n 40MHz support to the iwn(4) driver. > > This driver supports many different devices. Please try to be precise > about which device you have tested so I can maintain a record of our > test coverage. This is current/amd64 on a

doas needs doas.conf

2021-02-19 Thread Jan Stary
Say explicitly that doas needs doas.conf to exist, and point to the example one. Jan Index: doas.1 === RCS file: /cvs/src/usr.bin/doas/doas.1,v retrieving revision 1.25 diff -u -p -r1.25 doas.1 --- doas.1 16 Jan 2021

Re: extern int optreset not needed

2020-12-27 Thread Jan Stary
On Dec 26 23:24:57, h...@stare.cz wrote: > ftpd doesn't need to declare extern int optreset > as that is already done in the included unistd.h Here's more for usr.sbin/, if desirable. Jan Index: usr.sbin//amd/amd/get_args.c

extern int optreset not needed

2020-12-26 Thread Jan Stary
ftpd doesn't need to declare extern int optreset as that is already done in the included unistd.h Jan Index: popen.c === RCS file: /cvs/src/libexec/ftpd/popen.c,v retrieving revision 1.29 diff -u -p -r1.29 popen.c ---

Re: mixerctl names

2020-10-17 Thread Jan Stary
On Oct 17 11:12:28, cpb_t...@bennettconstruction.us wrote: > On Sat, Oct 17, 2020 at 05:52:58PM +0200, Jan Stary wrote: > > Currently, mixerctl.conf(5) says > > > > Most devices have a number of digital to analogue converters > > (DACs), used for sound

mixerctl names

2020-10-17 Thread Jan Stary
Currently, mixerctl.conf(5) says Most devices have a number of digital to analogue converters (DACs), used for sound playback, and each DAC has a corresponding output mixer. The mixers are labelled “mix” or “sel”. That doesn't seem to be the case, at least not universaly

Re: acpicpu(4) and ACPI0007

2020-08-01 Thread Jan Stary
On Aug 01 18:23:08, jonat...@d14n.org wrote: > Much better theory: the acpicpu_sc array has MAXCPUS elements, but on this > system (and all R6415s, as far as I can tell) we have more acpicpu devices > than that. I suppose we should just make acpicpu_match fail if cf->cf_unit > is >= MAXCPUS as we

Re: LOCALE_HOME for strtime(3)

2020-08-01 Thread Jan Stary
ping On Jul 16 09:23:22, h...@stare.cz wrote: > On Jul 15 15:48:41, mill...@openbsd.org wrote: > > Upstream tzcode removed the LOCALE_HOME bits in 2014. There's no > > reason for us to keep it. > > With that removed, the header file can go too. > > Jan > > > Index:

LC_MESSAGES in xargs(1)

2020-07-16 Thread Jan Stary
Does xargs need to set LC_MESSAGES? Jan Index: usr.bin/xargs/xargs.c === RCS file: /cvs/src/usr.bin/xargs/xargs.c,v retrieving revision 1.34 diff -u -p -r1.34 xargs.c --- usr.bin/xargs/xargs.c 12 Jun 2018 15:24:31

Re: LOCALE_HOME for strtime(3)

2020-07-16 Thread Jan Stary
On Jul 15 15:48:41, mill...@openbsd.org wrote: > Upstream tzcode removed the LOCALE_HOME bits in 2014. There's no > reason for us to keep it. With that removed, the header file can go too. Jan Index: lib/libc/time/strftime.c

LOCALE_HOME for strtime(3)

2020-07-15 Thread Jan Stary
The OpenBSD libc tends to ignore the LC_* except LC_CTYPE. However, strftime(3) seems to support a LOCALE_HOME thing, where the user overrides LC_TIME with his own names of months etc. Looking at http://cvsweb.openbsd.org/src/lib/libc/time/strftime.c , it has been there since the beginning. The

no need for "extern optind" etc

2020-07-15 Thread Jan Stary
This is in the vein of https://marc.info/?l=openbsd-cvs=158170787221615=2 declares "extern int optind" and friends, so there is no need to declare them again. Still builds on current/amd64. Leaving out gnu, nsd, unbound (third party) and tic (is that third party)? Also leaving out pr and rcs

dd bs= supercede ibs= and obs=

2020-02-15 Thread Jan Stary
On Feb 14 17:04:51, schwa...@usta.de wrote: > Jason McIntyre wrote on Fri, Feb 14, 2020 at 07:28:59AM +: > > On Thu, Feb 13, 2020 at 11:25:07PM +0100, Jan Stary wrote: > >> * Fix a factual error in the description of bs: it does not > >> supersede ibs/obs,

Re: dd(1) wording and style

2020-02-15 Thread Jan Stary
Hi, On Feb 14 17:37:27, schwa...@usta.de wrote: > Hi, > > Jason McIntyre wrote on Fri, Feb 14, 2020 at 07:28:59AM +: > > On Thu, Feb 13, 2020 at 11:25:07PM +0100, Jan Stary wrote: > > >> -.It Cm seek= Ns Ar n > >> +.It Cm seek Ns = Ns Ar n >

Re: extern already declared

2020-02-13 Thread Jan Stary
-u -p -r1.15 fmt_test.c > --- regress/lib/libutil/fmt_scaled/fmt_test.c 16 Mar 2017 02:42:31 - > 1.15 > +++ regress/lib/libutil/fmt_scaled/fmt_test.c 9 Feb 2020 16:23:49 - > @@ -36,8 +36,6 @@ __dead static void usage(int stat) > int > main(int argc, char **argv)

Re: remove needless #ifdef

2020-02-13 Thread Jan Stary
On Feb 10 09:28:38, yasu...@openbsd.org wrote: > Hi, > > On Sun, 09 Feb 2020 19:28:50 +0100 > Jeremie Courreges-Anglas wrote: > > On Sun, Feb 09 2020, Jan Stary wrote: > >> Currently, sys/net/pipex_local.h asks #ifdef __OpenBSD__ > >> and if so, defines &qu

Re: dd(1) wording and style

2020-02-13 Thread Jan Stary
On Feb 13 23:25:07, h...@stare.cz wrote: > This diff changes the dd(1) manpage in the following ways: > > * Replace "It Cm if= Ns Ar file" with "It Cm if Ns = Ns Ar file" > and similarly for others. The operand is "if", not "if="; > the "Ns = Ns" might be a slightly excessive markup, > but

dd(1) wording and style

2020-02-13 Thread Jan Stary
This diff changes the dd(1) manpage in the following ways: * Replace "It Cm if= Ns Ar file" with "It Cm if Ns = Ns Ar file" and similarly for others. The operand is "if", not "if="; the "Ns = Ns" might be a slightly excessive markup, but common: grep -Fr 'Ns = Ns' /usr/share/man | wc -l

Re: Audio control API, part 1: libsndio, sndiod bits

2020-02-12 Thread Jan Stary
On Feb 12 21:38:56, a...@caoua.org wrote: > On Wed, Feb 12, 2020 at 09:22:20PM +0100, Jan Stary wrote: > > Hi, > > > > On Feb 09 13:13:02, a...@caoua.org wrote: > > > cd /usr/src > > > patch -p0 <1.diff > > > patch -p0 <2.diff > >

Re: Audio control API, part 1: libsndio, sndiod bits

2020-02-12 Thread Jan Stary
Hi, On Feb 09 13:13:02, a...@caoua.org wrote: > cd /usr/src > patch -p0 <1.diff > patch -p0 <2.diff > patch -p0 <3.diff > cd /usr/src/include && doas make includes > cd /usr/src/lib/libsndio && make obj && make && doas make install > cd /usr/src/lib/libossaudio && make obj && make && doas make

Re: Audio control API, part 1: libsndio, sndiod bits

2020-02-12 Thread Jan Stary
Hi, On Feb 09 13:13:02, a...@caoua.org wrote: > cd /usr/src > patch -p0 <1.diff > patch -p0 <2.diff > patch -p0 <3.diff > cd /usr/src/include && doas make includes > cd /usr/src/lib/libsndio && make obj && make && doas make install > cd /usr/src/lib/libossaudio && make obj && make && doas make

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Jan Stary
On Feb 10 14:53:33, mill...@openbsd.org wrote: > On Mon, 10 Feb 2020 17:12:53 +0100, Jan Stary wrote: > > > The -r option of newsyslog(8) removes the requirement > > that newsyslog runs as root. Would it also make sense > > to not try to send the SIGHUP to syslogd in th

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Jan Stary
Hi Ingo, On Feb 10 22:40:20, schwa...@usta.de wrote: > > The -r option of newsyslog(8) removes the requirement > > that newsyslog runs as root. Would it also make sense > > to not try to send the SIGHUP to syslogd in that case? > > While i'm not sure that i want to take care of this patch, >

don't try to signal with newsyslog -r

2020-02-10 Thread Jan Stary
The -r option of newsyslog(8) removes the requirement that newsyslog runs as root. Would it also make sense to not try to send the SIGHUP to syslogd in that case? Jan Index: newsyslog.8 === RCS file:

setlocale() in cron

2020-02-10 Thread Jan Stary
Why does cron(8) and crontab(1) need to setlocale()? Jan Index: cron.c === RCS file: /cvs/src/usr.sbin/cron/cron.c,v retrieving revision 1.77 diff -u -p -r1.77 cron.c --- cron.c 23 Oct 2017 15:15:22 - 1.77 +++

cp.c and rm.c embedded in mv(1)

2020-02-10 Thread Jan Stary
mv code contains copies of cp.c and rm.c - is that so that mv can avoid the fork+exec (and call the relevant cp/rm code itself)? If so, is it so that mv can be pledged? It isn't. There must be something worth the duplication ... Jan

Re: Add -R alias to -r for scp(1)

2020-02-09 Thread Jan Stary
On Jan 02 11:30:35, es...@nerim.net wrote: > Once in three times, I type scp -R and go "oh fuck" when it doesn't work. Same here with 'ssh -p' vs 'scp -P'.

remove the 'support' for troff fonts in lp[rd]

2020-02-09 Thread Jan Stary
(Replying to an old thread) On Jan 28 12:06:42, chrisbenn...@bennettconstruction.us wrote: > #define _PATH_VFONT "/usr/libdata/vfont/" > #define _PATH_VFONTB"/usr/libdata/vfont/B" > #define _PATH_VFONTI"/usr/libdata/vfont/I" > #define

Re: extern already declared

2020-02-09 Thread Jan Stary
On Feb 09 09:49:35, mill...@openbsd.org wrote: > On Sun, 09 Feb 2020 17:46:51 +0100, Jan Stary wrote: > > > Whenever unistd.h declares getopt(3), it also declares > > the extern optind and optarg, so files including unistd.h > > don't need to declare those themselves, ri

afile.h not wav.h

2020-02-09 Thread Jan Stary
The afile.h include has been so named for some time but the corresponding #define has not been changed from WAV_H - not that it matters much of course. Jan Index: afile.h === RCS file: /cvs/src/usr.bin/aucat/afile.h,v

extern already declared

2020-02-09 Thread Jan Stary
Whenever unistd.h declares getopt(3), it also declares the extern optind and optarg, so files including unistd.h don't need to declare those themselves, right? Jan Index: games/fortune/strfile/strfile.c === RCS file:

remove needless #ifdef

2020-02-09 Thread Jan Stary
Currently, sys/net/pipex_local.h asks #ifdef __OpenBSD__ and if so, defines "Static" to be nothing, to use it later. That can go away, right? Jan Index: sys/net/pipex_local.h === RCS file: /cvs/src/sys/net/pipex_local.h,v

EC_POINT_new.3 glitch

2019-03-18 Thread Jan Stary
This seems to be a missed newline. Jan Index: EC_POINT_new.3 === RCS file: /cvs/src/lib/libcrypto/man/EC_POINT_new.3,v retrieving revision 1.9 diff -u -p -r1.9 EC_POINT_new.3 --- EC_POINT_new.3 29 Mar 2018 20:56:49

zic(8) unneeded header

2019-01-11 Thread Jan Stary
zic.c does not need to include Jan Index: zic.c === RCS file: /cvs/src/usr.sbin/zic/zic.c,v retrieving revision 1.22 diff -u -p -r1.22 zic.c --- zic.c 15 Mar 2016 19:50:47 - 1.22 +++ zic.c 11 Jan 2019

locale in locate(1)

2019-01-10 Thread Jan Stary
Does locate(1) need to setlocale(3)? Jan Index: locate/locate.c === RCS file: /cvs/src/usr.bin/locate/locate/locate.c,v retrieving revision 1.31 diff -u -p -r1.31 locate.c --- locate/locate.c 19 Nov 2015 21:46:05 -

locale in comm(1)

2019-01-10 Thread Jan Stary
Does comm(1) need to setlocale(3)? It uses strcoll(3) by default, which ignores the locale and does what strcmp(3) does, or strcasecmp(3) with -f, which ignores the locale too. So remove the setlocale(3), remove the header, the LC_ that have been commented out since the initial revision in 1995,

LC_TIME in calendar(1)

2019-01-10 Thread Jan Stary
calendar imho doesn't need to setlocale(LC_TIME, ...) before and after strftime(3), as LC_TIME is ignored. Jan Index: day.c === RCS file: /cvs/src/usr.bin/calendar/day.c,v retrieving revision 1.34 diff -u -p -r1.34 day.c ---

Re: LC_NUMERIC in wprintf(3)

2019-01-10 Thread Jan Stary
On Jan 10 14:43:39, h...@stare.cz wrote: > The wprintf(3) manpage says > > The decimal point character is defined > in the program's locale (category LC_NUMERIC) > > but LC_NUMERIC is ignored in OpenBSD's C library, > as explained in setlocale(3). > > Would it be an improvement to

LC_NUMERIC in wprintf(3)

2019-01-10 Thread Jan Stary
The wprintf(3) manpage says The decimal point character is defined in the program's locale (category LC_NUMERIC) but LC_NUMERIC is ignored in OpenBSD's C library, as explained in setlocale(3). Would it be an improvement to remove that sentence? (Removing a needless newline while

Re: pcap_dispatch() returning zero

2018-12-20 Thread Jan Stary
No really, it reads 20 packets and returns zero. On Dec 08 13:56:09, h...@stare.cz wrote: > The return value of pcap_dispatch() is described in pcap.3 as follows: > > The number of packets read is returned. > Zero is returned when EOF is reached in a savefile. > A return of -1 indicates an

Re: pcap_dispatch() returning zero

2018-12-14 Thread Jan Stary
ping On Dec 08 13:56:09, h...@stare.cz wrote: > The return value of pcap_dispatch() is described in pcap.3 as follows: > > The number of packets read is returned. > Zero is returned when EOF is reached in a savefile. > A return of -1 indicates an error in which case ... > > It will also

[no subject]

2018-12-10 Thread Jan Stary
Currently, pcap_setdirection() is described in pcap.3 as follows: pcap_setdirection() is used to limit the direction that packets must be flowing in order to be captured. The "direction" is not described, except in pcap.h. Should the constants be mentioned in the manpage? Also, the direction

pcap_dump() arguments

2018-12-10 Thread Jan Stary
pcap_dump() is described in pcap.3 as follows: pcap_dump() outputs a packet to the savefile opened with pcap_dump_open(). Note that its calling arguments are suitable for use with pcap_dispatch(). That formulation is imho not entirely clear, as the arguments mention no "savefile". (Looking

pcap_dispatch() returning zero

2018-12-08 Thread Jan Stary
The return value of pcap_dispatch() is described in pcap.3 as follows: The number of packets read is returned. Zero is returned when EOF is reached in a savefile. A return of -1 indicates an error in which case ... It will also return zero on the last short read (as "EOF is reached"). So

ifconfig DIAGNOSTICS

2018-10-22 Thread Jan Stary
The wording of ifconfig DIAGNOSTICS can possibly baffle a non-native speaker (such as me) with Messages indicating the specified interface does not exist, namely, only after parsing the (non)sentence does one realize that the diagnostics consists of messages indicating THAT the interface does

interpolation -> interpretation

2018-04-11 Thread Jan Stary
I am not a native speaker, but printf(3) "interprets" the conversion specifiers, it does not "interpolate" them, right? Jan Index: printf.3 === RCS file: /cvs/src/lib/libc/stdio/printf.3,v retrieving revision 1.78 diff -u -p

/usr/local/sbin in default PATH?

2017-12-06 Thread Jan Stary
Both _PATH_DEFPATH and _PATH_STDPATH, as defined in paths.h, include /usr/local/bin but not /usr/local/sbin, as opposed to /usr/bin:/bin:/usr/sbin:/sbin. Is that intentional? Jan Index: include/paths.h === RCS file:

  1   2   3   >