ftp(1): tls_close(3) handle TLS_WANT_POLLIN, TLS_WANT_PLLOUT

Hi, tls_close() could return TLS_WANT_POLLIN, TLS_WANT_POLLOUT as well. This diff repeats the call immediately. Ok? cvs server: Diffing . Index: fetch.c === RCS file: /cvs/src/usr.bin/ftp/fetch.c,v retrieving revision 1.161 diff -u

Re: ftp doesn't close(2) the output file

Theo de Raadt writes: >> > Index: fetch.c >> > === >> > RCS file: /cvs/src/usr.bin/ftp/fetch.c,v >> > retrieving revision 1.161 >> > diff -u -p -r1.161 fetch.c >> > --- fetch.c28 Feb 2017 06:31:12 -

Re: ftp doesn't close(2) the output file

Stuart Henderson writes: > ftp doesn't close the output file after writing it. Normally you're > exiting anyway at that point so it doesn't really matter, but if you've > specified multiple URLs on the command line this leaks 1 FD per > requested file. Most noticable if

Re: smtpd: more internal cleanups

Eric Faurot writes: > Hi. > > When using the internal io api, the caller had to explicitely reset an > io event in some cases (basically when data is buffered outside of an > io callback context) which could easily be missed. This has been the > cause of some of smtpd bugs in the past (hanging

Re: smtpd: simplify internal io api

Eric Faurot writes: > The api user should not have to care about normalizing the io input > buffer (i.e. resetting the read/write pos in the buffer). > Do it internally when reloading the io event. > > Eric. Ok sunil@ > > Index: bounce.c >

Re: mg: Collect forked off children from M-| command

On Wed, Sep 07, 2016 at 12:05:22PM +, Mark Lumsden wrote: > Source Joachim Nilsson: > > Collect forked off children from M-| command > > Mg left zombies from commands executed when piping a region of text to > an external command. This patch makes sure to collect for the child >

Re: Another step in cleaning the smtpd exit path.

On Sun, Sep 04, 2016 at 05:02:07PM +0200, Eric Faurot wrote: > > The smtpd processes are not expected to ever leave their event loop. > So stop pretending that the *_shutdown() functions could ever be called > in this context, and just fatal() if event_dispatch() returns. > > Eric. Ok sunil@

Re: [patch] mg: Prevent out-of-bounds read when PATH="/:..."

> On Tue, Jan 19, 2016 at 12:35:27PM +0100, Sunil Nimmagadda wrote: > > > > - dlen = strlen(dir); > > > - while (dir[dlen-1] == '/') > > > - dir[--dlen] = '\0'; /* strip trailing '/' */ > > > dlen cou

Re: makemap call in etc/mail/Makefile

> Hi OpenBSD devs, > > there is no more makemap[1]. > > [1]: http://www.openbsd.org/faq/current.html#20151207 That is smtpd(8)'s internal implementation of makemap as a seperate executable that got merged and not /usr/sbin/makemap. makemap(8) still exists and mailwrapper(8) would call an

Re: [patch] mailwrapper: remove broken fallback code

> If /etc/mailer.conf doesn't exist, mailwrapper tries to run sendmail, > giving a confusing error message: > > mailwrapper: cannot exec /usr/libexec/sendmail/sendmail: No such > file or directory > > This patch removes this fallback code. I believe this is cleaner than > updating the fallback

http(1) An alternate implementation for a subset of ftp(1)

Hi, http(1) is a drop-in substitute for ftp(1)'s AUTO-FETCHING FILES mode. It defaults to HTTP method when the url doesn't specify the protocol and supports transferring files from HTTP(S) and FTP servers. The FTP support is limited to file transfer and doesn't do command interpretation. It

Re: http(1) An alternate implementation for a subset of ftp(1)

On Mon, Aug 17, 2015 at 06:06:17PM +0200, Sebastien Marie wrote: Hi, I start reading your code, and I have a first remark. I see in main.c (at line 142 and next) that on redirection, you trust the server for the filename. I am not sure it is a good thing to do. If the user request

pkg_add: Adjust problem detection

Hi, 213 is a valid return code from an FTP server for SIZE command and should not be treated as a problem. Alternate implementations of FETCH_CMD could provide a slightly different Requesting url log lines. Would it be okay to relax the format a bit and ignore any line starting with Requesting

Re: ftp(1) rewrite

On Thu, May 21, 2015 at 11:16:09PM -0400, Ted Unangst wrote: Sunil Nimmagadda wrote: Hi, The idea is to start with the subset of ftp(1) functionality needed by pkg_add(1): ftp [-o output] url ... i.e., should be able to download files over HTTP(S) and FTP

ftp(1) rewrite

: ftp.c === RCS file: ftp.c diff -N ftp.c --- /dev/null 1 Jan 1970 00:00:00 - +++ ftp.c 21 May 2015 18:23:37 - @@ -0,0 +1,39 @@ +/* + * Copyright (c) 2015 Sunil Nimmagadda su...@nimmagadda.net + * + * Permission to use

Re: Byte range implementation for httpd(8)

On Sat, May 02, 2015 at 02:49:30PM +, Florian Obser wrote: Sorry for the very late reply, I'm currently very busy :/ Thank you for taking time to review it. A new patch with style nits fixed and a gratuitous NULL check removed. [trimming some text] this is missing the

Re: Byte range implementation for httpd(8)

Any interest/comments/suggestions for this diff... On Fri, Apr 17, 2015 at 05:04:01AM +0200, Sunil Nimmagadda wrote: Range requests as defined in RFC7233 is required for resuming interrupted http(s) downloads for example: ftp -C http://foo.bar/install57.iso With this diff, httpd parses

Byte range implementation for httpd(8)

Range requests as defined in RFC7233 is required for resuming interrupted http(s) downloads for example: ftp -C http://foo.bar/install57.iso With this diff, httpd parses Range header in the requests and provide either 206(Partial Content) or 416(Range not Satisfiable) responses with Content-Range

tls_init(3): mention tls_accept_socket function

Hi, tls_accept_socket function missing in tls_init(3) manpage. Index: tls_init.3 === RCS file: /cvs/src/lib/libtls/tls_init.3,v retrieving revision 1.4 diff -u -p -r1.4 tls_init.3 --- tls_init.3 11 Nov 2014 04:17:34 - 1.4

mail(1): new ~i to ignore message headers unconditionally

There isn't a way to reply to a message without pulling in message headers as part of the body. This diff introduces a new tilde escape to ignore all the message headers regardless of ignore, retain commands. Comments? Index: collect.c

list colon modifiers in mail(1) manpage

This diff adds colon modifiers which could be used to specify lists. Index: mail.1 === RCS file: /cvs/src/usr.bin/mail/mail.1,v retrieving revision 1.60 diff -u -p -r1.60 mail.1 --- mail.1 7 Nov 2010 08:05:56 - 1.60

pop3 daemon with ssl/tls and STARTTLS, V2

Second iteration... 1. Fixed CRLF issues in RETR and TOP commands that caused message truncation. 2. Properly byte stuff a line beginning with termination character . . 3. Implemented STLS and CAPA. (STARTTLS RFC 2595) Comments? Source: https://poolp.org/~sunil/pop3d.tar.gz uuencoded gzipped

Re: tinyscheme + mg

On Thu, Jun 28, 2012 at 10:05:49PM +0500, Mark Lumsden wrote: I'd be a lot happier voicing an opinion in support of something like this if I also saw diffs and interest in *using* them to extend functionality later or replace some things easier to do with scheme to make the code

Re: cscope support in mg

to the mocklisp Index: cscope.c === RCS file: cscope.c diff -N cscope.c --- /dev/null 1 Jan 1970 00:00:00 - +++ cscope.c30 May 2012 16:41:25 - @@ -0,0 +1,612 @@ +/* + * Copyright (c) 2012 Sunil Nimmagadda su...@sunilnimmagadda.com

Re: Pipe text from mg to external command

A refined version of the diff with 2 less bugs and shorter by ~40 or so lines. Changes from previous version... Reuse region_get_data() to extract C string from selected region instead of custom line by line iteration, thereby reducing number of send(2) syscalls. Fix a bug which causes

Re: Pipe text from mg to external command

This version implements some off-list review comments... 1. Discard explicit checking whether command exists and it's permissions since shell already does and reports error. 2. Remove unnecessary bzero call. 3. Document minor deviation from emacs behaviour in README. Index: README

Re: Pipe text from mg to external command

Third attempt, and these are the changes done since the first version of this diff. 1. Check for existence of the command to be executed and also the permissions. 2. Replace popen(3) which messed stdout with socketpair(2), fork(2) and execl(2). 3. IO multiplexing using poll(2) to prevent

Re: Pipe text from mg to external command

This version properly captures data from external command and puts it into *Shell Command Output* buffer. These are the new commands added to mg with this diff... C-x h mark-whole-buffer M-| shell-command-on-region Comments? Index: buffer.c

cscope support in mg

On Fri, Sep 02, 2011 at 02:23:28PM -0300, Christiano F. Haesbaert wrote: On 2 September 2011 14:17, Matthew Dempsky matt...@dempsky.org wrote: On Fri, Sep 2, 2011 at 8:55 AM, Sunil Nimmagadda su...@sunilnimmagadda.com wrote: This diff adds tags support to Mg. I am NOT an emacs user so

Hooks in mg

- @@ -0,0 +1,157 @@ +/* + * Copyright (c) 2012 Sunil Nimmagadda su...@sunilnimmagadda.com + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear

Pipe text from mg to external command

This diff allows a user pipe text from current region in mg to external command. Also adds a command to mark whole buffer. Comments? Index: def.h === RCS file: /home/sunil/cvs/src/usr.bin/mg/def.h,v retrieving revision 1.118 diff -u

Fix crash in pop-tag-mark of mg

pop-tag-mark crashes when the buffer's directory is different from mg's cwd. Steps to reproduce... generate some tags : # cd /usr/src/usr.bin/mg cvs up make make install # cd /usr/src/sys make tags use them : # mg /usr/src/sys/dev/softraid_crypto.c (for example) then M-x visit-tag-table give

Re: ctags(1) and mg(1) again

, there is currently no Index: tags.c === RCS file: tags.c diff -N tags.c --- /dev/null 1 Jan 1970 00:00:00 - +++ tags.c 24 Nov 2011 05:50:13 - @@ -0,0 +1,533 @@ +/* + * Copyright (c) 2011 Sunil Nimmagadda su...@sunilnimmagadda.com

Re: ctags(1) and mg(1) again

Jan 1970 00:00:00 - +++ tags.c 24 Nov 2011 05:50:13 - @@ -0,0 +1,533 @@ +/* + * Copyright (c) 2011 Sunil Nimmagadda su...@sunilnimmagadda.com + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided

Re: ctags(1) and mg(1) again

+++ tags.c 15 Nov 2011 04:02:53 - @@ -0,0 +1,520 @@ +/* + * Copyright (c) 2011 Sunil Nimmagadda su...@sunilnimmagadda.com + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice

Re: ctags(1) and mg(1) again

tags.c --- /dev/null 1 Jan 1970 00:00:00 - +++ tags.c 7 Nov 2011 17:47:24 - @@ -0,0 +1,347 @@ +/* + * Copyright (c) 2011 Sunil Nimmagadda su...@sunilnimmagadda.com + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby

Re: ctags(1) and mg(1) again

Sunil Nimmagadda su...@sunilnimmagadda.com + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED

ctags(1) and mg(1) again

Hello, This time a little smaller and a simplified diff. A brief outline of what it does... 1) During mg startup it checks and loads a file named tags in pwd. 2) M-. would jump to the definition of identifier under cursor if it has an entry in tags file. 3) MS-* pops back to the location before

Re: ctags(1) and mg

On Fri, Sep 02, 2011 at 10:17:02AM -0700, Matthew Dempsky wrote: On Fri, Sep 2, 2011 at 8:55 AM, Sunil Nimmagadda su...@sunilnimmagadda.com wrote: This diff adds tags support to Mg. I am NOT an emacs user so if this combination is a bit odd then please excuse. It parses the tags file

Re: ctags(1) and mg

On Sat, Sep 03, 2011 at 07:12:40PM +0300, Henri Kemppainen wrote: Being a little less stupid this time. Rewrote the string handling part, style(9) formatting and refactored pushtag function. Some thoughts about this. Are you sure you're not going to overflow t in re_tag_conv when you

ctags(1) and mg

Hello, This diff adds tags support to Mg. I am NOT an emacs user so if this combination is a bit odd then please excuse. It parses the tags file generated by ctags(1) and maintains a tree. M-. on first character of a word jumps to it's definition and M-* jumps back to previous location. Index: