Re: [PATCH] Correctly (per POSIX) round up df usage percentage

2023-01-01 Thread Todd C . Miller
On Mon, 29 Aug 2022 13:51:13 +0200, =?utf-8?B?0L3QsNCx?= wrote: > In that case, how about this scissor-patch? > It has the added benefit of removing the existing floating-point usage. That version looks good to me, committed. - todd

Re: [PATCH] Correctly (per POSIX) round up df usage percentage

2022-12-31 Thread наб
Hi! Ran into this /again/ in my CI environment; I've validated, again, that this patch applies to current git, and that it applies the rounding correctly. Best, On Mon, Aug 29, 2022 at 01:51:14PM +0200, наб wrote: > Subject: [PATCH] Correctly (per POSIX) round up df usage percentage > &

Re: [PATCH] Correctly (per POSIX) round up df usage percentage

2022-08-29 Thread наб
POSIX) round up df usage percentage Quoth POSIX Issue 7: The percentage of the normally available space that is currently allocated to all files on the file system. This shall be calculated using the fraction: /( + ) expressed as a percentage. This percentage may be greate

Re: [PATCH] Correctly (per POSIX) round up df usage percentage

2022-08-29 Thread Theo de Raadt
t;Subject: Re: [PATCH] Correctly (per POSIX) round up df usage percentage >References: <20220827135316.4l2aawaoylbmb...@tarta.nabijaczleweli.xyz> > >MIME-Version: 1.0 >Content-Type: multipart/signed; micalg=pgp-sha512; > protocol="application/pgp-signature"; boun

Re: [PATCH] Correctly (per POSIX) round up df usage percentage

2022-08-29 Thread наб
Hi! On Sat, Aug 27, 2022 at 05:20:00PM +0100, Stuart Henderson wrote: > df is used on the ramdisk, so this would need testing there (at least on > the tighter media on some archs). > > at least one other ramdisk binary does pull in libm so the overall size > increase might not be terrible, but

Re: [PATCH] Correctly (per POSIX) round up df usage percentage

2022-08-27 Thread Stuart Henderson
On 2022/08/27 15:53, наб wrote: > PROG=df > SRCS=df.c ffs_df.c ext2fs_df.c > -LDADD= -lutil > -DPADD= ${LIBUTIL} > +LDADD= -lutil -lm > +DPADD= ${LIBUTIL} ${LIBM} df is used on the ramdisk, so this would need testing there (at least on the tighter media

[PATCH] Correctly (per POSIX) round up df usage percentage

2022-08-27 Thread наб
Quoth POSIX Issue 7: The percentage of the normally available space that is currently allocated to all files on the file system. This shall be calculated using the fraction: /( + ) expressed as a percentage. This percentage may be greater than 100 if is less than