Re: [PATCH] ifconfig: keep track of allowed ips pointer correctly

2020-11-04 Thread Klemens Nanni
On Tue, Oct 27, 2020 at 06:16:08PM +0100, Jason A. Donenfeld wrote: > Somebody on IRC mentioned that using ifconfig to set wgallowedips wasn't > working on macppc. I don't have a macppc to test this on, but it seems > like the code is assuming that the two values printed out by this test > program

Re: [PATCH] ifconfig: keep track of allowed ips pointer correctly

2020-10-30 Thread wictory
Hi! On Tue, Oct 27, 2020 at 06:16:08PM +0100, Jason A. Donenfeld wrote: > Somebody on IRC mentioned that using ifconfig to set wgallowedips wasn't > working on macppc. It isn't working on armv7 either. I posted on bugs@ earlier, but it seems the problem I found might be the same as is being

Re: [PATCH] ifconfig: keep track of allowed ips pointer correctly

2020-10-28 Thread Klemens Nanni
On Tue, Oct 27, 2020 at 06:16:08PM +0100, Jason A. Donenfeld wrote: > I don't have a macppc in order to test this, but it works on amd64. Using the EXAMPLES code from wg(4) as is, this makes things work on macppc.

Re: [PATCH] ifconfig: keep track of allowed ips pointer correctly

2020-10-27 Thread Philip Guenther
On Tue, Oct 27, 2020 at 9:18 AM Jason A. Donenfeld wrote: ... > @@ -5721,16 +5720,18 @@ growwgdata(size_t by) > if (wg_aip != NULL) > wg_aip = (void *)wg_interface + aip_offset; > > - ret = (void *)wg_interface + wgdata.wgd_size - by; > - bzero(ret, by); > - >

[PATCH] ifconfig: keep track of allowed ips pointer correctly

2020-10-27 Thread Jason A. Donenfeld
Somebody on IRC mentioned that using ifconfig to set wgallowedips wasn't working on macppc. I don't have a macppc to test this on, but it seems like the code is assuming that the two values printed out by this test program must always be the same: struct s { int i; }; struct p {