On Mon, Aug 29, 2022 at 09:08:26AM +0200, Greg Steuck wrote:
> Greg Steuck writes:
>
> Matthieu> + authok = priv_pw_check(user, style, pass);
>
> I suspect your original patch may have swapped the arguments. The
> password should go before style.
Oops you're right thanks.
>
> What do
Greg Steuck writes:
Matthieu> + authok = priv_pw_check(user, style, pass);
I suspect your original patch may have swapped the arguments. The
password should go before style.
What do you thing about this patch (tested locally, but I don't have style):
diff --git
Hi Matthieu,
I'd be inclined to go with a return in the middle and avoid some extra
variables, what do you think about the following (entirely eye-ball tested)?
char*pass;
/* buffer can be in the form style:pass */
if ((pass = strchr(buffer, ':')) != NULL) {
ok ?
(although I didn't get an answer from Jean-Michel yet, I'm quite sure
the issue is real and the fix correct).
- Forwarded message from Matthieu Herrb -
Date: Tue, 23 Aug 2022 11:08:28 +0200
From: Matthieu Herrb
To: BESSOT Jean-Michel
Cc: b...@openbsd.org
Subject: Re: xlock don't
