Re: [patch] patch:util.c does free memory after strdup(3)

2010-01-08 Thread Owain Ainsworth
On Fri, Jan 08, 2010 at 12:45:11AM +0300, Igor Zinovik wrote: Hello, t...@. tmpbuf is allocated via strdup(3) but it is leaved unfreed when we leave makedirs() function. I have commited a few of these (this one, the libc/hash one and the pwd_mkdb one). I shall look at the others shortly.

Re: [patch] patch:util.c does free memory after strdup(3)

2010-01-08 Thread Igor Zinovik
2010/1/8 Stuart Henderson s...@spacehopper.org: On 2010/01/08 13:33, Owain Ainsworth wrote: Please note that none of your patches apply because of spaces in the whitespace instead of tabs (I applied them manually). Either your mail client is mangling the diffs, or you're copy/pasting the diffs

Re: [patch] patch:util.c does free memory after strdup(3)

2010-01-08 Thread Alexander Hall
Stuart Henderson wrote: On 2010/01/08 13:33, Owain Ainsworth wrote: Please note that none of your patches apply because of spaces in the whitespace instead of tabs (I applied them manually). Either your mail client is mangling the diffs, or you're copy/pasting the diffs into the mail client.

[patch] patch:util.c does free memory after strdup(3)

2010-01-07 Thread Igor Zinovik
Hello, t...@. tmpbuf is allocated via strdup(3) but it is leaved unfreed when we leave makedirs() function. Index: util.c === RCS file: /OpenBSD/src/usr.bin/patch/util.c,v retrieving revision 1.33 diff -u -r1.33 util.c --- util.c