Committed, thanks.
- todd
On Sun, 15 Mar 2020 16:09:36 +0100, Hiltjo Posthuma wrote:
> Below is a patch which adds some missing casts:
Looks good to me.
- todd
On Tue, Feb 25, 2020 at 12:09:19AM +0100, Joerg Jung wrote:
>
> > On 24. Feb 2020, at 20:31, Todd C. Miller wrote:
> >
> > I have a mostly-identical patch in my tree, though I tried to improve
> > readability a bit.
>
> ok jung@
>
> > - todd
> >
> > Index: usr.sbin/smtpd/mta_session.c
> >
I am much happier with the [] array derefs.
I surprised this snuck in, time for a ctype re-audit of the entire tree
> On 24. Feb 2020, at 20:31, Todd C. Miller wrote:
>
> I have a mostly-identical patch in my tree, though I tried to improve
> readability a bit.
ok jung@
> - todd
>
> Index: usr.sbin/smtpd/mta_session.c
> ===
> RCS file:
I have a mostly-identical patch in my tree, though I tried to improve
readability a bit.
- todd
Index: usr.sbin/smtpd/mta_session.c
===
RCS file: /cvs/src/usr.sbin/smtpd/mta_session.c,v
retrieving revision 1.132
diff -u -p -u
*ping*
Any feedback for the below patch is appreciated.
Thanks,
On Sat, Feb 01, 2020 at 05:01:48PM +0100, Hiltjo Posthuma wrote:
> Hi,
>
> This (pedantic) patch fixes a few casts for ctype functions/macros, like
> isspace, isalpha and isdigit.
>
> The isspace(3) man page says:
>
> "CAVEATS
Hi,
This (pedantic) patch fixes a few casts for ctype functions/macros, like
isspace, isalpha and isdigit.
The isspace(3) man page says:
"CAVEATS
The argument c must be EOF or representable as an unsigned char;
otherwise, the result is undefined."
POSIX says:
"The c argument is an int, the
