Re: Better overflow check in bgpd

2020-12-03 Thread Claudio Jeker
On Wed, Dec 02, 2020 at 12:19:11PM +0100, Claudio Jeker wrote: > The overflow check for the relative metric adjustments of filtersets > assumes a certain overflow behaviour of signed integers. I think it is > better to write this in a way that does not involve an overflow. > Here a small follow u

Re: Better overflow check in bgpd

2020-12-02 Thread Claudio Jeker
On Wed, Dec 02, 2020 at 06:49:38AM -0700, Todd C. Miller wrote: > On Wed, 02 Dec 2020 12:19:11 +0100, Claudio Jeker wrote: > > > The overflow check for the relative metric adjustments of filtersets > > assumes a certain overflow behaviour of signed integers. I think it is > > better to write this

Re: Better overflow check in bgpd

2020-12-02 Thread Todd C . Miller
On Wed, 02 Dec 2020 12:19:11 +0100, Claudio Jeker wrote: > The overflow check for the relative metric adjustments of filtersets > assumes a certain overflow behaviour of signed integers. I think it is > better to write this in a way that does not involve an overflow. OK millert@ though I think >

Better overflow check in bgpd

2020-12-02 Thread Claudio Jeker
The overflow check for the relative metric adjustments of filtersets assumes a certain overflow behaviour of signed integers. I think it is better to write this in a way that does not involve an overflow. OK? -- :wq Claudio Index: rde_filter.c