Re: Fix alc(4) watchdog timeouts and panics

2011-01-31 Thread Gabriel Linder
On 01/30/11 06:04, Gabriel Linder wrote: This diff fix some problems on my EeePC 1005PX : - splassert failure when booting without a network cable - panic when unplugging a network cable - network does not come back when plugging a network cable - watchdog timeouts Mike Belopuhov found another

Re: Fix alc(4) watchdog timeouts and panics

2011-01-31 Thread Brad
- Original message - Mike Belopuhov found another logic bug, updated diff follows. cf http://marc.info/?l=openbsd-techm=129639859909043w=2 The function name change alc_probe to alc_match is unnecsaary and doesn't serve any purpose. It's a FreeBSDism too. The ~IFF_RUNNING change is

Re: Fix alc(4) watchdog timeouts and panics

2011-01-31 Thread Mike Belopuhov
On Mon, Jan 31, 2011 at 12:29 +0100, Gabriel Linder wrote: On 01/30/11 06:04, Gabriel Linder wrote: This diff fix some problems on my EeePC 1005PX : - splassert failure when booting without a network cable - panic when unplugging a network cable - network does not come back when plugging a

Re: Fix alc(4) watchdog timeouts and panics

2011-01-31 Thread Mike Belopuhov
On Mon, Jan 31, 2011 at 1:35 PM, Brad b...@comstyle.com wrote: Also that second chunk of alc_newbuf from mikeb@ doesn't look right. There is a logic error with the way its written but it looks like it should be moved further down within the function. there's a call to the bus_dmamap_unload

Fix alc(4) watchdog timeouts and panics (new diff)

2011-01-31 Thread Gabriel Linder
After some comments made by Brad and Mike Belopuhov, here's a new diff. Tested on EeePC 1005PX. cf. http://marc.info/?l=openbsd-techm=129636716819943w=2 Index: if_alcreg.h === RCS file: /cvs/openbsd/src/sys/dev/pci/if_alcreg.h,v

Fix alc(4) watchdog timeouts and panics

2011-01-29 Thread Gabriel Linder
This diff fix some problems on my EeePC 1005PX : - splassert failure when booting without a network cable - panic when unplugging a network cable - network does not come back when plugging a network cable - watchdog timeouts Most of the fixes are coming from FreeBSD. if_alcreg.h had only typos.