On Fri, Nov 6, 2020 at 4:51 PM George Koehler wrote:
> Your ilogb fix is ok gkoehler@
>
It's annoying that C and/or ieee754 and the original hardware
implementation in the x87 instructions diverged in their definitions, but
the former is what matters and libm needs to follow that. ok guenther@
Your ilogb fix is ok gkoehler@
On Sat, 31 Oct 2020 16:09:07 +0100 (CET)
Mark Kettenis wrote:
> - Dropping the amd64 and i386 versions. Fixing the corner cases in
> assembly is hard, and the C implementation should be fast enough for
> regular floating-point values.
The amd64 and i386
...snip...
Here is a diff that fixes those issues by:
...snip...
The code reads OK. Needs the manpage update to refer to FP_ILOGB0 not
INT_MIN.
John
As reported on bugs@ our ilogb(3) implementation is somewhat buggy.
There are several issues:
- The amd64 and i386 assembler versions not only return results that
don't match the FP_ILOGB0 and FP_ILOGBNAN defines in but
ultimately return results that are incompatible with C99 and C11.
-
