This diff makes ssh-askpass abort on ^C, like on ESC.
At times when ssh-askpass pops up behind the active window, or for some
reason is not visible, while at the same time stealing all input, ^C is
one of the "safe" key combinations that comes to my mind trying to
unlock whatever is locking up my desktop. ^Q is another one (suspecting
having pressed ^S in a terminal window. ESC is not as obvious.
Yes, this means you cannot have ^C in your passphrase.
Possibly we may want to filter out all remaining ASCII control
characters as well. This would limit passwords further, but I
would not find it unreasonable.
Thoughts? OK as-is (for now, anyway)?
/Alexander
index: x11-ssh-askpass.c
===================================================================
RCS file: /cvs/xenocara/app/ssh-askpass/x11-ssh-askpass.c,v
retrieving revision 1.7
diff -u -p -r1.7 x11-ssh-askpass.c
--- x11-ssh-askpass.c 16 Jun 2019 19:31:07 -0000 1.7
+++ x11-ssh-askpass.c 21 Jan 2022 17:11:11 -0000
@@ -1308,6 +1308,7 @@ void handleKeyPress(AppInfo *app, XEvent
case '\015':
acceptAction(app);
break;
+ case '\003':
case '\033':
cancelAction(app);
break;
