Re: MP-safe TX for cnmac(4)

2016-04-26 Thread Visa Hankala
On Tue, Apr 26, 2016 at 05:29:43PM +1000, David Gwynne wrote: > > > On 25 Apr 2016, at 02:13, Visa Hankala wrote: > > > > This adds MP-safe TX for cnmac(4). OK? > > nearly. see inline. Here is a new try. ifq_serialize() is just what the code needs. Thank

Re: MP-safe TX for cnmac(4)

2016-04-26 Thread David Gwynne
> On 25 Apr 2016, at 02:13, Visa Hankala wrote: > > This adds MP-safe TX for cnmac(4). OK? nearly. see inline. > > Index: arch/octeon/dev/if_cnmac.c > === > RCS file: src/sys/arch/octeon/dev/if_cnmac.c,v

Re: MP-safe TX for cnmac(4)

2016-04-25 Thread Visa Hankala
On Mon, Apr 25, 2016 at 04:06:08PM +0200, Martin Pieuchot wrote: > On 25/04/16(Mon) 11:35, Visa Hankala wrote: > > On Mon, Apr 25, 2016 at 10:20:32AM +0200, Martin Pieuchot wrote: > > > On 24/04/16(Sun) 16:13, Visa Hankala wrote: > > > > This adds MP-safe TX for cnmac

Re: MP-safe TX for cnmac(4)

2016-04-25 Thread Martin Pieuchot
On 25/04/16(Mon) 11:35, Visa Hankala wrote: > On Mon, Apr 25, 2016 at 10:20:32AM +0200, Martin Pieuchot wrote: > > On 24/04/16(Sun) 16:13, Visa Hankala wrote: > > > This adds MP-safe TX for cnmac(4). OK? > > > > Would it be possible to do that without mutex? Havi

Re: MP-safe TX for cnmac(4)

2016-04-25 Thread Visa Hankala
On Mon, Apr 25, 2016 at 10:20:32AM +0200, Martin Pieuchot wrote: > On 24/04/16(Sun) 16:13, Visa Hankala wrote: > > This adds MP-safe TX for cnmac(4). OK? > > Would it be possible to do that without mutex? Having the same pattern > across most of our drivers would reduce the

Re: MP-safe TX for cnmac(4)

2016-04-25 Thread Martin Pieuchot
On 24/04/16(Sun) 16:13, Visa Hankala wrote: > This adds MP-safe TX for cnmac(4). OK? Would it be possible to do that without mutex? Having the same pattern across most of our drivers would reduce the maintenance effort. > > Index: arch/octeon/dev/i

MP-safe TX for cnmac(4)

2016-04-24 Thread Visa Hankala
This adds MP-safe TX for cnmac(4). OK? Index: arch/octeon/dev/if_cnmac.c === RCS file: src/sys/arch/octeon/dev/if_cnmac.c,v retrieving revision 1.38 diff -u -p -r1.38 if_cnmac.c --- arch/octeon/dev/if_cnmac.c 13 Apr 2016 11:34:00