Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-30 Thread Otto Moerbeek
On Tue, Mar 26, 2019 at 03:52:47PM +0100, Michał Koc wrote: > W dniu 25.03.2019 o 15:08, Otto Moerbeek pisze: > > On Sat, Mar 23, 2019 at 06:07:02PM +0100, Michał Koc wrote: > > > > > ... [snip] > > This is almost good. You might fold host_ip() into net_set_sa(). the > > double malloc and copy

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-26 Thread Michał Koc
W dniu 25.03.2019 o 15:08, Otto Moerbeek pisze: On Sat, Mar 23, 2019 at 06:07:02PM +0100, Michał Koc wrote: ... [snip] This is almost good. You might fold host_ip() into net_set_sa(). the double malloc and copy isn't really needed. -Otto Done, patch follows Best regards M.K

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-25 Thread Otto Moerbeek
On Sat, Mar 23, 2019 at 06:07:02PM +0100, Michał Koc wrote: > ... [snip] This is almost good. You might fold host_ip() into net_set_sa(). the double malloc and copy isn't really needed. -Otto

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-23 Thread Otto Moerbeek
On Sat, Mar 23, 2019 at 06:07:02PM +0100, Michał Koc wrote: > W dniu 23.03.2019 o 10:09, Otto Moerbeek pisze: > > On Fri, Mar 22, 2019 at 09:57:29PM +0100, Michał Koc wrote: > > > > > W dniu 22.03.2019 o 11:19, Michał Koc pisze: > > > > W dniu 21.03.2019 o 11:52, Otto Moerbeek pisze: > > > > >

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-23 Thread Michał Koc
W dniu 23.03.2019 o 10:09, Otto Moerbeek pisze: On Fri, Mar 22, 2019 at 09:57:29PM +0100, Michał Koc wrote: W dniu 22.03.2019 o 11:19, Michał Koc pisze: W dniu 21.03.2019 o 11:52, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 09:28:28AM +0100, Michał Koc wrote: W dniu 21.03.2019 o 07:21,

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-23 Thread Otto Moerbeek
On Fri, Mar 22, 2019 at 09:57:29PM +0100, Michał Koc wrote: > W dniu 22.03.2019 o 11:19, Michał Koc pisze: > > W dniu 21.03.2019 o 11:52, Otto Moerbeek pisze: > > > On Thu, Mar 21, 2019 at 09:28:28AM +0100, Michał Koc wrote: > > > > > > > W dniu 21.03.2019 o 07:21, Otto Moerbeek pisze: > > > > >

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-22 Thread Michał Koc
W dniu 22.03.2019 o 11:19, Michał Koc pisze: W dniu 21.03.2019 o 11:52, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 09:28:28AM +0100, Michał Koc wrote: W dniu 21.03.2019 o 07:21, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 12:51:11AM +0100, Klemens Nanni wrote: On Tue, Mar 12, 2019 at

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-22 Thread Michał Koc
W dniu 22.03.2019 o 11:19, Michał Koc pisze: W dniu 21.03.2019 o 11:52, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 09:28:28AM +0100, Michał Koc wrote: W dniu 21.03.2019 o 07:21, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 12:51:11AM +0100, Klemens Nanni wrote: On Tue, Mar 12, 2019 at

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-22 Thread Michał Koc
W dniu 21.03.2019 o 11:52, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 09:28:28AM +0100, Michał Koc wrote: W dniu 21.03.2019 o 07:21, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 12:51:11AM +0100, Klemens Nanni wrote: On Tue, Mar 12, 2019 at 03:19:56PM +0100, Otto Moerbeek wrote: I also

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-21 Thread Theo de Raadt
Otto Moerbeek wrote: This lex operation seems ridiculous. Normal one does lex of free-standing digit sequences into a "number token" only if the sequence is fully digits -- see the code around pfctl/parse.y line 5368 Or don't lex numbers instead, but consider them strings (with the correct

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-21 Thread Klemens Nanni
On Thu, Mar 21, 2019 at 11:52:56AM +0100, Otto Moerbeek wrote: > Meanwhile, I tested a IPv6 setup, it works ok. > So I'm going to commit the diff below, Thanks! OK kn

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-21 Thread Otto Moerbeek
On Thu, Mar 21, 2019 at 09:28:28AM +0100, Michał Koc wrote: > W dniu 21.03.2019 o 07:21, Otto Moerbeek pisze: > > On Thu, Mar 21, 2019 at 12:51:11AM +0100, Klemens Nanni wrote: > > > On Tue, Mar 12, 2019 at 03:19:56PM +0100, Otto Moerbeek wrote: > > > > > I also fixed a case of parsing IPv6

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-21 Thread Michał Koc
W dniu 21.03.2019 o 07:21, Otto Moerbeek pisze: On Thu, Mar 21, 2019 at 12:51:11AM +0100, Klemens Nanni wrote: On Tue, Mar 12, 2019 at 03:19:56PM +0100, Otto Moerbeek wrote: I also fixed a case of parsing IPv6 addresses. Anyone willing to ok? See comments inline. And now also with a lexer

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-21 Thread Otto Moerbeek
On Thu, Mar 21, 2019 at 12:51:11AM +0100, Klemens Nanni wrote: > > On Tue, Mar 12, 2019 at 03:19:56PM +0100, Otto Moerbeek wrote: > > > I also fixed a case of parsing IPv6 addresses. > > > > > > Anyone willing to ok? > See comments inline. > > > And now also with a lexer bug fixed. Earlier I

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-20 Thread Klemens Nanni
On Tue, Mar 12, 2019 at 03:19:56PM +0100, Otto Moerbeek wrote: > > I also fixed a case of parsing IPv6 addresses. > > > > Anyone willing to ok? See comments inline. > And now also with a lexer bug fixed. Earlier I thougt it was an order > dependency in the clauses. But is was an order

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-15 Thread Otto Moerbeek
On Fri, Mar 15, 2019 at 12:46:32PM +0100, Michał Koc wrote: > W dniu 12.03.2019 o 15:19, Otto Moerbeek pisze: > > On Tue, Mar 12, 2019 at 02:02:15PM +0100, Otto Moerbeek wrote: > > > > > On Mon, Mar 11, 2019 at 05:11:56PM +0100, Otto Moerbeek wrote: > > > > > > > I was going to test your diff

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-15 Thread Michał Koc
W dniu 12.03.2019 o 15:19, Otto Moerbeek pisze: On Tue, Mar 12, 2019 at 02:02:15PM +0100, Otto Moerbeek wrote: On Mon, Mar 11, 2019 at 05:11:56PM +0100, Otto Moerbeek wrote: I was going to test your diff but it does not apply. Your mailer seems to convert spaces and or tabs to funny char

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-12 Thread Otto Moerbeek
On Tue, Mar 12, 2019 at 02:02:15PM +0100, Otto Moerbeek wrote: > On Mon, Mar 11, 2019 at 05:11:56PM +0100, Otto Moerbeek wrote: > > > > > I was going to test your diff but it does not apply. Your mailer seems > > to convert spaces and or tabs to funny char sequences. Please fix > > (test by

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-12 Thread Otto Moerbeek
On Mon, Mar 11, 2019 at 05:11:56PM +0100, Otto Moerbeek wrote: > > I was going to test your diff but it does not apply. Your mailer seems > to convert spaces and or tabs to funny char sequences. Please fix > (test by mailing to yourself and applying with patch(1)) and resend, > > -Otto >

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-11 Thread Otto Moerbeek
I was going to test your diff but it does not apply. Your mailer seems to convert spaces and or tabs to funny char sequences. Please fix (test by mailing to yourself and applying with patch(1)) and resend, -Otto

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-11 Thread Michał Koc
W dniu 11.03.2019 o 09:29, Otto Moerbeek pisze: On Sun, Mar 10, 2019 at 02:41:35PM +0100, Michał Koc wrote: W dniu 10.03.2019 o 08:10, Otto Moerbeek pisze: On Sat, Mar 09, 2019 at 11:19:11PM +0100, Michał Koc wrote: W dniu 09.03.2019 o 12:43, Otto Moerbeek pisze: On Sat, Mar 09, 2019 at

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-11 Thread Otto Moerbeek
On Sun, Mar 10, 2019 at 02:41:35PM +0100, Michał Koc wrote: > W dniu 10.03.2019 o 08:10, Otto Moerbeek pisze: > > On Sat, Mar 09, 2019 at 11:19:11PM +0100, Michał Koc wrote: > > > > > W dniu 09.03.2019 o 12:43, Otto Moerbeek pisze: > > > > On Sat, Mar 09, 2019 at 12:10:34PM +0100, Michał Koc