Re: PATCH: better error return for exFAT filesystem

2020-08-09 Thread Ted Unangst
On 2020-08-09, Jonathan Gray wrote: > mount_msdos(8) knows about EINVAL and will print "not an MSDOS filesystem" I think mount_msdos could also inspect the filesytem for the common case of exfat confusion. Index: mount_msdos.c ===

Re: PATCH: better error return for exFAT filesystem

2020-08-09 Thread Klemens Nanni
On Sun, Aug 09, 2020 at 07:48:21PM +1000, Jonathan Gray wrote: > Thinking about this some more the problem is really the choice of errno. > It used to be EINVAL but was changed to EFTYPE in > > > revision 1.7 > date: 1997/06/20 14:04:30; author: kstailey; state:

Re: PATCH: better error return for exFAT filesystem

2020-08-09 Thread Jonathan Gray
On Sat, Aug 08, 2020 at 01:13:20PM +1000, Jonathan Gray wrote: > On Fri, Aug 07, 2020 at 12:59:00PM -0700, jo...@armadilloaerospace.com wrote: > > Perform an explicit check for the unsupported exFAT MSDOS filesystem > > instead of letting it fail mysteriously when it gets cluster sizes > > of 0

Re: PATCH: better error return for exFAT filesystem

2020-08-07 Thread Jonathan Gray
On Fri, Aug 07, 2020 at 12:59:00PM -0700, jo...@armadilloaerospace.com wrote: > Perform an explicit check for the unsupported exFAT MSDOS filesystem > instead of letting it fail mysteriously when it gets cluster sizes > of 0 from the normal fields. > > This causes mount_msdos to report: >

Re: PATCH: better error return for exFAT filesystem

2020-08-07 Thread Klemens Nanni
On Fri, Aug 07, 2020 at 12:59:00PM -0700, jo...@armadilloaerospace.com wrote: > Perform an explicit check for the unsupported exFAT MSDOS filesystem > instead of letting it fail mysteriously when it gets cluster sizes > of 0 from the normal fields. > > This causes mount_msdos to report: >