Re: Properly serialize pflow's sc_outputqueue

2017-05-30 Thread Sebastian Benoit
this is basically the code i had before mpi told me that mq_ was not needed. *sigh* ok. Visa Hankala(v...@openbsd.org) on 2017.05.30 16:19:46 +: > On Wed, May 31, 2017 at 01:52:31AM +1000, Jonathan Matthew wrote: > > On Tue, May 30, 2017 at 01:04:07PM +, Visa Hankala wrote: > > > Index:

Re: Properly serialize pflow's sc_outputqueue

2017-05-30 Thread Visa Hankala
On Wed, May 31, 2017 at 01:52:31AM +1000, Jonathan Matthew wrote: > On Tue, May 30, 2017 at 01:04:07PM +, Visa Hankala wrote: > > Index: net/if_pflow.c > > === > > RCS file: src/sys/net/if_pflow.c,v > > retrieving revision 1.78 >

Re: Properly serialize pflow's sc_outputqueue

2017-05-30 Thread Jonathan Matthew
On Tue, May 30, 2017 at 01:04:07PM +, Visa Hankala wrote: > On Mon, May 29, 2017 at 03:33:35PM +, Visa Hankala wrote: > > Currently, access to pflow's sc_outputqueue is not serialized properly. > > The producer has the NET_LOCK(), while the consumer does not. > > mpi@ suggested using

Re: Properly serialize pflow's sc_outputqueue

2017-05-30 Thread Martin Pieuchot
On 30/05/17(Tue) 13:04, Visa Hankala wrote: > On Mon, May 29, 2017 at 03:33:35PM +, Visa Hankala wrote: > > Currently, access to pflow's sc_outputqueue is not serialized properly. > > The producer has the NET_LOCK(), while the consumer does not. > > mpi@ suggested using mbuf_queue to solve the

Re: Properly serialize pflow's sc_outputqueue

2017-05-30 Thread Visa Hankala
On Mon, May 29, 2017 at 03:33:35PM +, Visa Hankala wrote: > Currently, access to pflow's sc_outputqueue is not serialized properly. > The producer has the NET_LOCK(), while the consumer does not. > mpi@ suggested using mbuf_queue to solve the issue. mpi@ commented that the pflow output task